Re: [bmwg] Review of draft-vfv-bmwg-srv6-bench-meth-02.txt

Giuseppe Fioccola <giuseppe.fioccola@huawei.com> Thu, 29 September 2022 15:43 UTC

Return-Path: <giuseppe.fioccola@huawei.com>
X-Original-To: bmwg@ietfa.amsl.com
Delivered-To: bmwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7D74AC14CE30 for <bmwg@ietfa.amsl.com>; Thu, 29 Sep 2022 08:43:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.906
X-Spam-Level:
X-Spam-Status: No, score=-6.906 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Y7f8cGbE160N for <bmwg@ietfa.amsl.com>; Thu, 29 Sep 2022 08:43:41 -0700 (PDT)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B6AA2C14CE26 for <bmwg@ietf.org>; Thu, 29 Sep 2022 08:43:40 -0700 (PDT)
Received: from fraeml715-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Mdd1Z1s28z688nt; Thu, 29 Sep 2022 23:43:30 +0800 (CST)
Received: from fraeml714-chm.china.huawei.com (10.206.15.33) by fraeml715-chm.china.huawei.com (10.206.15.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 29 Sep 2022 17:43:38 +0200
Received: from fraeml714-chm.china.huawei.com ([10.206.15.33]) by fraeml714-chm.china.huawei.com ([10.206.15.33]) with mapi id 15.01.2375.031; Thu, 29 Sep 2022 17:43:38 +0200
From: Giuseppe Fioccola <giuseppe.fioccola@huawei.com>
To: Gabor LENCSE <lencse@hit.bme.hu>, "bmwg@ietf.org" <bmwg@ietf.org>
Thread-Topic: [bmwg] Review of draft-vfv-bmwg-srv6-bench-meth-02.txt
Thread-Index: AQHY0wp7MIJP7p5aVU+Opybg731krK32iDug
Date: Thu, 29 Sep 2022 15:43:37 +0000
Message-ID: <1b3fd653e1444c7ba0d7cddb82606f2e@huawei.com>
References: <b4c8b453-2df8-790f-a8ea-c6c538384404@hit.bme.hu>
In-Reply-To: <b4c8b453-2df8-790f-a8ea-c6c538384404@hit.bme.hu>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.81.212.26]
Content-Type: multipart/alternative; boundary="_000_1b3fd653e1444c7ba0d7cddb82606f2ehuaweicom_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/bmwg/hdlap8MhWGpoRsZEQzSsmu0Rmbw>
Subject: Re: [bmwg] Review of draft-vfv-bmwg-srv6-bench-meth-02.txt
X-BeenThere: bmwg@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Benchmarking Methodology Working Group <bmwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bmwg>, <mailto:bmwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bmwg/>
List-Post: <mailto:bmwg@ietf.org>
List-Help: <mailto:bmwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bmwg>, <mailto:bmwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Sep 2022 15:43:45 -0000

Dear Gabor,
Thanks a lot for your revision.
Please find my replies inline tagged as [GF].

Regards,

Giuseppe

From: bmwg <bmwg-bounces@ietf.org> On Behalf Of Gabor LENCSE
Sent: Wednesday, September 28, 2022 9:17 AM
To: bmwg@ietf.org
Subject: [bmwg] Review of draft-vfv-bmwg-srv6-bench-meth-02.txt


Dear Authors,

At IETF 114, I promised to review your draft: https://www.ietf.org/archive/id/draft-vfv-bmwg-srv6-bench-meth-02.txt

First of all, I must admit, that I am not familiar with segment routing, I read the draft only from benchmarking point of view.

I have a few comments and suggestions.

Abstract:

   This document defines a methodology for benchmarking Segment Routing

   (SR) performance for Segment Routing over IPv6 (SRv6).  It builds

   upon [RFC2544], [RFC5180], [RFC5695] and [RFC8402].

Neither RFC4814 nor RFC8219 are mentioned here.

[GF]: We may consider to mention RFC 4814 and RFC 8219 in the draft rather than in the Abstract. The transition technologies can be mentioned but they should not influence functionality or performance of a SR node, which is our DUT.

I recommend mentioning RFC 4814, because when I was not aware of it, I used fixed UDP port numbers as defined in the Appendix C.2.6.4 of RFC 2544. And thus the DUT (actually a multi-core server running Linux) was not able to distribute the interrupts of the arriving packets among the CPU cores (that is, Receive-Side Scaling did not work).

I am not aware of the architecture of segment routing devices, but I suspect that they may have several CPU cores. So using psedorandom UDP port number can be important.

[GF]: The architecture of a router is different and has less restrictions but it is worth mentioning RFC 4814 implications since SR functionalities may be tested on a server running Linux as well.

I am aware that:

   The purpose of this document is to describe a methodology specific to

   the benchmarking of Segment Routing over IPv6.  The methodology

   described is a complement for [RFC5180] and [RFC5695].

But I believe that in some cases (e.g. Latency measurement) a better methodology can be recommended, if we consider RFC8219. (Please see later, why.)

I think that the following part may be reconsidered:

   Recommended frame sizes are the following:



   o  Ethernet Minimal: 64+8+n*16



   o  DUT Minimal Wire Speed: 128-256 (it depends on the range

      recommended in the DUT specification)



   o  Ethernet Typical: 1518+8+n*16



   o  DUT Maximum Wire Speed: 9000

In contrast, RFC 2544 recommends the following frame sizes:

9.1 Frame sizes to be used on Ethernet



       64, 128, 256, 512, 1024, 1280, 1518

RFC 8219 recommends even more:

   Based on the recommendations of [RFC5180<https://datatracker.ietf.org/doc/html/rfc5180>], the following frame sizes

   SHOULD be used for benchmarking IPvX/IPvY traffic on Ethernet links:

   64, 128, 256, 512, 768, 1024, 1280, 1518, 1522, 2048, 4096, 8192, and

   9216.

The Authors may be right that some of the above frame sizes are out of interest, but I would like to be sure that they were considered and then judged as redundant.

[GF]: We will look at RFC8219 but we already said in the document that any other frame sizes may be tested if there is an interest: “Any other frame sized may be added if suspected of abnormal behavior.  For example, some architectures may allocate buffer memory in big fixed chunks that may drop performance if frame sizes are chosen just a few octet more than the fixed chunk size (the second chunk would have a very low memory utilization).”

The following text occurs 3 times (in 3 different measurement procedures):

   Procedure: Similar to [RFC5695] with potential extension to test SID

   list longer than 1 SID (2 are recommended, many are possible).



Why "recommended" and not "RECOMMENDED"?

[GF] Yes, it should be upper case

Regarding the measurement procedures, I have two observations:

1. I believe that the latency measurement procedure could be (and should be) improved.

5.2. Latency

   Procedure: Similar to [RFC5695] with potential extension to test SID

   list longer than 1 SID (2 are recommended, many are possible).

RFC5695 reuses the Latency measurement procedure defined in Section 26.2 of RFC2544. That one uses only a simple timestamp per experiment.

However, RFC8219 has an improved procedure for latency measurements: it uses at least 500 timestamps: https://datatracker.ietf.org/doc/html/rfc8219#section-7.2

I believe that it would be worth using that improved procedure.

[GF] Indeed, it is possible to improve latency tests. We will have a look to all the related documents.

2. I have noticed that back-to-back frames is missing from among the measurement procedures.

In Section 3.1 there is such text:

[RFC9004] updates the procedures of

   the test to measure the Back-to-Back Frames since their

   characterization is relevant in software-packet processing.

But the back-to-back frames measurement procedure is missing from Section 5. If it is an accident, then I recommend it to be included. If it is intentional, then is should probably be mentioned why it was left out.

[GF] Yes, we can add tests for back-to-back frames measurement procedure. RFC9004 is the reference document for this.

6.  Security Considerations

Special capabilities SHOULD NOT exist in the DUT/SUT

   specifically for benchmarking purposes.

I believe that it is a very important statement, which should stand somewhere else, and not hidden in this section. (Perhaps most people do not read it here.)

[GF] Agree, we will revise.

Nits:

In SRv6 the --> In SRv6, the



This document is benchmarking only "source routing".

I think that it should be expressed somehow better.

[GF] Ok.

All in all: they are just my observations and recommendations. Perhaps some of them are not relevant or even incorrect. Please feel free to ignore them. :-)

Best regards,

Gábor