Re: [calsify] Review: draft-ietf-calext-ical-relations-05

Michael Douglass <mikeadouglass@gmail.com> Wed, 05 August 2020 16:22 UTC

Return-Path: <mikeadouglass@gmail.com>
X-Original-To: calsify@ietfa.amsl.com
Delivered-To: calsify@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2923C3A0C93 for <calsify@ietfa.amsl.com>; Wed, 5 Aug 2020 09:22:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.046
X-Spam-Level:
X-Spam-Status: No, score=-3.046 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, NICE_REPLY_A=-0.949, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ODMdXGKmZ9oL for <calsify@ietfa.amsl.com>; Wed, 5 Aug 2020 09:22:15 -0700 (PDT)
Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AE3593A0CC7 for <calsify@ietf.org>; Wed, 5 Aug 2020 09:22:15 -0700 (PDT)
Received: by mail-qk1-x72b.google.com with SMTP id d14so42174835qke.13 for <calsify@ietf.org>; Wed, 05 Aug 2020 09:22:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language; bh=AL3qIV/u91QnFdz5fsTPGIDM2uNw7eALmXhKnzI/OoA=; b=AMZfFWbbhrdlRUccciRqbIApxLgtt9OecKwNu5fEgSyqBAxxbZy74ECnS6MlIex8c4 vjyHwd/OmfEabbmNvO0VvAlzrOX1H6LnH35yhg3kBzR4BsR/SMqM89EC01FqrQgh1/iE gg+dqxrR0F95O4apzCAZHxneN8p4fLm56MzTS9knMUARPhEdHbAv5OWfGFMRtEPBQLu7 0Q5JmIpZ70NdEnzGUQZH+AWIElkwBDAScuKG1h4G8lK+HuGL7R3ogbYy8+fu//I7BTwj rQWA5+M1XqDYNemGXjz/ooolneoqe5GloecTtERSntrJ31dLOpAR/sockt6Fi8lLCAEm /Y3g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=AL3qIV/u91QnFdz5fsTPGIDM2uNw7eALmXhKnzI/OoA=; b=MQTgH9uk1U8vnd3GJBYfdUn7m96e2AxIUuCwHAS5NP2vbqZRCOdR6mnmheaXRsomLQ 56S3BUagsTGBa55vdDqiO9p46gMUWTQg6c0PfU0lXVNdmL5IRnHygGF4va/mgP0xJtgV r6GFNkkxtcOD7G+/M1jw5W1h2WxA3EejiWOBvzs2GdBiOCEHz34bOVm4z1+ZnaxrDdm7 XW4sbKtE/tFYQbbQ0A9pFreLVzIduPunpnGPnxxRK4JWjRExMeZY+CS3mIqN92IiEixP SH79KK3BSWkiz3yR9TGc0l/UWbIA8IWnAZsG3299ZbLY7kYmpanry+Dx6sEV7fEtEJQX RYgg==
X-Gm-Message-State: AOAM531KQZxlv32IoOFdVZZm80szJaE7pDJMMon4z5clEAhAxMj9GLU0 YV3J/JENx9MVPziHK1k5aMyUH1+p8ww=
X-Google-Smtp-Source: ABdhPJxder9ovg9qLaepjAJI+I7X5Y3720UBXvVgh1qf+K9ykzNuZBnILte2Z52Mh48Y1Xlo8l3vTQ==
X-Received: by 2002:a37:71c2:: with SMTP id m185mr4015260qkc.496.1596644534455; Wed, 05 Aug 2020 09:22:14 -0700 (PDT)
Received: from MBP-2019.nycap.rr.com (cpe-74-70-80-66.nycap.res.rr.com. [74.70.80.66]) by smtp.googlemail.com with ESMTPSA id b23sm2433830qtp.41.2020.08.05.09.22.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2020 09:22:13 -0700 (PDT)
To: Bron Gondwana <brong@fastmailteam.com>, calsify@ietf.org
References: <662a9902-ca69-4627-b9b0-e3ccecd643d1@dogfood.fastmail.com>
From: Michael Douglass <mikeadouglass@gmail.com>
Message-ID: <a1c3e44e-b646-f1a6-5e2a-9e98705e450d@gmail.com>
Date: Wed, 05 Aug 2020 12:22:13 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <662a9902-ca69-4627-b9b0-e3ccecd643d1@dogfood.fastmail.com>
Content-Type: multipart/alternative; boundary="------------00D7971B2ECCECBE8A2C24DE"
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/calsify/2YuxFFTrnzD9AKCSUD8CzteWB5s>
Subject: Re: [calsify] Review: draft-ietf-calext-ical-relations-05
X-BeenThere: calsify@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <calsify.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/calsify>, <mailto:calsify-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/calsify/>
List-Post: <mailto:calsify@ietf.org>
List-Help: <mailto:calsify-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/calsify>, <mailto:calsify-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Aug 2020 16:22:17 -0000

On 8/3/20 19:52, Bron Gondwana wrote:
> Hi Mike,
>
> Thanks for uploading the latest ical relations.  Here's a quick review 
> of a couple of tiny changes needed!
>
> And I need you to confirm that there's no IPR that you're aware of :)
I can confirm there is no IPR I'm aware of
>
> Thanks,
>
> Bron.
>
> *REVIEW:
> *
>
> *Abstract:
> *
>
> nits complains:
>
>    ** The abstract seems to contain references ([RFC5545]), which it
>       shouldn't.  Please replace those with straight textual mentions of the
>       documents in question.
>
> Please change it not to be a reference in the Abstract (it's OK to 
> have a reference in the Introduction)
>
> *1.4 Link*
>
> See [I-D.daboo-caldav-attachments]
>
> Please update this reference to be RFC8607.
>
> *7.1. Concept*
>
> There's a bug in the example:
>
>       SCONCEPT:http://example.com/event-types/sports
>       CONCEPT:http://example.com/event-types/arts/music
>       CONCEPT:http://example.com/task-types/delivery
>
> Please remove the leading 'S'!
>
> ...
>
> I think that's everything I can see :)
>
> Cheers,
>
> Bron.
>
> --
>   Bron Gondwana, CEO, Fastmail Pty Ltd
>   brong@fastmailteam.com
>
>