Re: [calsify] Benjamin Kaduk's No Objection on draft-ietf-calext-jscalendar-31: (with COMMENT)

Benjamin Kaduk <kaduk@mit.edu> Thu, 15 October 2020 04:11 UTC

Return-Path: <kaduk@mit.edu>
X-Original-To: calsify@ietfa.amsl.com
Delivered-To: calsify@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C0EEC3A1260; Wed, 14 Oct 2020 21:11:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.898
X-Spam-Level:
X-Spam-Status: No, score=-1.898 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6jGBfBT60NVQ; Wed, 14 Oct 2020 21:11:46 -0700 (PDT)
Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9B9DF3A125F; Wed, 14 Oct 2020 21:11:46 -0700 (PDT)
Received: from kduck.mit.edu ([24.16.140.251]) (authenticated bits=56) (User authenticated as kaduk@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 09F4BYCd015946 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Oct 2020 00:11:38 -0400
Date: Wed, 14 Oct 2020 21:11:34 -0700
From: Benjamin Kaduk <kaduk@mit.edu>
To: Neil Jenkins <neilj@fastmailteam.com>
Cc: draft-ietf-calext-jscalendar@ietf.org, calext-chairs@ietf.org, calsify@ietf.org, Daniel Migault <daniel.migault@ericsson.com>
Message-ID: <20201015041134.GF50845@kduck.mit.edu>
References: <160264415431.16518.1057616138324026764@ietfa.amsl.com> <c94cdbca-e24c-47eb-91c7-8d5ecb45aa19@dogfood.fastmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <c94cdbca-e24c-47eb-91c7-8d5ecb45aa19@dogfood.fastmail.com>
Archived-At: <https://mailarchive.ietf.org/arch/msg/calsify/Copec5rqFALjD3LoDF_kRCiZRcE>
Subject: Re: [calsify] Benjamin Kaduk's No Objection on draft-ietf-calext-jscalendar-31: (with COMMENT)
X-BeenThere: calsify@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <calsify.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/calsify>, <mailto:calsify-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/calsify/>
List-Post: <mailto:calsify@ietf.org>
List-Help: <mailto:calsify-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/calsify>, <mailto:calsify-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Oct 2020 04:11:48 -0000

On Thu, Oct 15, 2020 at 03:00:59PM +1100, Neil Jenkins wrote:
> Thanks for the further review, I've adopted all these suggestions.
> 
> > It looks like the change in location Id for the virtualLocation entry
> > was unintentional, since the localizations property contains a patch
> > object that still references the old Id. 
> 
> The change was intentional (because I wanted an example that wasn't a UUID to help reinforce that this is permitted), however the patch path in the localizations property should have been updated to match. I have now done this (which conveniently makes it fit on one line too). Good spot!

Ah, that's a good idea to show "not a UUID", and thanks for the consistency
fix!

-Ben