Re: [calsify] Review: draft-ietf-calext-ical-relations-05

Michael Douglass <mikeadouglass@gmail.com> Fri, 16 April 2021 02:57 UTC

Return-Path: <mikeadouglass@gmail.com>
X-Original-To: calsify@ietfa.amsl.com
Delivered-To: calsify@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F36313A1048 for <calsify@ietfa.amsl.com>; Thu, 15 Apr 2021 19:57:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5r0gHj8-ggHf for <calsify@ietfa.amsl.com>; Thu, 15 Apr 2021 19:57:03 -0700 (PDT)
Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 609BD3A1050 for <calsify@ietf.org>; Thu, 15 Apr 2021 19:57:03 -0700 (PDT)
Received: by mail-qk1-x72a.google.com with SMTP id 130so13312414qkm.4 for <calsify@ietf.org>; Thu, 15 Apr 2021 19:57:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-language; bh=EU3sNxVFvQgMbmjxj2nAtqbaCipLaKc9xsmmXZPv82Y=; b=qqEOvsMTfALtEE0c737Yuz/6epmAZHFyXpvXSatX6OTOyNVsaJr0C1yV2M1njkmMGv xu6xDb0Zk+FS+ETdjIsP9qU/jFUMgEA9/ZycmXtJ45WKtg3Jt01KJh4cJDl/O+jU97QN u5XHNxQpYDCaeqHCV/4k0+wLCvkHAO1xmhzyHTV7KfQJkycUi8kt6tUclu4woVKzdka/ rZDTMBV7bUN/yWvf/qSLJw/VwwKRNqEXkSHSeDGIZ0Nd6kUK8dHTlBNw9J2BhGEIxBqj YFYUXle1QiF9iZ3ldI0qDegUGNdDmj5ihqY6FpgHuG0bHqplf6Qvn75SyEAgxHuxjk4h Hxsw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=EU3sNxVFvQgMbmjxj2nAtqbaCipLaKc9xsmmXZPv82Y=; b=Rjp/IL7H9N6zCBFuxSYAWs1QW7iTyxf6W+nliH0e9MpdGD/wLasqADEhk8D7nFgWGc MRiKSkePpW7ctXzgun7CIAC5YBbFiV59Ko/Vzjuv8Uvi8/odpZvh0MaM6+2/k9zMcEqQ 3IEHh/dOiiRMgav9LF92gPr7w4uVRT8TU4Rt/P2QtGG48dDc8oy7WdaFZbYS9qjOY+I2 0VrxJEGuElF4E8jjOWs3xw5aqpBD5uEmaLbk5QfFmSvrHxaewWRXHJOi4QpipGrSf2gT m6RfV/ClaXN10mYgPXrgijpyBq81xSCcfwZYqVfJIzN52GSNC64se9I1EfFptTombeRX B6hQ==
X-Gm-Message-State: AOAM530mqQbBXhi9RxjnSYD5PU7umF8Y203eZresCqoSDm1tMjKjXREw 4HghrGD6hVu31YdCEmrL9d6nDri8sys=
X-Google-Smtp-Source: ABdhPJxvZImCsjg04A38pL4YsTNAsoBuSkjrFXc8CDHxwD23dy1LKDac+O5rBxPVc55JkjIH9KPhfw==
X-Received: by 2002:a05:620a:806:: with SMTP id s6mr6797866qks.57.1618541821514; Thu, 15 Apr 2021 19:57:01 -0700 (PDT)
Received: from MacBook-Pro-2019.local (cpe-74-70-70-237.nycap.res.rr.com. [74.70.70.237]) by smtp.googlemail.com with ESMTPSA id k26sm3411787qkg.120.2021.04.15.19.57.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Apr 2021 19:57:00 -0700 (PDT)
From: Michael Douglass <mikeadouglass@gmail.com>
To: Bron Gondwana <brong@fastmailteam.com>, calsify@ietf.org
References: <662a9902-ca69-4627-b9b0-e3ccecd643d1@dogfood.fastmail.com> <8f4213c9-3348-0c58-7322-2039b1e93b9c@gmail.com>
Message-ID: <b3aa935c-8f31-057e-0db8-d4a4d181e1ab@gmail.com>
Date: Thu, 15 Apr 2021 22:56:59 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.1
MIME-Version: 1.0
In-Reply-To: <8f4213c9-3348-0c58-7322-2039b1e93b9c@gmail.com>
Content-Type: multipart/alternative; boundary="------------5B33618B2FF24489D84EAF32"
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/calsify/D87xcqm0JeWkVh2Btzp5c2l0ZWs>
Subject: Re: [calsify] Review: draft-ietf-calext-ical-relations-05
X-BeenThere: calsify@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <calsify.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/calsify>, <mailto:calsify-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/calsify/>
List-Post: <mailto:calsify@ietf.org>
List-Help: <mailto:calsify-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/calsify>, <mailto:calsify-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Apr 2021 02:57:08 -0000

On 4/15/21 22:47, Michael Douglass wrote:
>
> Looking through the spec and messages i realized I'd missed a couple 
> of these. All are now dealt with.
>
> You also asked if I'd checked for alignment with jscalendar.
>
> There is in fact a misalignment. jscalendar defines the relation type 
> "first" for which there is no equivalent in iCalendar. I have added 
> that to the version 7 I'm working on.
>
> jscalendar does not define "sibling" but does define "next". The text 
> in the icalendar-jscalendar mapping document suggests these are the 
> closest match. We could strengthen that language and state that 
> "SIBLING" and "next" are equivalent.
>
> There is a slight semantic difference - next seems to imply that some 
> order matters while sibling doesn't.
>
> I could add "NEXT" to the relations draft but then we have to deal 
> with "SIBLING".
>
> I prefer strengthening the language.
>
And as I add the text I feel a little uneasy about that.

"first" and "next" go together to provide an ordered list of components.

"sibling" might be appropriate for more of a tree structure

> On 8/3/20 19:52, Bron Gondwana wrote:
>> Hi Mike,
>>
>> Thanks for uploading the latest ical relations.  Here's a quick 
>> review of a couple of tiny changes needed!
>>
>> And I need you to confirm that there's no IPR that you're aware of :)
>>
>> Thanks,
>>
>> Bron.
>>
>> *REVIEW:
>> *
>>
>> *Abstract:
>> *
>>
>> nits complains:
>>
>>    ** The abstract seems to contain references ([RFC5545]), which it
>>       shouldn't.  Please replace those with straight textual mentions of the
>>       documents in question.
>>
>> Please change it not to be a reference in the Abstract (it's OK to 
>> have a reference in the Introduction)
>>
>> *1.4 Link*
>>
>> See [I-D.daboo-caldav-attachments]
>>
>> Please update this reference to be RFC8607.
>>
>> *7.1. Concept*
>>
>> There's a bug in the example:
>>
>>       SCONCEPT:http://example.com/event-types/sports  <http://example.com/event-types/sports>
>>       CONCEPT:http://example.com/event-types/arts/music  <http://example.com/event-types/arts/music>
>>       CONCEPT:http://example.com/task-types/delivery  <http://example.com/task-types/delivery>
>>
>> Please remove the leading 'S'!
>>
>> ...
>>
>> I think that's everything I can see :)
>>
>> Cheers,
>>
>> Bron.
>>
>> --
>>   Bron Gondwana, CEO, Fastmail Pty Ltd
>> brong@fastmailteam.com
>>
>>