Re: [calsify] AD review of draft-ietf-calext-eventpub-extensions-10
Alexey Melnikov <alexey.melnikov@isode.com> Wed, 03 April 2019 10:33 UTC
Return-Path: <alexey.melnikov@isode.com>
X-Original-To: calsify@ietfa.amsl.com
Delivered-To: calsify@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A8E131200B9 for <calsify@ietfa.amsl.com>; Wed, 3 Apr 2019 03:33:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=isode.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id C7ujuSToqVR5 for <calsify@ietfa.amsl.com>; Wed, 3 Apr 2019 03:33:04 -0700 (PDT)
Received: from statler.isode.com (Statler.isode.com [62.232.206.189]) by ietfa.amsl.com (Postfix) with ESMTP id A5D211200B7 for <calsify@ietf.org>; Wed, 3 Apr 2019 03:33:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1554287582; d=isode.com; s=june2016; i=@isode.com; bh=oILFyG7IipQefHZZYPswR8kYya5p9GuvWXOklPOkerg=; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version: In-Reply-To:References:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description; b=ir53st17sPQ8EKul0X+c7gHtO5lPMPI9V6sVMoR9P6aRbMMRmNd8nNWn0QRcey9lfj288+ yERcEnGWpKgUZPb9HV+kGvouWrPU4yHTc5NasTVEcIh/VTGxddCZ4z+FLCNIxVkKflUJls lQajS9YtFo9d41wrBIL9TH5LOn7p4So=;
Received: from [172.20.1.215] (dhcp-215.isode.net [172.20.1.215]) by statler.isode.com (submission channel) via TCP with ESMTPSA id <XKSL3gBUXmpC@statler.isode.com>; Wed, 3 Apr 2019 11:33:02 +0100
To: Michael Douglass <mikeadouglass@gmail.com>
Cc: calsify@ietf.org
References: <009b5762-3b36-61c7-86a4-716391b6ed43@isode.com> <7446205e-303e-74e5-d375-30b210f6eb39@gmail.com>
From: Alexey Melnikov <alexey.melnikov@isode.com>
Message-ID: <ef8a44b2-db9d-074f-5dab-aa2ce7aefada@isode.com>
Date: Wed, 03 Apr 2019 11:32:46 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0
In-Reply-To: <7446205e-303e-74e5-d375-30b210f6eb39@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="------------72BCFCE9A50FB3D482B339D7"
Content-Language: en-GB
Archived-At: <https://mailarchive.ietf.org/arch/msg/calsify/wHJEvLixuJEnss_YpROfAXlDy4o>
Subject: Re: [calsify] AD review of draft-ietf-calext-eventpub-extensions-10
X-BeenThere: calsify@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <calsify.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/calsify>, <mailto:calsify-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/calsify/>
List-Post: <mailto:calsify@ietf.org>
List-Help: <mailto:calsify-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/calsify>, <mailto:calsify-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Apr 2019 10:33:09 -0000
Hi Michael, Some specific comments above. Please post -12 at your earliest convenience so that I can progress the document. On 29/03/2019 04:49, Michael Douglass wrote: > > Hi Alexey- sorry I missed this. Some questions and comments below: > > On 10/29/18 08:37, Alexey Melnikov wrote: >> Hi, >> >> I've done my review of the document. Other people found some of the >> same issues, so you might have already fixed some of them. >> Also note that I might ask for an extra review from people more >> familiar with use of geo-location in IETF protocols. >> >> In Section 3: XML and JSON need Informative References. > > The text I have is > > these extensions as a component rather than a property. This is a > better match for the way XML and JSON handles such structures and > allows richer definitions. > > This is just a reference to the hierarchical nature of XML and JSON > rather than any particular data representation. What should I be > referencing? > RFC 8259 for JSON, <https://www.w3.org/TR/2008/REC-xml-20081126/> for XML > >> >> In 7.3: >> Due to use of RFC 2119 "SHOULD": "text/html" needs an Normative >> Reference, most likely to HTML5. > > I have: > > resource is not given by the "FMTTYPE" parameter. If the media > type remains unknown, calendar applications SHOULD treat it as > type "text/html". This still mean that there is a need for a normative reference. Use the W3C document. >> In 7.6: >> Property Name: STRUCTURED-DATA >> >> Purpose: This property specifies ancillary data associated with the >> calendar component. >> >> This is rather vague and I think this has implications for Security >> Considerations (so you should mention something there), because >> anything can be stuffed here, including executable content. >> >> Value Type: TEXT, BINARY or URI >> >> But the ABNF: >> >> sdataprop = "STRUCTURED-DATA" sdataparam >> (":" text) / >> ( >> ";" "ENCODING" "=" "BASE64" >> ";" "VALUE" "=" "BINARY" >> ":" binary >> ) / >> ( >> ";" "VALUE" "=" "URI" >> ":" uri >> ) >> CRLF >> >> doesn't include TEXT "value" choice I think I missed "text" above, so this is a non issue. >> >> 8.1. Participant >> >> Component name: PARTICIPANT >> >> Purpose: This component provides information about a participant in >> an event or optionally a plain text typed value. >> >> What does "or optionally a plain text typed value" mean here? This is >> a component, not a single property. > > Yes - hangover from earlier. Changed to > > This component provides information about a participant > in an event or task. > >> Format Definition: >> >> This property is defined by the following notation: >> >> participantc = "BEGIN" ":" "PARTICIPANT" CRLF >> partprop *alarmc >> "END" ":" "PARTICIPANT" CRLF >> >> Is inclusion of "alarmc" intentional? (If it is, that is fine. I just >> think I check.) > That I can't remember - it has the flavor of per-user properties. > However I can remove it. I don't mind, but if it remains you need to add an explanation. >> >> Example: >> >> The following is an example of this component. It contains a SOURCE >> property which points to a VCARD providing information about the >> event participant. >> >> BEGIN:PARTICIPANT >> PARTICIPANT-TYPE:PRINCIPAL_PERFORMER >> >> PRINCIPAL_PERFORMER is not defined as a valid value for >> PARTICIPANT-TYPE. >> >> SOURCE:http://dir.example.com/vcard/aviolinist.vcf >> END:PARTICIPANT >> >> >> The following is an example for the primary contact. >> >> BEGIN: PARTICIPANT >> SOURCE;FMTTYPE=text/vcard; >> http://dir.example.com/vcard/contacts/contact1.vcf >> PARTICIPANT-TYPE:PRIMARY-CONTACT >> >> PRIMARY-CONTACT is not defined either. >> >> DESCRIPTION:A contact: >> END:PARTICIPANT > Changed to PERFORMER and CONTACT >> >> >> >> In Section 9.1: >> >> STRUCTURED-LOCATION;LABEL="The venue": >> http://dir.example.com/venues/big-hall.vcf >> STRUCTURED-LOCATION;LABEL="The venue": >> http://dir.example.com/venues/parking.vcf >> >> Should different instances have different LABEL values? > Done in v-11 >> >> >> >> 11. Privacy Considerations >> >> I think this section needs to talk about unintended exposure of Geo >> location. >> > Could you elaborate - are we talking about geo location of participants? > Yes.. > > That's beginning to sound like an update to 5546 > Understanding of privacy concerns has evolved since RFC 5546 was published. You just need to mention possible issues here. I am quite certain that you will get a blocking DISCUSS comment during IESG review if you don't. >> 12.2. New Registration Tables >> >> This section defines new registration tables for PARTICIPANT-TYPE and >> RESTYPE values. These tables may be updated using the same >> approaches laid down in Section 8.2.1 of [RFC5545] >> >> Section 8.2.1 of [RFC5545] implies that IANA registration procedure >> is "Expert Review" >> or "Specification Required" (which implies "Expert Review"). Please >> clarify this for IANA here. > > And it looks like that section has an error. It states... > > designated expert and published in an RFC. A Standards Track RFC is > REQUIRED for the registration of new value data types that modify > existing properties, as well as for the registration of participation > status values to be used in "VEVENT" calendar components. > > partstat is used for tasks so it should really have been less specific. > > Returning to your comment... > > I duplicated the approach taken in e.g. > https://tools.ietf.org/html/rfc6638 so I think that the text ought to > be fine. However - I have to admit I hadn't fully absorbed the > implications so I do need to send emails to the specified lists > If the procedure is clear for IANA, then it is fine with me.
- [calsify] AD review of draft-ietf-calext-eventpub… Alexey Melnikov
- Re: [calsify] AD review of draft-ietf-calext-even… Michael Douglass
- Re: [calsify] AD review of draft-ietf-calext-even… Michael Douglass
- Re: [calsify] AD review of draft-ietf-calext-even… Alexey Melnikov