Re: [calsify] Review: draft-ietf-calext-ical-relations-05

Michael Douglass <mikeadouglass@gmail.com> Fri, 16 April 2021 02:47 UTC

Return-Path: <mikeadouglass@gmail.com>
X-Original-To: calsify@ietfa.amsl.com
Delivered-To: calsify@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D63FB3A0FE7 for <calsify@ietfa.amsl.com>; Thu, 15 Apr 2021 19:47:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VzL4kDzuCWwU for <calsify@ietfa.amsl.com>; Thu, 15 Apr 2021 19:47:09 -0700 (PDT)
Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5280C3A0FE5 for <calsify@ietf.org>; Thu, 15 Apr 2021 19:47:09 -0700 (PDT)
Received: by mail-qk1-x72d.google.com with SMTP id d23so15449294qko.12 for <calsify@ietf.org>; Thu, 15 Apr 2021 19:47:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language; bh=9HgxBvai/Okxg8asXuKfUV/VJAoFyfEHUKZXLWksggI=; b=r4NOWwwII3d9cCeTQ7dL/XHnkmS1s4G4Te7Teh4oZCbZzUrpiFwobQb+9GzRhPwcZe VyK6PX5hnk6TmqzpVJqSiWJb0wOcOc2ZpdfX43412di+msHSozqk/bBucqTbCfSbSyyQ fspZ+55s5xn8BLy1iiAcUHzgvWyYdNeawhTW1ZLuR+PEnCYE13oUGQ5D3llXbojloRP5 OIvvYlbgZeDS7OeE3EBjx6k7Ag4xQnMkLZSPoAOQeId4tyJZ3/QbwjCluaMWlYizkDEw ju8go1Ql0loNyx0mA27zgFZgaOt0Lut199iHzH6Ef3tX2vv57I1ZsJ8BGKJa1ZOAO7fg ahrg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=9HgxBvai/Okxg8asXuKfUV/VJAoFyfEHUKZXLWksggI=; b=L1TAJ+H9SpeSu1H0iX14KoYRo8WA9Iz7zDHL/L+eCptsWT4HimXSX8IYpUP8cdXz09 ZJcLc27Qvn149Yc0/1H/mXXUhGX9JkX64A+0ZfVPSc+WbwO6x/e5kS9gTMT1UZC+d7nt TsPfDMJnVuQyzAzGgeKsqAEbn7Vcnas+wxlQ7VRdVgH5/42M7++eZ8zAZk1l5+GB2yjR DQnjcNOvap5cRplMj7gm4fVyKhQbYF37Zf3/nX9zchJURNSC6jBIR+PrZoF/0L7h2b8m Z2Q0KWccclAetunrp0LlV3QO5sgfi1dZl6zDJdHG46WljU1a/NtcY1SXKOUS6R5rt1Ly j8Ow==
X-Gm-Message-State: AOAM533zskRRfncVUhRTon5OvcmyQsZUU9QmbnjWFbs/QyD1DUz5WSe5 dSqlhudk+C5mMarBi9yJ4z6MjRLeics=
X-Google-Smtp-Source: ABdhPJxoU98mdkr1hh95RaFGrsPMCt0Z9pIgVcBOTUI5tFEvdAaWE2KSSJjEnjq7LIy4E9R9hejHNQ==
X-Received: by 2002:ae9:f70d:: with SMTP id s13mr6567931qkg.346.1618541227448; Thu, 15 Apr 2021 19:47:07 -0700 (PDT)
Received: from MacBook-Pro-2019.local (cpe-74-70-70-237.nycap.res.rr.com. [74.70.70.237]) by smtp.googlemail.com with ESMTPSA id a4sm2985645qta.19.2021.04.15.19.47.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Apr 2021 19:47:06 -0700 (PDT)
To: Bron Gondwana <brong@fastmailteam.com>, calsify@ietf.org
References: <662a9902-ca69-4627-b9b0-e3ccecd643d1@dogfood.fastmail.com>
From: Michael Douglass <mikeadouglass@gmail.com>
Message-ID: <8f4213c9-3348-0c58-7322-2039b1e93b9c@gmail.com>
Date: Thu, 15 Apr 2021 22:47:05 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.1
MIME-Version: 1.0
In-Reply-To: <662a9902-ca69-4627-b9b0-e3ccecd643d1@dogfood.fastmail.com>
Content-Type: multipart/alternative; boundary="------------BC1937555A9E45BEBE616FDC"
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/calsify/ycYP5cuM_Bk5vQcBbi6B5DfEaCU>
Subject: Re: [calsify] Review: draft-ietf-calext-ical-relations-05
X-BeenThere: calsify@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <calsify.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/calsify>, <mailto:calsify-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/calsify/>
List-Post: <mailto:calsify@ietf.org>
List-Help: <mailto:calsify-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/calsify>, <mailto:calsify-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Apr 2021 02:47:14 -0000

Looking through the spec and messages i realized I'd missed a couple of 
these. All are now dealt with.

You also asked if I'd checked for alignment with jscalendar.

There is in fact a misalignment. jscalendar defines the relation type 
"first" for which there is no equivalent in iCalendar. I have added that 
to the version 7 I'm working on.

jscalendar does not define "sibling" but does define "next". The text in 
the icalendar-jscalendar mapping document suggests these are the closest 
match. We could strengthen that language and state that "SIBLING" and 
"next" are equivalent.

There is a slight semantic difference - next seems to imply that some 
order matters while sibling doesn't.

I could add "NEXT" to the relations draft but then we have to deal with 
"SIBLING".

I prefer strengthening the language.

On 8/3/20 19:52, Bron Gondwana wrote:
> Hi Mike,
>
> Thanks for uploading the latest ical relations.  Here's a quick review 
> of a couple of tiny changes needed!
>
> And I need you to confirm that there's no IPR that you're aware of :)
>
> Thanks,
>
> Bron.
>
> *REVIEW:
> *
>
> *Abstract:
> *
>
> nits complains:
>
>    ** The abstract seems to contain references ([RFC5545]), which it
>       shouldn't.  Please replace those with straight textual mentions of the
>       documents in question.
>
> Please change it not to be a reference in the Abstract (it's OK to 
> have a reference in the Introduction)
>
> *1.4 Link*
>
> See [I-D.daboo-caldav-attachments]
>
> Please update this reference to be RFC8607.
>
> *7.1. Concept*
>
> There's a bug in the example:
>
>       SCONCEPT:http://example.com/event-types/sports  <http://example.com/event-types/sports>
>       CONCEPT:http://example.com/event-types/arts/music  <http://example.com/event-types/arts/music>
>       CONCEPT:http://example.com/task-types/delivery  <http://example.com/task-types/delivery>
>
> Please remove the leading 'S'!
>
> ...
>
> I think that's everything I can see :)
>
> Cheers,
>
> Bron.
>
> --
>   Bron Gondwana, CEO, Fastmail Pty Ltd
>   brong@fastmailteam.com
>
>