Re: [Captive-portals] Murray Kucherawy's No Objection on draft-ietf-capport-api-07: (with COMMENT)

Tommy Pauly <tpauly@apple.com> Mon, 08 June 2020 16:00 UTC

Return-Path: <tpauly@apple.com>
X-Original-To: captive-portals@ietfa.amsl.com
Delivered-To: captive-portals@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D2B2D3A0D4B; Mon, 8 Jun 2020 09:00:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=apple.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id upyLpkRs7N2t; Mon, 8 Jun 2020 09:00:54 -0700 (PDT)
Received: from ma1-aaemail-dr-lapp02.apple.com (ma1-aaemail-dr-lapp02.apple.com [17.171.2.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C3FF63A0D2D; Mon, 8 Jun 2020 09:00:46 -0700 (PDT)
Received: from pps.filterd (ma1-aaemail-dr-lapp02.apple.com [127.0.0.1]) by ma1-aaemail-dr-lapp02.apple.com (8.16.0.42/8.16.0.42) with SMTP id 058FjFON028214; Mon, 8 Jun 2020 09:00:45 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apple.com; h=from : message-id : content-type : mime-version : subject : date : in-reply-to : cc : to : references; s=20180706; bh=YSRXRs/qITQGdQQ9I/pROCQdJMAJbprgsFaiJmBd7Ec=; b=dLAKOMpesMa6Hm1KbrKAbgeEfl5BPKu68Er1q3V11uLYodRhoCH5xOwin9O9qWQPlh87 hGys612jTq2mQdVIFmMcxN+v61DbA1405nWUhBVnOpaX8MgiZwjW5CCvEOi6PVtlDSeg EfKMRelPosgTKQ3tL8pXwTGgFCYBGIpc2+hJjjRP9VVC6CasZAVaWIpKnDZY77VkILKb M0jy0LIVPKAALVqVXw3dMmDno8KE2brY0x+7BfjG2UzXn/k/Jo0YewxKfSBP0umCp5ho TMHqew3rwWPPiYGEFa8KFpoVv8W5d7lGowXHyl8cPiKuehrhCt6Dh/tvA0Ld5RwLaA/f uw==
Received: from rn-mailsvcp-mta-lapp02.rno.apple.com (rn-mailsvcp-mta-lapp02.rno.apple.com [10.225.203.150]) by ma1-aaemail-dr-lapp02.apple.com with ESMTP id 31g7tr85x6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Mon, 08 Jun 2020 09:00:44 -0700
Received: from rn-mailsvcp-mmp-lapp04.rno.apple.com (rn-mailsvcp-mmp-lapp04.rno.apple.com [17.179.253.17]) by rn-mailsvcp-mta-lapp02.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) with ESMTPS id <0QBM00MKR758MI80@rn-mailsvcp-mta-lapp02.rno.apple.com>; Mon, 08 Jun 2020 09:00:44 -0700 (PDT)
Received: from process_milters-daemon.rn-mailsvcp-mmp-lapp04.rno.apple.com by rn-mailsvcp-mmp-lapp04.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) id <0QBM00F0073TBR00@rn-mailsvcp-mmp-lapp04.rno.apple.com>; Mon, 08 Jun 2020 09:00:44 -0700 (PDT)
X-Va-A:
X-Va-T-CD: 173914e0cf39131f94a57ecc1dc8517a
X-Va-E-CD: 94ca97156a760fa13881a73234338672
X-Va-R-CD: cb2ecf5fb2f846674d11e9b29a5041d7
X-Va-CD: 0
X-Va-ID: 44886540-8c1f-468e-8a27-23042858c018
X-V-A:
X-V-T-CD: 173914e0cf39131f94a57ecc1dc8517a
X-V-E-CD: 94ca97156a760fa13881a73234338672
X-V-R-CD: cb2ecf5fb2f846674d11e9b29a5041d7
X-V-CD: 0
X-V-ID: c76c984f-4f35-4979-a556-3f7b8280593b
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.687 definitions=2020-06-08_14:2020-06-08, 2020-06-08 signatures=0
Received: from [17.234.11.84] (unknown [17.234.11.84]) by rn-mailsvcp-mmp-lapp04.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) with ESMTPSA id <0QBM00NL57559X00@rn-mailsvcp-mmp-lapp04.rno.apple.com>; Mon, 08 Jun 2020 09:00:42 -0700 (PDT)
From: Tommy Pauly <tpauly@apple.com>
Message-id: <C7C35353-958E-4B26-B0CC-F2D1E74590D1@apple.com>
Content-type: multipart/alternative; boundary="Apple-Mail=_80768EED-5611-4221-A898-8B8322840CF5"
MIME-version: 1.0 (Mac OS X Mail 13.0 \(3645.0.2\))
Date: Mon, 08 Jun 2020 09:00:41 -0700
In-reply-to: <158935592800.11908.8097028514475804106@ietfa.amsl.com>
Cc: The IESG <iesg@ietf.org>, draft-ietf-capport-api@ietf.org, capport-chairs@ietf.org, captive-portals@ietf.org, Martin Thomson <mt@lowentropy.net>
To: Murray Kucherawy <superuser@gmail.com>
References: <158935592800.11908.8097028514475804106@ietfa.amsl.com>
X-Mailer: Apple Mail (2.3645.0.2)
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.687 definitions=2020-06-08_14:2020-06-08, 2020-06-08 signatures=0
Archived-At: <https://mailarchive.ietf.org/arch/msg/captive-portals/bKRe9jzRmTyKraEDrCBW29wQmS0>
Subject: Re: [Captive-portals] Murray Kucherawy's No Objection on draft-ietf-capport-api-07: (with COMMENT)
X-BeenThere: captive-portals@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion of issues related to captive portals <captive-portals.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/captive-portals>, <mailto:captive-portals-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/captive-portals/>
List-Post: <mailto:captive-portals@ietf.org>
List-Help: <mailto:captive-portals-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/captive-portals>, <mailto:captive-portals-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Jun 2020 16:00:58 -0000

Hi Murray,

Thanks for the review! Some comments inline.

> On May 13, 2020, at 12:45 AM, Murray Kucherawy via Datatracker <noreply@ietf.org> wrote:
> 
> Murray Kucherawy has entered the following ballot position for
> draft-ietf-capport-api-07: No Objection
> 
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
> 
> 
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about IESG DISCUSS and COMMENT positions.
> 
> 
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-capport-api/
> 
> 
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> Nice work.
> 
> A couple of points on the IANA registrations:
> 
> Section 8.1: The "Interoperability Considerations" text isn't quite what I
> think is anticipated by RFC 6838.  Given what you're saying there against what
> Section 6.2 of that document says, I think you could just have "None" here, but
> either way I suggest it's worth a second look.

This is boilerplate text that we lifted from other RFCs with similar forms (RFC 8460, RFC 8427). I’m fine with this being “None” as well, if that’s the general guidance.
> 
> Section 8.2: I suggest either having a column dedicated to recording the
> specification (since the Designated Expert is supposed to ensure there is one),
> or explicitly encourage that it be referenced in the Description column.

That's a great point. I’ve added this to our working copy in GitHub:

https://github.com/capport-wg/api/commit/67fe784f0cb2883367a46da740378338ecf84805 <https://github.com/capport-wg/api/commit/67fe784f0cb2883367a46da740378338ecf84805>

Thanks,
Tommy
> 
> 
>