Re: [Captive-portals] Murray Kucherawy's No Objection on draft-ietf-capport-architecture-08: (with COMMENT)

Kyle Larose <kyle@agilicus.com> Mon, 08 June 2020 12:33 UTC

Return-Path: <kyle@agilicus.com>
X-Original-To: captive-portals@ietfa.amsl.com
Delivered-To: captive-portals@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 808F53A0A35 for <captive-portals@ietfa.amsl.com>; Mon, 8 Jun 2020 05:33:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=agilicus.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LQx4tNfVjSbM for <captive-portals@ietfa.amsl.com>; Mon, 8 Jun 2020 05:33:48 -0700 (PDT)
Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E06323A0A3B for <captive-portals@ietf.org>; Mon, 8 Jun 2020 05:33:47 -0700 (PDT)
Received: by mail-io1-xd2d.google.com with SMTP id r2so18405509ioo.4 for <captive-portals@ietf.org>; Mon, 08 Jun 2020 05:33:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agilicus.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=464qkFEpsmapmKRTugE6v7G09N5+4HFRx4HMR53TTEQ=; b=DjkxR1z9YsgeZqj17pLXEqsiyDtNWd8L9aENiO7hF+IJ2tL4iKm+uFA53OsAHN38r9 G5K0UsHgAP50LRnzrjCoYFdTPqdgqQ5ALxkcz/ChHM3l0TOdQgxArfucMViONzZ2nErJ qUe9JfcbdbQv2qKFRfNGKxppY3hBmYJDDRZCUMjwvZrzyeSq6203o+xpoDp9AjQlwBSv E1x5JmWn4CYB9p6OxZQHZMRLJNFw3w5Ds0uyBZj6mQsAaPjNhAQfTgBrqO82IP55DY/c Ptl69Jzgwv/cOrihiLerqGsZUfKtF8XIrPTARpLZSKLfubBp8BZg/paRKlQrSK2eFUHL F1vA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=464qkFEpsmapmKRTugE6v7G09N5+4HFRx4HMR53TTEQ=; b=Ud09rhfOqu85xKvnqRzE8PJ5nwyfMmotNebrB/sPTP2T/GFfk2AocIyjwtwVyUBOY+ GGldDtCy+4aCCsSulKJ68elfJcH58z8+Qld7EX4xVucomdF5pIqXe7UmaB0oPnncLL2I K2EiInvB7SnJJpvpDNh6cZT7yDaKu/61NfPQz2VhEw6lzkdqTu0AMEyMcDG106fmEVyP ZBddYv2YfAlC2nPoL0dHflCuAa7OoDEBf2//QDJUJjs5xLIiiBYhvSAUgvqP4wI+DQB1 MDsLRYQMuDwkKq4W5HfPy4IQ9eNGKBCAihdDR3UVd/XuL1AiAQOb0TKL+++P+2VMI0sl 4p0g==
X-Gm-Message-State: AOAM5303Ct/zwwRWqoiLZAkMrKMe1ZYA116ZatWCGbM4vZpe1L89OtgJ pP+V/aW2D78HzWiN/BPJXNulclUr7x1w9pZ4pgJW
X-Google-Smtp-Source: ABdhPJzUtMrQH3oVQxnqHJZCwbO2CuJRA/uGLGWcwx5z3re1jiVg+54ckyn6B3l5H6SAweMpCPgYDbPWc73Sbxv1rNM=
X-Received: by 2002:a5e:c112:: with SMTP id v18mr21993845iol.37.1591619625838; Mon, 08 Jun 2020 05:33:45 -0700 (PDT)
MIME-Version: 1.0
References: <159150240125.28029.2671447454436388985@ietfa.amsl.com>
In-Reply-To: <159150240125.28029.2671447454436388985@ietfa.amsl.com>
From: Kyle Larose <kyle@agilicus.com>
Date: Mon, 8 Jun 2020 08:33:35 -0400
Message-ID: <CACuvLgxsZvXM1U1Ye_8Y-0sxFMFFAHSk8jEdOEfzpXTjkYs5NA@mail.gmail.com>
To: Murray Kucherawy <superuser@gmail.com>
Cc: The IESG <iesg@ietf.org>, draft-ietf-capport-architecture@ietf.org, capport-chairs@ietf.org, captive-portals <captive-portals@ietf.org>, Martin Thomson <mt@lowentropy.net>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/captive-portals/xmYAnND5ETtOLnfWXZargkCaydo>
Subject: Re: [Captive-portals] Murray Kucherawy's No Objection on draft-ietf-capport-architecture-08: (with COMMENT)
X-BeenThere: captive-portals@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion of issues related to captive portals <captive-portals.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/captive-portals>, <mailto:captive-portals-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/captive-portals/>
List-Post: <mailto:captive-portals@ietf.org>
List-Help: <mailto:captive-portals-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/captive-portals>, <mailto:captive-portals-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Jun 2020 12:33:51 -0000

Hi Murray,

Thanks for the review!

Responses inline.

On Sun, 7 Jun 2020 at 00:00, Murray Kucherawy via Datatracker
<noreply@ietf.org> wrote:
>
> Murray Kucherawy has entered the following ballot position for
> draft-ietf-capport-architecture-08: No Objection
>
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
>
> Pretty straightforward.  Looking forward to the API document.
>
> Some nits:
>
> Although I see why you did it, the capitalization of the bullet list in Section
> 3.2 appears peculiar.
>

You're correct. I think the latter three bullets break the
construction anyway, since they don't directly match the titles of the
sections. We'll fix this up.

> Also curious is that "User Equipment" is defined in Section 2.1, but not
> shortened to "UE" anywhere other than in Section 3.5.
>

We should be consistent throughout the document. If it aids
readability, I have no problem changing it to UE. Do you think that
would help?

> In Section 4.1, what's an "RA"?
>
>

Router Advertisement (rfc4861). This section is discussing workflows
related to https://tools.ietf.org/html/draft-ietf-capport-rfc7710bis-02,
which describes how router advertisements would be used in more
detail.

I suppose using the full term here would help clarify, though there is
also an opportunity to reference rfc4861 -- I'm not sure whether
that's necessary, since presumably someone seeking further
clarification would read rfc7710bis, which references rfc4861. I'm
happy to add the reference if you think it's necessary.

Thanks!

Kyle