Re: [Captive-portals] Alvaro Retana's No Objection on draft-ietf-capport-architecture-08: (with COMMENT)

Kyle Larose <kyle@agilicus.com> Sat, 13 June 2020 12:52 UTC

Return-Path: <kyle@agilicus.com>
X-Original-To: captive-portals@ietfa.amsl.com
Delivered-To: captive-portals@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 534383A08A5 for <captive-portals@ietfa.amsl.com>; Sat, 13 Jun 2020 05:52:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=agilicus.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 07Gz6W11u7uF for <captive-portals@ietfa.amsl.com>; Sat, 13 Jun 2020 05:52:40 -0700 (PDT)
Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 440803A08AC for <captive-portals@ietf.org>; Sat, 13 Jun 2020 05:52:40 -0700 (PDT)
Received: by mail-io1-xd34.google.com with SMTP id m81so13128423ioa.1 for <captive-portals@ietf.org>; Sat, 13 Jun 2020 05:52:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agilicus.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=86uJMvCRdOGrvyOiZi2VvO7+Nnj+x8Fs5ouwA/Cz94g=; b=gS18ib4NThfVluSfu16YzU14G/E7KEDrZeHummboqwwqt8h56PUXl29bm/A14Lq7NZ wBsiBCRiaxY7gTW/gZfL1vkrB1c9no2TxCMtBFiAzJiC4zXoulluJor0HFHJu2t3mCAE IdU6aA/+S753INxscgvdCokxU3U3VnWE5+cQwrAOP0k1MVD5KN9XD2MTVN6hT+9DAvrB q/PuLwhzBK8av5cL8mO2Q7ebNjv1twGWVMMOQtHz2v1uNllyBs0sVfalYo00Axzfqe9s eYauq8A69S+JeOMlsEjZeUQ4RJkhVBzp6+Z1/XNwzuuxnm7iq6oG2VJGnHN6Jw15SMwA JXLg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=86uJMvCRdOGrvyOiZi2VvO7+Nnj+x8Fs5ouwA/Cz94g=; b=Obwt8XoymUxMFq9tgEHNKLDp+L6YA7Hh0JcXcMnmQiwpQe6hBQ9jnXq/ykJahwuztM pFpX7pb8sEI8mUf6EiF64p0nqbxc9gnCsH23bejFUoe2rDKVZMheQFt4/bJy4N9iFU8z +1pyCwfoQPjBWggChGmgZAvxXb71F+WJv7b1k/nA1+V+Vx5xtkcSKoW3iDo7YG9oMme3 T+NgETRjLq8g7HDR2ek04GDSzBIjaOEVDvjeXraszHf86q5yTs9sDjCnLlYamL9jD+N2 rF0Ckezq+mTZaeS4X0XvIHgY6Zrig5mTWRxBHq8BtnD42NNRGhHm/JZ23Rtm7kP+1vH1 s8yg==
X-Gm-Message-State: AOAM532kbMfPCgP61R97ZMdCp9VvwTzNCsjtbbtn5l6L7cHj2LHAfMp3 nzZYmGynKQJ+6UGOoym9PRCtD79PUnhvwMlv0IZD
X-Google-Smtp-Source: ABdhPJwkk/nvsX6Jeztv9JWcEv78TJQwwduoPl9SKJXTzSYMIjUPZjQ9kimx7fkae/Agp1QqdLax+UiHLPWrGno4Ygw=
X-Received: by 2002:a02:ac0a:: with SMTP id a10mr12557717jao.97.1592052759078; Sat, 13 Jun 2020 05:52:39 -0700 (PDT)
MIME-Version: 1.0
References: <159173380909.20537.14158593585230375343@ietfa.amsl.com>
In-Reply-To: <159173380909.20537.14158593585230375343@ietfa.amsl.com>
From: Kyle Larose <kyle@agilicus.com>
Date: Sat, 13 Jun 2020 08:52:28 -0400
Message-ID: <CACuvLgwQRv98rGHTiozSr6KFy14OJ51MOhwZuHb8BfMO-YYDug@mail.gmail.com>
To: Alvaro Retana <aretana.ietf@gmail.com>
Cc: The IESG <iesg@ietf.org>, draft-ietf-capport-architecture@ietf.org, capport-chairs@ietf.org, captive-portals <captive-portals@ietf.org>, Martin Thomson <mt@lowentropy.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/captive-portals/zJRHXLWtQF4ooUoDygxrWNvRV5E>
Subject: Re: [Captive-portals] Alvaro Retana's No Objection on draft-ietf-capport-architecture-08: (with COMMENT)
X-BeenThere: captive-portals@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion of issues related to captive portals <captive-portals.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/captive-portals>, <mailto:captive-portals-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/captive-portals/>
List-Post: <mailto:captive-portals@ietf.org>
List-Help: <mailto:captive-portals-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/captive-portals>, <mailto:captive-portals-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 13 Jun 2020 12:52:41 -0000

Hi Alvaro.

Thanks for the review. Responses inline.

On Tue, 9 Jun 2020 at 16:16, Alvaro Retana via Datatracker
<noreply@ietf.org> wrote:
>
> Alvaro Retana has entered the following ballot position for
> draft-ietf-capport-architecture-08: No Objection
>
>
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
>
> I have some minor comments:
>
> (1) Please expand CAPPORT.
>
We'll do this.

> (2) §1: s/This document standardizes an architecture/This document describes an
> architecture   This is not a standard track document.

This has been pointed out by other reviewers as well. We'll correct it.

>
> (3) §1: "MAY allow a device to be alerted"   Other parts of the document (even
> in the same section) talk about "devices can be notified" or "informs an
> end-user", while "alert" is not mentioned anywhere else.  Given that "alert"
> has the normative attachment, it would be nice to use consistent language.

Seems reasonable. We'll change the language to be consistent.

>
> (4) §2.1: "E.g....MAY avoid updating..."   s/MAY/may   This is an example, not
> a normative statement.

I agree. I'll change it as part of rephrasing this statement to
address Benjamin's
review comments.

>
> (5) §3.1: "An Identifier MAY be a field...Or, an Identifier MAY be an ephemeral
> property..."   s/MAY/may  These seem to be statements and not normative
> statements.
>

We were trying to say that the identifier was allowed to be one of
those two things, but
I don't see the need for the normative language: what makes a possible
identifier is discussed
later. I'll replace the two 'MAY' occurrences with 'could'.

>

Thanks!

Kyle