Re: [Cbor] Barry Leiba's Yes on draft-ietf-cbor-sequence-01: (with COMMENT)

Barry Leiba <barryleiba@computer.org> Wed, 25 September 2019 20:20 UTC

Return-Path: <barryleiba@gmail.com>
X-Original-To: cbor@ietfa.amsl.com
Delivered-To: cbor@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 06DB3120154; Wed, 25 Sep 2019 13:20:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.923
X-Spam-Level:
X-Spam-Status: No, score=-1.923 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.026, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ql5Fmy2E_N4z; Wed, 25 Sep 2019 13:20:12 -0700 (PDT)
Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E87C8120018; Wed, 25 Sep 2019 13:20:11 -0700 (PDT)
Received: by mail-io1-f46.google.com with SMTP id v2so228367iob.10; Wed, 25 Sep 2019 13:20:11 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=+N9M/qWQVKuokm9AgA0VfxFy/hgq9d+btB6LNo8ii2E=; b=NaYOCEAdDwT/QxYpYiqDIOUSX8HNcv/jR1JSHgIvqXWzt2VDuSLV+/oklKOV76K8H8 ykWqjD7yzIUxtZ50JcglyUZeMwEoWzmMoSJKcg05oBmt2o7sYpMGa9DuyPMPB5Mmnof2 T9qkac2gVvuEOxxG3pkxZgY2kOiKegbekBPC2rjSywxZfd8bS2FhpxzNrlyv0WdfwSlO xYxa9viNrwl9X0MOX5Ly1+t+3qWZLD+NGSABc/BoTlZHik/P4LjdOtlSViFxypuA5fod 3erzmhZjB6HmugWLFE0hREsGxvCi2Y9ZZIkBqX+7uZs0PHjV0SZDve/q+7Y+kGR5dq33 KGew==
X-Gm-Message-State: APjAAAUuU4jzqXT6PAoO5UZOM7jmq9b2KS60+we+tr7uWB5bfqCXW1IA i5fB7RsuLfn9WwJL21mSSaV05Eo8oIB1Hkq2oWDCUg==
X-Google-Smtp-Source: APXvYqymVHLyFsbGqBQoZ14tV1kBHFLjejjRQ0NO268V2zbBjIskikUQdHgWSSaUUf4CCuwCso5jvd4YmXHSHjqIVFQ=
X-Received: by 2002:a05:6602:2244:: with SMTP id o4mr1392034ioo.107.1569442811030; Wed, 25 Sep 2019 13:20:11 -0700 (PDT)
MIME-Version: 1.0
References: <156823422600.13495.6043888160887106070.idtracker@ietfa.amsl.com> <38F1C119-C40A-4E17-B49B-B681E7562525@tzi.org>
In-Reply-To: <38F1C119-C40A-4E17-B49B-B681E7562525@tzi.org>
From: Barry Leiba <barryleiba@computer.org>
Date: Wed, 25 Sep 2019 16:19:59 -0400
Message-ID: <CALaySJKSwChHEy0rHTNo=GiHrrJ0fODOb1OOYiZtwFiT8v9msw@mail.gmail.com>
To: Carsten Bormann <cabo@tzi.org>
Cc: The IESG <iesg@ietf.org>, draft-ietf-cbor-sequence@ietf.org, Jim Schaad <ietf@augustcellars.com>, cbor-chairs@ietf.org, cbor@ietf.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/cbor/-zDzhvIkdK1S_WNm8FZynSrz-P4>
Subject: Re: [Cbor] Barry Leiba's Yes on draft-ietf-cbor-sequence-01: (with COMMENT)
X-BeenThere: cbor@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Concise Binary Object Representation \(CBOR\)" <cbor.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cbor>, <mailto:cbor-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cbor/>
List-Post: <mailto:cbor@ietf.org>
List-Help: <mailto:cbor-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cbor>, <mailto:cbor-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Sep 2019 20:20:14 -0000

Thanks!

b

On Wed, Sep 25, 2019 at 8:40 AM Carsten Bormann <cabo@tzi.org> wrote:
>
> Hi Barry,
>
> On Sep 11, 2019, at 22:37, Barry Leiba via Datatracker <noreply@ietf.org> wrote:
> >
> > Barry Leiba has entered the following ballot position for
> > draft-ietf-cbor-sequence-01: Yes
> >
> > When responding, please keep the subject line intact and reply to all
> > email addresses included in the To and CC lines. (Feel free to cut this
> > introductory paragraph, however.)
> >
> >
> > Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> > for more information about IESG DISCUSS and COMMENT positions.
> >
> >
> > The document, along with other ballot positions, can be found here:
> > https://datatracker.ietf.org/doc/draft-ietf-cbor-sequence/
> >
> >
> >
> > ----------------------------------------------------------------------
> > COMMENT:
> > ----------------------------------------------------------------------
> >
> > Thanks for a fine and mostly easy-to-read document.  There’s just one bit that
> > I find hard to read:
> >
> > — Section 2 —
> >
> >   Decoding a CBOR Sequence works as follows:
> >
> >   o  If the CBOR Sequence is an empty sequence of bytes, the result is
> >      an empty sequence of CBOR data model values.
> >
> >   o  Otherwise, decode a single CBOR data item from the bytes of the
> >      CBOR sequence, and insert the resulting CBOR data model value at
> >      the start of the result of decoding the rest of the bytes as a
> >      CBOR sequence.  (A streaming decoder would therefore simply
> >      deliver zero or more CBOR data model values, each of which as soon
> >      as the bytes making it up are available.)
> >
> > I find the phrasing of the second bullet (the part “at the start of the result
> > of decoding the rest of the bytes as a CBOR sequence.”) really hard to parse.
> > After a brief email exchange between Carsten and me before he zipped off on
> > holidays, I propose this minor re-wording:
> >
> > NEW
> >   o  Otherwise, decode a single CBOR data item from the bytes of the
> >      CBOR sequence, and insert the resulting CBOR data model value at
> >      the start of the result of repeating this decoding process
> >      recursively.  (A streaming decoder would therefore simply
> >      deliver zero or more CBOR data model values, each as soon
> >      as the bytes making it up are available.)
> > END
> >
> > Does that work for you, Carsten?
>
> Almost.
> This doesn’t say what the decoding process is applied to, so I added “with the remaining bytes”:
>
> * Otherwise, decode a single CBOR data item from the bytes of the CBOR
>   sequence, and insert the resulting CBOR data model value at the
>   start of the result of repeating this decoding process recursively
>   with the remaining bytes.  (A streaming decoder would therefore
>   simply deliver zero or more CBOR data model values, each as soon as
>   the bytes making it up are available.)
>
> Now in https://github.com/cbor-wg/seq/commit/ffa99b279f6ba91176b1af418388873f57390585
>
> Grüße, Carsten
>
>