IETF Logo Mail Archive

Re: [Cbor] [Last-Call] Last Call: <draft-ietf-cbor-tags-oid-05.txt> (Concise Binary Object Representation (CBOR) Tags for Object Identifiers) to Proposed Standard

Russ Housley <housley@vigilsec.com> Tue, 30 March 2021 13:53 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: cbor@ietfa.amsl.com
Delivered-To: cbor@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1CFEC3A132D for <cbor@ietfa.amsl.com>; Tue, 30 Mar 2021 06:53:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.897
X-Spam-Level:
X-Spam-Status: No, score=-1.897 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HENBM9j73L8s for <cbor@ietfa.amsl.com>; Tue, 30 Mar 2021 06:53:34 -0700 (PDT)
Received: from mail.smeinc.net (mail.smeinc.net [209.135.209.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D019A3A1327 for <cbor@ietf.org>; Tue, 30 Mar 2021 06:53:34 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by mail.smeinc.net (Postfix) with ESMTP id 86D10300B43 for <cbor@ietf.org>; Tue, 30 Mar 2021 09:53:32 -0400 (EDT)
X-Virus-Scanned: amavisd-new at mail.smeinc.net
Received: from mail.smeinc.net ([127.0.0.1]) by localhost (mail.smeinc.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id qoUmCKVNhhmr for <cbor@ietf.org>; Tue, 30 Mar 2021 09:53:29 -0400 (EDT)
Received: from [192.168.1.161] (pool-141-156-161-153.washdc.fios.verizon.net [141.156.161.153]) by mail.smeinc.net (Postfix) with ESMTPSA id C5C3D30024B; Tue, 30 Mar 2021 09:53:28 -0400 (EDT)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\))
From: Russ Housley <housley@vigilsec.com>
In-Reply-To: <84A6EB39-38B6-4CE1-B077-F014AD0C7C14@ericsson.com>
Date: Tue, 30 Mar 2021 09:53:29 -0400
Cc: Carsten Bormann <cabo@tzi.org>, Christian Amsüss <christian@amsuess.com>, Last Call <last-call@ietf.org>, "cbor@ietf.org" <cbor@ietf.org>, "barryleiba@gmail.com" <barryleiba@gmail.com>, "draft-ietf-cbor-tags-oid@ietf.org" <draft-ietf-cbor-tags-oid@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <2CEDE813-AA1A-47D8-9799-63730E18363B@vigilsec.com>
References: <161478804980.26099.10355192606526568978@ietfa.amsl.com> <C0ABE813-36C8-4D0F-8540-42FCA7584C3E@vigilsec.com> <E7DB52CC-8565-4AFC-AB16-6EFA299B9520@tzi.org> <84A6EB39-38B6-4CE1-B077-F014AD0C7C14@ericsson.com>
To: Francesca Palombini <francesca.palombini@ericsson.com>
X-Mailer: Apple Mail (2.3445.104.17)
Archived-At: <https://mailarchive.ietf.org/arch/msg/cbor/C0BSiAgEwXVzcgQqnyZB7aTkX7E>
Subject: Re: [Cbor] [Last-Call] Last Call: <draft-ietf-cbor-tags-oid-05.txt> (Concise Binary Object Representation (CBOR) Tags for Object Identifiers) to Proposed Standard
X-BeenThere: cbor@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Concise Binary Object Representation \(CBOR\)" <cbor.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cbor>, <mailto:cbor-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cbor/>
List-Post: <mailto:cbor@ietf.org>
List-Help: <mailto:cbor-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cbor>, <mailto:cbor-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Mar 2021 13:53:41 -0000

The PR fully resolves my comment.

Russ

> On Mar 30, 2021, at 4:45 AM, Francesca Palombini <francesca.palombini=40ericsson.com@dmarc.ietf.org> wrote:
> 
> The PR looks good, thanks Russ for pointing this out. If you have any more comments please let us know, otherwise I will push the button as soon as the draft is updated.
> 
> Francesca
> 
> On 04/03/2021, 10:44, "last-call on behalf of Carsten Bormann" <last-call-bounces@ietf.org on behalf of cabo@tzi.org> wrote:
> 
>    On 2021-03-03, at 18:11, Russ Housley <housley@vigilsec.com> wrote:
>> 
>> The text says "...MUST be a syntactically valid BER representation of an object identifier ...", but this is not fully correct.  It is the value portion of the BER representation.  The CBOR encoding does not carry (and dies not need to carry) the type of length bytes of the BER representation.
> 
>    Indeed.
> 
>    Now https://github.com/cbor-wg/cbor-oid/pull/8
> 
>    Thank you!
> 
>    Grüße, Carsten
> 
>    -- 
>    last-call mailing list
>    last-call@ietf.org
>    https://www.ietf.org/mailman/listinfo/last-call
> 
> -- 
> last-call mailing list
> last-call@ietf.org
> https://www.ietf.org/mailman/listinfo/last-call

v2.23.0 | Report a Bug | By Email