Re: [Cbor] Genart last call review of draft-ietf-cbor-date-tag-05

Jim Schaad <ietf@augustcellars.com> Tue, 04 August 2020 00:57 UTC

Return-Path: <ietf@augustcellars.com>
X-Original-To: cbor@ietfa.amsl.com
Delivered-To: cbor@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 391D33A11C8; Mon, 3 Aug 2020 17:57:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.001
X-Spam-Level:
X-Spam-Status: No, score=0.001 tagged_above=-999 required=5 tests=[SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IQBBeg8k4YDs; Mon, 3 Aug 2020 17:57:45 -0700 (PDT)
Received: from mail2.augustcellars.com (augustcellars.com [50.45.239.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7E0FB3A11C7; Mon, 3 Aug 2020 17:57:44 -0700 (PDT)
Received: from Jude (73.180.8.170) by mail2.augustcellars.com (192.168.0.56) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 3 Aug 2020 17:57:37 -0700
From: Jim Schaad <ietf@augustcellars.com>
To: 'Linda Dunbar' <linda.dunbar@futurewei.com>, gen-art@ietf.org
CC: draft-ietf-cbor-date-tag.all@ietf.org, last-call@ietf.org, cbor@ietf.org
References: <159650146206.14996.18192684961495413978@ietfa.amsl.com>
In-Reply-To: <159650146206.14996.18192684961495413978@ietfa.amsl.com>
Date: Mon, 03 Aug 2020 17:57:35 -0700
Message-ID: <053e01d669fa$4003f530$c00bdf90$@augustcellars.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Outlook 16.0
Content-Language: en-us
Thread-Index: AQG9ChEKlhdJWGulY6hItQwMxaY9t6lZ3+rQ
X-Originating-IP: [73.180.8.170]
Archived-At: <https://mailarchive.ietf.org/arch/msg/cbor/CT-1ulmPx9nPnQuovT82BzglCZQ>
Subject: Re: [Cbor] Genart last call review of draft-ietf-cbor-date-tag-05
X-BeenThere: cbor@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Concise Binary Object Representation \(CBOR\)" <cbor.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cbor>, <mailto:cbor-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cbor/>
List-Post: <mailto:cbor@ietf.org>
List-Help: <mailto:cbor-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cbor>, <mailto:cbor-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Aug 2020 00:57:46 -0000


-----Original Message-----
From: Linda Dunbar via Datatracker <noreply@ietf.org> 
Sent: Monday, August 3, 2020 5:38 PM
To: gen-art@ietf.org
Cc: draft-ietf-cbor-date-tag.all@ietf.org; last-call@ietf.org; cbor@ietf.org
Subject: Genart last call review of draft-ietf-cbor-date-tag-05

Reviewer: Linda Dunbar
Review result: Ready with Issues

I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair.  Please treat these comments just like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-cbor-date-tag-05
Reviewer: Linda Dunbar
Review Date: 2020-08-03
IETF LC End Date: 2020-08-14
IESG Telechat date: Not scheduled for a telechat

Summary:
    This is a very simple draft, describing how calendar dates are represented,
    the same way as common knowledge  on how calendar dates are represented.  I
    am surprised that the draft is "STANDARD track".  Why?  The only thing
    might be that Tag 1004 is Text String, and Tag 100 is a negative integer. 
    Is it all for a RFC?

Section 1.3 states that Dates cannot be properly compared unless Time Zone is attached. Strangely, the Time Zone is not included in the tag 1004 or Tag 100. 
 Why?

[JLS] Linda, This section deals not with comparing Dates with each other, but comparing Dates with Date/Time Values.  This would mean that comparing 01/01/2020 with 01/01/2020 3:59 PST does not make any sense because one has a Time Zone and the other does not.

Jim


Major issues:

Minor issues:

Nits/editorial comments:

Best regards,
Linda Dunbar