Re: [Cbor] Iotdir telechat review of draft-ietf-cbor-tags-oid-06
Ines Robles <mariainesrobles@googlemail.com> Tue, 06 April 2021 19:07 UTC
Return-Path: <mariainesrobles@googlemail.com>
X-Original-To: cbor@ietfa.amsl.com
Delivered-To: cbor@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D2E4F3A2CC3; Tue, 6 Apr 2021 12:07:54 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=googlemail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Gf0JtiSEthOc; Tue, 6 Apr 2021 12:07:49 -0700 (PDT)
Received: from mail-vs1-xe2c.google.com (mail-vs1-xe2c.google.com [IPv6:2607:f8b0:4864:20::e2c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2FDBA3A2CC0; Tue, 6 Apr 2021 12:07:48 -0700 (PDT)
Received: by mail-vs1-xe2c.google.com with SMTP id u29so8364036vsi.12; Tue, 06 Apr 2021 12:07:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=M3mj9xUE92ahhN0CMAruJtgy63J9af6uqFvZ9hyEnh4=; b=otnwfQNAq85zoUfBfRV+pOiXvppdVhTdST/w0MFnjMOOBw7qY9daOir7oF384uaxEk llSyES6OymCSA0slQyh1Bn49psT3mXcXHnymzkl4Fya7wKvo4g1ffVRqgdlKHVcbRdUR tFK5kk1exT6K4oWbn6JayD207rPpJnMC0hJaPiQsjB60g5eVm+QoyZyfasa/cTS4mrr7 p4e+CeG26vQ93S2XXzrJgcm36h4jVlTtVMDHjNKjarVh9B1vNwvqLDAaUivrjIv7oPHG FSu5Rz7pP7oIfsQrtptRIo5+9i83xdb1AiCWNZ/ZiNcp7cv2ii6KkbuURrJlS5RYYJBo xiXw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M3mj9xUE92ahhN0CMAruJtgy63J9af6uqFvZ9hyEnh4=; b=dYcU1dtA7MAwoRfDYzkU3F13/WI60OSaKLni5Rrsy6F6luIv8B82CDqeHuDQbwq8kr xgf8n2pv/cOtpV7COUDb5PCASGQJ2ePJCHloFG1ftSX+bi1JgXhInTNmiEcRPA05nOrY eaknJ4IpAufmoWuh5vIhBr2orrQHhghhGEvazeaBfDkdpn61ajFESTU7Mney4uXyKd0g t5fXrvl430olk89Ad9EQrTv8HnWwP3lL7FIJKmB/vz0ErqGFg0aCiP/9ufzqibXPlgdY SZgjI/Gc0uteR8YGl/knu9BNYXg01SzhzIDmja7FPUQ00VN59b8DuSMGxjD1cjw+PI8z 6JMA==
X-Gm-Message-State: AOAM530KEOpFT/vwdRDJfvD0sXA/wjGoV19atKWdyWlnMeQY3Z9GJ6lN oJq6AFdt6NjwAP2GSdxg81pF1DSmJHYxcAKcEUKcc4wdoUWhOw==
X-Google-Smtp-Source: ABdhPJx4q0msMVjzIVYEYRv05BvHYxZLLWy46Ookgigs1LD9XD9d+AYkro294xsAM+/zo2WqwkUpHLBqU090JEjPSIg=
X-Received: by 2002:a67:ef0d:: with SMTP id j13mr19210861vsr.3.1617736067231; Tue, 06 Apr 2021 12:07:47 -0700 (PDT)
MIME-Version: 1.0
References: <161772606961.13833.6830636143413776698@ietfa.amsl.com> <D3A61CA0-2197-4885-BBD6-CE12D70B7AD8@tzi.org>
In-Reply-To: <D3A61CA0-2197-4885-BBD6-CE12D70B7AD8@tzi.org>
From: Ines Robles <mariainesrobles@googlemail.com>
Date: Tue, 06 Apr 2021 22:07:11 +0300
Message-ID: <CAP+sJUe4MWhzGtfwpy-qUW3OPHv_1KLGaqC3-sj_Kzo8Yq7mFw@mail.gmail.com>
To: Carsten Bormann <cabo@tzi.org>
Cc: IETF IoT Directorate <iot-directorate@ietf.org>, cbor@ietf.org, draft-ietf-cbor-tags-oid.all@ietf.org, last-call@ietf.org
Content-Type: multipart/alternative; boundary="000000000000a0b49805bf5287ea"
Archived-At: <https://mailarchive.ietf.org/arch/msg/cbor/REAtH0T7dkP02s7LBKssOJn19QA>
Subject: Re: [Cbor] Iotdir telechat review of draft-ietf-cbor-tags-oid-06
X-BeenThere: cbor@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Concise Binary Object Representation \(CBOR\)" <cbor.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cbor>, <mailto:cbor-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cbor/>
List-Post: <mailto:cbor@ietf.org>
List-Help: <mailto:cbor-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cbor>, <mailto:cbor-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2021 19:07:55 -0000
Thank you very much Carsten for addressing my comments Liebe Grüße, Ines On Tue, Apr 6, 2021 at 7:59 PM Carsten Bormann <cabo@tzi.org> wrote: > Hi Ines, > > thank you for these comments! > > Good catch with the 0b010_01001! > I should know better (made the same kind of mistake in RFC 7049). > > I actually kept in a second expansion of SDNV in Section 2; possibly the > RFC editor will strike that, but I find it useful. > > All the below are now in > https://github.com/cbor-wg/cbor-oid/commit/9c90d8d > > Grüße, Carsten > > > > On 2021-04-06, at 18:21, Ines Robles via Datatracker <noreply@ietf.org> > wrote: > > > > Reviewer: Ines Robles > > Review result: Ready with Nits > > > > Summary: > > > > The document defines CBOR tags for object identifiers (OIDs). The > document is > > well written. > > > > Few minor questions/comments. > > > > Major Issues: None > > > > Minor Issues: None > > > > Nits: > > > > - It would be nice to expand SDNV in section 1.1 instead of Section 2. > > > > - Section 3.2 - Figure 4-MIB relative object identifier in CBOR: > > > > 0b010_01001 should be 0b010_00011 ? for major type 2, additional > information 3 > > bytes > > > > - Section 7.1: > > > > -- In order to mention the registry, maybe smth like > > > > to assign the CBOR tags --> to assign in the CBOR tags registry the > following > > tags.... > > > > -- It would be nice to have the table with the same structure as the > registry > > table (add reference column like in Section 7.2), I think template > column does > > not apply here. > > > > - Section 7.2: > > > > -- In order to mention the registry, maybe smth similar as Section 7.1? > > > > Thank you for this document, > > > > Ines. > > > > > >
- [Cbor] Iotdir telechat review of draft-ietf-cbor-… Ines Robles via Datatracker
- Re: [Cbor] Iotdir telechat review of draft-ietf-c… Carsten Bormann
- Re: [Cbor] Iotdir telechat review of draft-ietf-c… Ines Robles
- Re: [Cbor] [Iot-directorate] Iotdir telechat revi… Eric Vyncke (evyncke)