Re: [Cbor] [Gen-art] Genart last call review of draft-ietf-cbor-array-tags-07

Alissa Cooper <alissa@cooperw.in> Thu, 03 October 2019 00:02 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: cbor@ietfa.amsl.com
Delivered-To: cbor@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C01CF1200FF; Wed, 2 Oct 2019 17:02:25 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=LSLdvfAU; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=Teec/Be0
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WMP0vm40SEh7; Wed, 2 Oct 2019 17:02:22 -0700 (PDT)
Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9EBD81200F4; Wed, 2 Oct 2019 17:02:22 -0700 (PDT)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 53306520; Wed, 2 Oct 2019 20:02:21 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 02 Oct 2019 20:02:21 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h= from:message-id:content-type:mime-version:subject:date :in-reply-to:cc:to:references; s=fm1; bh=LefBafT0Qd/+Hg4VGte/gjU Ej2+cu9tKSVoTxny39zI=; b=LSLdvfAU2fJN8GzX8F8zu4BRd5VI/GqlHnR6iDX xvugSDvNw/LOrjOROWBGqJOn4cfYf0pwsu5oaMOd3bBAq7ePwIXsAG0SITcVXUq6 3Ur/wcjjNtnLrKYmO4ak+0NmQqM0fu/LNowCO1hYQi2ejnn4UV0tEBOXSihE/LpV mLFpqHb3K1lJ4JhixjLgZvaluObWqLp1Ox46YQ/LsNW7UWZJpFdKDtvMz9EvazfL KqNwvoy2kgrLoEt82kQ2pOu7tDG8tm5Te7RgZ5GvU2BqGzaXzmHL27oK1JiAOMRc NZbRa0u2JB/HC0VrRrdOEDtKZFpoLQScV1iigppeunAhhuA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=LefBaf T0Qd/+Hg4VGte/gjUEj2+cu9tKSVoTxny39zI=; b=Teec/Be0chIsiT4H890dkg ZVM3Y6LXPvVDIwbcGd/Ocwl7reZ4bkJBqTKyMpq6zB9/Qweq3wmR0BXqFj/WGikV g5sFv8wMYJZyBPUXnOyYNBXQirKl5aF9ycumbWPy6DVQ9udZh2ghMncgMElgKLEm VdgSSMreiLYj/do03SUOjtzkLAu/MkPlg/znOu3cAoIA5Py6m/t7N0gFTUcKOd3j xYRN6xtkYNpOn5QzWiQMnnJezWSIUsfZ0tQLF8HJlscDhX7eZM9mNYF3IoYaQxjX h+l5qnaIPZKTSlF8l0H/7ElNvpN8XLFfT2SgfH3r2JCA5n0KDnayYFA3jOO9mjSg ==
X-ME-Sender: <xms:jDqVXdTzxGC96cXC_0RFmesGhh9emy-sFomRmZjQU-jFb5zVKNmV1g>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrgeejgddvjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhkfgtggfuffgjvfhfofesrgdtmherhhdtjeenucfhrhhomheptehlihhsshgr ucevohhophgvrhcuoegrlhhishhsrgestghoohhpvghrfidrihhnqeenucffohhmrghinh epghhithhhuhgsrdgtohhmpdhivghtfhdrohhrghenucfkphepuddtkedrhedurddutddu rdelkeenucfrrghrrghmpehmrghilhhfrhhomheprghlihhsshgrsegtohhophgvrhifrd hinhenucevlhhushhtvghrufhiiigvpedt
X-ME-Proxy: <xmx:jDqVXZUpEPkB3-w0OG0lnNQ-MbQcsy9hhqg4dE2aUth-zi3nhKFlsg> <xmx:jDqVXWdnt6O5eTvMOMDpRRNu9LGqK70HXuvURqHAavjmVMpV7cgQ-w> <xmx:jDqVXVJGfi6C5MzPuED-vbjKDs9nvjJH8aTnGvjx88Bpllu3xbWnxA> <xmx:jDqVXeEyR8VQoVlkLMBzzrC_PNYX9VgBRPBVHCvnaZs5om-CtoXR_A>
Received: from alcoop-m-c46z.fios-router.home (pool-108-51-101-98.washdc.fios.verizon.net [108.51.101.98]) by mail.messagingengine.com (Postfix) with ESMTPA id F0DADD6005A; Wed, 2 Oct 2019 20:02:19 -0400 (EDT)
From: Alissa Cooper <alissa@cooperw.in>
Message-Id: <33806E72-1F8C-46D5-B984-AAEE82770753@cooperw.in>
Content-Type: multipart/alternative; boundary="Apple-Mail=_AF1D0EC6-7846-4ECA-9416-978C27FF5D81"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Date: Wed, 2 Oct 2019 20:02:18 -0400
In-Reply-To: <2090EB76-F175-4735-A29A-C7A4ED97A8E8@tzi.org>
Cc: cbor@ietf.org, General Area Review Team <gen-art@ietf.org>, IETF <ietf@ietf.org>, draft-ietf-cbor-array-tags.all@ietf.org
To: Carsten Bormann <cabo@tzi.org>, Elwyn Davies <elwynd@dial.pipex.com>
References: <156779841919.21968.7839958128124169842@ietfa.amsl.com> <2090EB76-F175-4735-A29A-C7A4ED97A8E8@tzi.org>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/cbor/RllTGaHiQnDYzWJ6UQEaNokFJMY>
Subject: Re: [Cbor] [Gen-art] Genart last call review of draft-ietf-cbor-array-tags-07
X-BeenThere: cbor@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Concise Binary Object Representation \(CBOR\)" <cbor.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cbor>, <mailto:cbor-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cbor/>
List-Post: <mailto:cbor@ietf.org>
List-Help: <mailto:cbor-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cbor>, <mailto:cbor-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Oct 2019 00:02:26 -0000

Elwyn, thanks for your review. Carsten, thanks for addressing Elwyn’s comments. I entered a No Objection ballot.

Alissa


> On Sep 25, 2019, at 10:55 AM, Carsten Bormann <cabo@tzi.org> wrote:
> 
> Hi Elwyn,
> 
> thank you for these comments.
> These are now addressed in the editor’s copy on github, specifically in
> https://github.com/cbor-wg/array-tags/commit/f63c0301c481ab773c16b96a9b0eb63456554049 <https://github.com/cbor-wg/array-tags/commit/f63c0301c481ab773c16b96a9b0eb63456554049>
> Details below.
> 
>> On Sep 6, 2019, at 21:33, Elwyn Davies via Datatracker <noreply@ietf.org> wrote:
>> 
>> Reviewer: Elwyn Davies
>> Review result: Ready with Nits
>> 
>> I am the assigned Gen-ART reviewer for this draft. The General Area
>> Review Team (Gen-ART) reviews all IETF documents being processed
>> by the IESG for the IETF Chair.  Please treat these comments just
>> like any other last call comments.
>> 
>> For more information, please see the FAQ at
>> 
>> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
>> 
>> Document: draft-ietf-cbor-array-tags-07
>> Reviewer: Elwyn Davies
>> Review Date: 2019-09-06
>> IETF LC End Date: 2019-09-05
>> IESG Telechat date: Not scheduled for a telechat
>> 
>> Summary:
>> Ready with a couple of nits.  Apologies for slightly late delivery.
>> 
>> Major issues:
>> None
>> 
>> Minor issues:
>> None
>> 
>> Nits/editorial comments:
>> s1, para 2: s/have received/has received/
>> 
>> s1, para 3: s/This also can/This can also/
>> 
>> s1.1, last para: s/whether that/as to whether that/
> 
> I put these in (oops, missed one, now in https://github.com/cbor-wg/array-tags/commit/4490e8b6f9f157779783f645c2c4ee6f9e749f74 <https://github.com/cbor-wg/array-tags/commit/4490e8b6f9f157779783f645c2c4ee6f9e749f74> ).
> 
>> 
>> s2.1, 2nd para after Table 2 (top of page 5):
>> OLD:
>>     It can be computed
>>     inversely to the previous formula from the length of the byte string
>>     in bytes: "bytelength >> (f + ll)".
>> NEW:
>>     It can be computed from the length of the byte string comprising the
>>     representation of the array by inverting the previous formula: "bytelength
>>>> (f + ll)".
>> ENDS
> 
> This misses the “in bytes”, which may be obvious to many, but should be said.
> Now:
> 
> It can be
> computed from the length, in bytes, of the byte string comprising the
> representation of the array by inverting the previous formula:
> `bytelength >> (f + ll)`.
> 
>> s2.1: The terms endianness, big endian and litle endian are jargon, if pretty
>> well known jargon, but I don't know if they are considered to be adequately
>> well understood to avoid the need for a reference or  an explanation of what is
>> meant.
> 
> Very good point; we sometimes get too mired in our jargon.
> 
> Now at the end of the terminology section:
> 
> The terms "big endian" and "little endian" are used to indicate a most
> significant byte first (MSB first) representation of integers, and a
> least significant byte first (LSB first) representation, respectively.
> 
> I think we can tolerate the one occurrence of “endianness” before that, as that is just in a list of examples.
> 
> Grüße, Carsten
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org <mailto:Gen-art@ietf.org>
> https://www.ietf.org/mailman/listinfo/gen-art <https://www.ietf.org/mailman/listinfo/gen-art>