Re: [Cbor] Zaheduzzaman Sarker's No Objection on draft-ietf-cbor-file-magic-11: (with COMMENT)

Zaheduzzaman Sarker <zaheduzzaman.sarker@ericsson.com> Thu, 21 April 2022 13:51 UTC

Return-Path: <zaheduzzaman.sarker@ericsson.com>
X-Original-To: cbor@ietfa.amsl.com
Delivered-To: cbor@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 74A3F3A15CA; Thu, 21 Apr 2022 06:51:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.107
X-Spam-Level:
X-Spam-Status: No, score=-2.107 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id baLilnvDHowg; Thu, 21 Apr 2022 06:51:13 -0700 (PDT)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02on0620.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe05::620]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 67F6B3A1592; Thu, 21 Apr 2022 06:51:12 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AnWTp7oQ6AxtrkEheIS2Ac/ipfuh7jzd0DYn8SQGbhoCPbpx33J/SoPDNQ8qNE4qIeOxJwe8u9vyFxUgizJ1I85i4TEsUMO92vQV7l2Jv4sYyg6fz116udJ5ltz6XwIrV9rMq01QT5TWvEdXHdwMZgcTm4IcZ+oo7GVheVN8iPpsNPEwt27emaQu26RCQ1ieWTfdsk8/fze0T1iDfHArjDV80Yw6w+ZcJDLeOnGAJZyCDm9hIgh/PsLnRBDmzSRrQrRWYeqtaYx73LUNARgYRnPCeLycJzM+/TmenGUvss3YmHVcxZM9roBljj0ZuYFe+43ZVbX/iXJFyGEA8E0HYw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NWyxgr8wSLWey5MEH2mefAuhE3yeLSJw2/p0U5s6pTk=; b=gyVM5jqLZ3xBS/UqYCX8692gX1ItKjI5ZSauT+AMMxfFTcu6bFBNm5HOuWTnCF47bsEbdi9Zl6PewubnnvrZNG5meP6/rx4ans8C0O63XPMslEXN6C/lAFrZGweivorKGf1kgnk1EI13DEG1K363CT9qg1EjaODWHp3C241KtFnKyqF3d20hj+kp6yt+vjGrvXLJb7BX07A3nPjkXQxNbczfo6yd9il2oWbGgeQYWl2xwXn5MIND2sQSkr111PMRqKumKktZYRvIJOdMmu6psA6pXZFqSLleIGn6MD4V/buIcv2OYuL7Hq8kwyz6QpsEHL0lz162wIlQy9+0re8jkw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NWyxgr8wSLWey5MEH2mefAuhE3yeLSJw2/p0U5s6pTk=; b=ANQY3l5gfl1cJGPFTXzH+xXyaNxhEEOxznfJdZdMW49XBpXcwVtPYkOT1JqOFO4+/TgRFQ5CBJJ/izCTALqeXpo6yX7yUnvfTDI0yOTElmVUsVCGQU18FFUqQEg5il6tsbg7rgyBY6Gc0SePH9YkIlirJldzORBgWPC588u1W+U=
Received: from HE1PR07MB4187.eurprd07.prod.outlook.com (2603:10a6:7:98::23) by HE1PR07MB3433.eurprd07.prod.outlook.com (2603:10a6:7:38::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.11; Thu, 21 Apr 2022 13:51:05 +0000
Received: from HE1PR07MB4187.eurprd07.prod.outlook.com ([fe80::49d6:fc38:a3d:3210]) by HE1PR07MB4187.eurprd07.prod.outlook.com ([fe80::49d6:fc38:a3d:3210%6]) with mapi id 15.20.5186.014; Thu, 21 Apr 2022 13:51:05 +0000
From: Zaheduzzaman Sarker <zaheduzzaman.sarker@ericsson.com>
To: Carsten Bormann <cabo@tzi.org>
CC: The IESG <iesg@ietf.org>, Christian Amsüss <christian@amsuess.com>, "cbor@ietf.org" <cbor@ietf.org>, "cbor-chairs@ietf.org" <cbor-chairs@ietf.org>, "draft-ietf-cbor-file-magic@ietf.org" <draft-ietf-cbor-file-magic@ietf.org>
Thread-Topic: [Cbor] Zaheduzzaman Sarker's No Objection on draft-ietf-cbor-file-magic-11: (with COMMENT)
Thread-Index: AQHYVJJffI4/B1EvNEucT/Snpb6dG6z4/uwAgAFln4A=
Date: Thu, 21 Apr 2022 13:51:05 +0000
Message-ID: <5A18885B-E22C-4D25-AC69-69812346304C@ericsson.com>
References: <165044403005.9373.3182771372557501317@ietfa.amsl.com> <AF4E6D7A-10E3-4DB5-A6B5-9ADE2E4D0963@tzi.org>
In-Reply-To: <AF4E6D7A-10E3-4DB5-A6B5-9ADE2E4D0963@tzi.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=ericsson.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 8910ed86-768c-4685-42ed-08da239dfb08
x-ms-traffictypediagnostic: HE1PR07MB3433:EE_
x-microsoft-antispam-prvs: <HE1PR07MB3433CF5747AC5E528A1A9CE69FF49@HE1PR07MB3433.eurprd07.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: x5zPxuHTaGQzejUmUVKGL0NCVXUfYRFJAulv12Z2UwlUJRj+wEIXErwgWR00xsgAI4ivO+4ZJ65jXifcGnh212uGix3A3RXZbnJvI5kYhWh+VB3/Bl+bM+HWt2nCK4k9Mzjtx/6UhK/dT7D334PKjqwE1oXDfXxzscatrH2y6d2HkHoEjGyMaRL93EljaOheDQ4lY3SQzilEPzPVQAMFJjiLtFddRAOwJCjMM0FqOL4AUDZY75qfrjm++ZOzWRaraZI1KQQbOByNeWcalm6WITM/BKE7aP7i0HgF9aF2kb3Fdo9YRFyVJDFDiAMO/B8qCOivxPdRuVknNleaxCxZnHDQfJ72xGxSnczmAOqyPo7d3EjTYYz9VhoWjrKCSiFb212HHF1iAz0pAogqs3XCi99P75He3VOQYTtuor0HWhNNbMBNLK1XDZpqXxtTUEMnA200ju/yj36N363LMyHmoRlfY3mnFNPNTHOCYxFpsLoct5diNN8so9yX5xllj5xg3rw1ZejNQYfe6UMUxjp1hbaPkJxvEUDLpJUhboZMmreOIULj18aj3MclR6ehoZBcUgf7XwdI9R7SUQIXzlu9uO41yfCMtI3l/4Fsy19G0aIWCrCijhod5REnl23YQXUxlRUKzm8blyh651bsQD68uvW+DXbYy5c2zCyi0PSxN4xK0n80WC/5ca1/6vxVs6CY874yseznqf8lEAgTiYQLHLN257zoSDeH0weytvYs2qiHnwKxunMppN0XreDvXZINDNSa37IpwluVXr02LF05Arkd5n0Mf2BQuuYaFDTOG+EACRDz4c36+5PVkKEaBYtDK1DUrYioHjJ7c0+6WJ4BOnRnxHb9BUhuX9tmczhvjGBzGbGj0E4UWuLdrOaZ2j7uqcVUW0UMKR0fFn1a3p3mGdzhkXWDBbqg7G4K2bRTVq4=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HE1PR07MB4187.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(33656002)(122000001)(82960400001)(6916009)(26005)(5660300002)(38100700002)(54906003)(71200400001)(186003)(36756003)(38070700005)(99936003)(316002)(8676002)(2906002)(4326008)(86362001)(66556008)(66946007)(64756008)(66446008)(83380400001)(6486002)(53546011)(66476007)(6506007)(76116006)(966005)(8936002)(2616005)(44832011)(91956017)(508600001)(6512007)(45980500001); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: b8n3dzP/fF5bS6PYWBFzPMGopp1NiiQ1jxhS4wP63pVrCJbv6y81UvbLJGskNa0yj7248zyo6n/d4cggbkAkvmPRNLE/ITIWpKrrt9jdeIXu6ao61u/46zvLbEhqdSIOWvEwrjlUpE6VA6WEqzq9+Vtsa7iNJm86SkWJXjIPmuCeZm0MhQXPIaomPSxIS/kZW2rCPwmnJSJveR/y6PWyhjYwrBdv4wjzxmfYD/PQECzYhKHOzR+4Kvuljby1l7l7jC21U7deMqluP12G8itjIuCVr5m02p6O8TEAsyhIXv0iUuhEhCd7wWXA5sxMxvq5LYNOGUW/fKINYK88gsi+4F2t4lzK8pjxUzDxvZlnM+2cfJ4BrT9L2P/oaKgm5IjiC94IceVtcz/2x6ekmHzEndSx6PgLiv5vTh7dukz0WVV595ff6JAan3H53ptpZpuEuTYaE0Hmdhgb1E+Y3R7UO7MsGR0EUHH+26AEHKxBcgEyN6lEj/iY/LnymfgOA5B2q9Jf8ZbljkoJS/bpoJLOV/URCHVGt0KsQjUm359SJ1lRYG6HCqCWpMu7Sh5y/U2j5p4Q+ExQ75cG9TluEZz7xQOUmpLIFgPZKBIX+MeAAAC4MQBJPYS7If41pqrRPHTwBekX1XC4V53sz4Zdf2GSBM5B3wdywU/zO6GFx15twAZh6kLbCf2jj7+6xrVvsfYGwLNP7wckl6Veu+5GOwU4UFJIJ1ehyD/dc7ziZSGEnhRxh4OjnSu5JJCGm3LjFsOLBcdqBSX76B+zAdhnytm9oXgv4zfum+8oX29RuZCONRV6RdqOtZc0+VW9wfJnC5GosNw1+sSLqUOIrIu3wl2Jc1P9NrQ6BSryJ3Ve2oXuk6nsOhHR+jQg/VIx3w3wfuzUU+bBtvi5iRP8IsgUN26NBiWxt+B+TyH7qQStlDB1YqfvEB9Fon/+ySXil5kkEluEkzyZQAUuG1ZB1jwck5jrHTvPpTiXi3vtD2bagLgT4kb6UyfyhKJddS1y93wFIH6UUU28dRRGHQLEdgpA3wTg2DTnY0bXojkufOmUvWJFP64qZj9gedUWoNnVdaL/7IyQsk5ZvmvjsNXzuDO2h/mCDlbj5Ut9qpUxX7uJGIMYRdkdn9rEvckVCCoCDM+ZVnIRjJfK2HMzECiVmPYatzceZWJN4zJ8OB6NQvzqqigdDFJegcDUrqPTz8uDuwqPLsE6/Kzt96jeRlZtRIrt4oazRujqKvQERj79TAILreZHXkAje3zHkMARC5OKC21C5V2PQZNnIza5C7xEhkQ0w3J+2o7hlW0Gc+3N/D1ofOjkfH6xhLNcPco4tQSv4uU+lvQYemlLIOjHc25EYyKtjjfFTKtSgwld9Prjv/cZe/2lRcacL5Uzw3ct2wh/U+VglQzrB8G4KCxMUrLMVd5HWdCiJbKcI1T6EY2rGyhSeFsxbZLUdET65wRL0SfkgE21ju9DmCzWbCo/6b3QwXXvS0uPagD1VC+fIcM60eKMeGcXmvPHLr00C1UPGfyr3dksZtMXDWtD0Rh6VzDmNaSyhm8u5s2dUdrj67fyVA1N8w2WKZN0Lq9CjVKCP321AGfVKXGC6dRr0D+s1BbVamCtc+BOPzAwJe1R73Sv9sR20O4d35Uv9gu4L88HWwPSA3RSbZqldDCOLqkr/UHAQR6YVaGBznihKnvk1bDGfEHxJD1pkGPVsWDKuwlGC+MeLoR8NhzMlTwwfr2qQTdjkXs0vaFJjzCpWtt23jI9smU/4BlpaBvTquw6p00FBLZ0T1LSMxRD
Content-Type: multipart/signed; boundary="Apple-Mail=_D671B6C7-43E1-4798-849D-51268E752B3B"; protocol="application/pkcs7-signature"; micalg="sha-256"
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: HE1PR07MB4187.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8910ed86-768c-4685-42ed-08da239dfb08
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2022 13:51:05.4494 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: aUAX8+MsqvTa8er2+8UY/jVyfdY59/gSiQzRb0EVphyzl7CGmKV8XjIx/NxIebiJK9L2h3b6WMFEBw2Rjq21HOorF8p3H3wodcaTDRXqqW28xr/nSnJmdOoCfWDGbiIB
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR07MB3433
Archived-At: <https://mailarchive.ietf.org/arch/msg/cbor/Vafzwgt0kUxERZUOvKqqeDX4vcs>
Subject: Re: [Cbor] Zaheduzzaman Sarker's No Objection on draft-ietf-cbor-file-magic-11: (with COMMENT)
X-BeenThere: cbor@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Concise Binary Object Representation \(CBOR\)" <cbor.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cbor>, <mailto:cbor-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cbor/>
List-Post: <mailto:cbor@ietf.org>
List-Help: <mailto:cbor-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cbor>, <mailto:cbor-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Apr 2022 13:51:19 -0000

Thanks Carsten and Michael for the responses.

> On 20 Apr 2022, at 18:31, Carsten Bormann <cabo@tzi.org> wrote:
> 
> Hi Zahed,
> 
> thank you for this review.
> 
> I have collected my proposed changes based on these and other comments in 
> 
> https://protect2.fireeye.com/v1/url?k=31323334-501d5122-313273af-454445555731-d1a4bae7f8df6c62&q=1&e=34acaa9f-0b9d-40be-bee3-46b3f739f9f0&u=https%3A%2F%2Fgithub.com%2Fcbor-wg%2Fcbor-magic-number%2Fpull%2F21
> 
> under the commit
> https://protect2.fireeye.com/v1/url?k=31323334-501d5122-313273af-454445555731-f7d360b0402b146d&q=1&e=34acaa9f-0b9d-40be-bee3-46b3f739f9f0&u=https%3A%2F%2Fgithub.com%2Fcbor-wg%2Fcbor-magic-number%2Fpull%2F21%2Fcommits%2Fc2fa2d2
> 
> Grüße, Carsten
> 
> 
> […]
>> 
>> The document, along with other ballot positions, can be found here:
>> https://datatracker.ietf.org/doc/draft-ietf-cbor-file-magic/
>> 
>> 
>> 
>> ----------------------------------------------------------------------
>> COMMENT:
>> ----------------------------------------------------------------------
>> 
>> Thanks for working on this document. I kind of like the question/answer style
>> of writing the document.
>> 
>> Some comments/questions below, and I think addressing them would help improving
>> the document.
>> 
>> - Section 2.1: it say's
>> 
>>     This tag needs to be allocated by the author of the CBOR Protocol
>> 
>>  it was not clear to me if "this tag" is the same tag that needs IANA
>>  registration or not. It needs some clarification text on that.
> 
> Well, the whole Section is about the "The CBOR Protocol Specific Tag”.
> 
> I clarified this into:
> 
>>> Allocation of the CBOR tag needs to be initiated by the author of the CBOR
>>> Protocol, who can provide a proposed tag number.
Here you mean IANA allocation of CBOR  tag, right?
> 
> 
>> 
>> - file(1) is both referred as command and program, I always thought it is a
>> command.
> 
> It is a command that is, like the vast majority of UNIX shell commands, implemented by a program (which is usually stored in /usr/bin).
> But we can be consistent here (always calling it a command).
OK
> 
>> - Section 3.2: I didn't get the proper motivation for this section in this
>> document. There were no mention of other CBOR data items and certainly they
>> become the center piece in this section. I think it would be great to add some
>> text about the motivation.
> 
> See Michael’s response.
Not sure Michael responses to this comment of mine.
> In UNIX, many file formats can be concatenated by “cat”, so the resulting occurrence of mid-sequence labels is not an unusual consideration.
Would be nice to write one line about it in the section.
> 
>> - Speaking very frankly I feel like section 3.1 and section 3.2 are not the
>> center part of this specification and should be moved to appendix section.
> 
> (See Michael’s response.)
Saw that, and responding here.

If you agree that section 3.1 and 3.2 it not the core part of this specification then it can be moved to appendix. I think the hanging text in section 3 is good enough, 3.3 can be merger in shorter form and point to 3.1, 3.2 in the appendix as “FYI”. I however, do consider this is a matter of taste to some extend and if you feel strongly against this change, then I am fine.

//Zahed