[Cbor] Malformed tag example for RFC 7049bis Appendix G.1.

Faye Amacker <faye.github@gmail.com> Thu, 05 December 2019 02:40 UTC

Return-Path: <faye.github@gmail.com>
X-Original-To: cbor@ietfa.amsl.com
Delivered-To: cbor@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5F0FA120043 for <cbor@ietfa.amsl.com>; Wed, 4 Dec 2019 18:40:21 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id booPelGZsfFN for <cbor@ietfa.amsl.com>; Wed, 4 Dec 2019 18:40:18 -0800 (PST)
Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 578A312018B for <cbor@ietf.org>; Wed, 4 Dec 2019 18:40:18 -0800 (PST)
Received: by mail-qk1-x733.google.com with SMTP id m188so2056475qkc.4 for <cbor@ietf.org>; Wed, 04 Dec 2019 18:40:18 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=O2xP58CNaioKCs2tOqX1PVhiMVmKaaSTQMfjkWB7iIw=; b=o3grKHopoKZmYWyHO5RbUXO5g+kRyhgnZLoaWsj9SoEhtr6pjsowXbuPFg+pfs1pdH ls9061vIQrYkDFw3IrnF0TILunX0eHM7/qa+2Vrl4ro2qpI6xva3/R+yHWyuV1Oyff8u H7zKpSRUMzc4ytko/9DLpf8YoX+ARSE5j/XQxE3jmfQptW/ixPoR9wH4bnSCGX1unPzx 8ERTzhIoJEbTiC7YSDn7RAuNXUxxVzenvtqH1QUtLU/VTy0lsEQ6V6k5CXl0vUy0eyHd xM6xioqQ6fm42Kmcuw60xvP/YlTaaXlF7r8101mUiUhwU6Mjz7CBahvs+bH1fHXd1Qeh 9+RA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=O2xP58CNaioKCs2tOqX1PVhiMVmKaaSTQMfjkWB7iIw=; b=pYb1VKFpuhEQnE/G1YoWQ2oMSX+1tVpOWSLfv5cJNfG91aW5HhdEgPt0bSgUXDe4WL cqixewNtF2rwugrYHJjd3QOyQ/zCEolG/RBLt2RifkTxmTcusY3U2vUCZBSZORHX3ccd IGoHbvh1k+NVweCSvKpxMbi7GmPjt3mqkNnYcCu5jVuvIrxvGbSnDIUAoCc/R9oDJ4Qg LWSG+d1EZzbPSiA5PsEUNJCS67TaF2MxCcucIRWG2YkMbwnlmQh7r4qT0ul7JFG1AJ9c ArMWYhBe3KbVvOBlZ/TE+8sJDHGmkQxH+7lV19Bj/mXOoTpu9izCZS5C6dHJ77uaLpT9 wj6A==
X-Gm-Message-State: APjAAAWZtku0TSautrepv0vYxLbMC3yROVKgFLr8ei8H72zhW/WdSuB1 05xYv2L6Kj37WzrL8hc6tgqt9Z+1jY3XkmxAxPVeu0UB
X-Google-Smtp-Source: APXvYqzFdDbzLa9NgpF8bSsyUhbnDYKzLRVqJeKvj2BiisPnDQs8eshbiNXwMtDcQzqVAfnTCbM1whHJaDyHD8+TTpc=
X-Received: by 2002:a05:620a:1358:: with SMTP id c24mr6392447qkl.285.1575513617264; Wed, 04 Dec 2019 18:40:17 -0800 (PST)
MIME-Version: 1.0
From: Faye Amacker <faye.github@gmail.com>
Date: Wed, 04 Dec 2019 20:40:05 -0600
Message-ID: <CA+qCGhvsyOTUAstBm30_qg9Cf2O9-pFdLJMYD=pjG5VqaFo-fg@mail.gmail.com>
To: cbor@ietf.org
Content-Type: multipart/alternative; boundary="0000000000007ef5330598ebd9cc"
Archived-At: <https://mailarchive.ietf.org/arch/msg/cbor/YTU2VrlTVb50kCFhJsCbltf3i1U>
Subject: [Cbor] Malformed tag example for RFC 7049bis Appendix G.1.
X-BeenThere: cbor@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Concise Binary Object Representation \(CBOR\)" <cbor.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cbor>, <mailto:cbor-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cbor/>
List-Post: <mailto:cbor@ietf.org>
List-Help: <mailto:cbor-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cbor>, <mailto:cbor-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Dec 2019 04:34:15 -0000

Tag numbers must be followed by tag content.  I think an example of this
could make it more obvious to CBOR library authors.

Please add an example of malformed tag to RFC 7049bis Appendix G.1:

   * Definite length maps ...
+ * Tag number not followed by tag content: C0
   * Indefinite length strings ...

My pull request for this one-line addition is at:
https://github.com/cbor-wg/CBORbis/pull/146

BTW, I finished reading 7049bis and really appreciate the improvements. I
added many new unit tests to my CBOR library based on Appendix G.  And I'm
also finding 7049bis more helpful while implementing support for tags.