Re: [Cbor] changes to draft-ietf-cbor-network-addresses-01.txt

Michael Richardson <mcr+ietf@sandelman.ca> Tue, 09 March 2021 14:44 UTC

Return-Path: <mcr+ietf@sandelman.ca>
X-Original-To: cbor@ietfa.amsl.com
Delivered-To: cbor@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 14E873A0E4A for <cbor@ietfa.amsl.com>; Tue, 9 Mar 2021 06:44:39 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e3ho3M-1KJ0q for <cbor@ietfa.amsl.com>; Tue, 9 Mar 2021 06:44:36 -0800 (PST)
Received: from tuna.sandelman.ca (tuna.sandelman.ca [IPv6:2607:f0b0:f:3:216:3eff:fe7c:d1f3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 67F193A0E4D for <cbor@ietf.org>; Tue, 9 Mar 2021 06:44:36 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by tuna.sandelman.ca (Postfix) with ESMTP id 0BA11389B2 for <cbor@ietf.org>; Tue, 9 Mar 2021 09:49:34 -0500 (EST)
Received: from tuna.sandelman.ca ([127.0.0.1]) by localhost (localhost [127.0.0.1]) (amavisd-new, port 10024) with LMTP id PQNw81F0rRxh for <cbor@ietf.org>; Tue, 9 Mar 2021 09:49:33 -0500 (EST)
Received: from sandelman.ca (obiwan.sandelman.ca [IPv6:2607:f0b0:f:2::247]) by tuna.sandelman.ca (Postfix) with ESMTP id 59A0F389AF for <cbor@ietf.org>; Tue, 9 Mar 2021 09:49:33 -0500 (EST)
Received: from localhost (localhost [IPv6:::1]) by sandelman.ca (Postfix) with ESMTP id 2EBAF909 for <cbor@ietf.org>; Tue, 9 Mar 2021 09:44:33 -0500 (EST)
From: Michael Richardson <mcr+ietf@sandelman.ca>
To: cbor@ietf.org
In-Reply-To: <EDD97469-5F4F-4182-A81C-ABAE2D86F075@tzi.org>
References: <161266446471.542.2418789735601546566@ietfa.amsl.com> <a15c4d67-e67f-c210-0477-29564c2b67e0@gmail.com> <30430.1615160268@localhost> <EDD97469-5F4F-4182-A81C-ABAE2D86F075@tzi.org>
X-Mailer: MH-E 8.6+git; nmh 1.7+dev; GNU Emacs 26.1
X-Face: $\n1pF)h^`}$H>Hk{L"x@)JS7<%Az}5RyS@k9X%29-lHB$Ti.V>2bi.~ehC0; <'$9xN5Ub# z!G,p`nR&p7Fz@^UXIn156S8.~^@MJ*mMsD7=QFeq%AL4m<nPbLgmtKK-5dC@#:k
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature"
Date: Tue, 09 Mar 2021 09:44:33 -0500
Message-ID: <23184.1615301073@localhost>
Archived-At: <https://mailarchive.ietf.org/arch/msg/cbor/e2LJfFyPS38_q5WIhRN7i6c7UpA>
Subject: Re: [Cbor] changes to draft-ietf-cbor-network-addresses-01.txt
X-BeenThere: cbor@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Concise Binary Object Representation \(CBOR\)" <cbor.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cbor>, <mailto:cbor-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cbor/>
List-Post: <mailto:cbor@ietf.org>
List-Help: <mailto:cbor-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cbor>, <mailto:cbor-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Mar 2021 14:44:39 -0000

Carsten Bormann <cabo@tzi.org> wrote:
    > I think prefixes and addresses are completely separate use cases.

    > There is rarely a point in suppressing trailing zeroes in an address.
    > We shouldn’t burden implementations to cater to this 0.4 % case
    > (probably less in practice).

okay.  I will take this constructive criticism and edit as you suggest.
When the byte-string is short, is it invalid then?

    > (The /24 IPv4 example in the draft is wrong.)

In that it has a non-zero value after the prefix length?
Yes, a copy&paste goof.

I have posted -02 just now.

https://www.ietf.org/rfcdiff?url2=draft-ietf-cbor-network-addresses-02

I guess I need to change the encoder and decoder considerations a bit more.

--
Michael Richardson <mcr+IETF@sandelman.ca>   . o O ( IPv6 IøT consulting )
           Sandelman Software Works Inc, Ottawa and Worldwide