IETF Logo Mail Archive

[Cbor] Re: draft-ietf-cbor-edn-literals-10 implementation notes

Carsten Bormann <cabo@tzi.org> Sat, 17 August 2024 12:56 UTC

Return-Path: <cabo@tzi.org>
X-Original-To: cbor@ietfa.amsl.com
Delivered-To: cbor@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2E863C15106B for <cbor@ietfa.amsl.com>; Sat, 17 Aug 2024 05:56:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.209
X-Spam-Level:
X-Spam-Status: No, score=-4.209 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xtR0qQlneeRz for <cbor@ietfa.amsl.com>; Sat, 17 Aug 2024 05:56:29 -0700 (PDT)
Received: from smtp.zfn.uni-bremen.de (smtp.zfn.uni-bremen.de [134.102.50.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 739F0C14F6B0 for <cbor@ietf.org>; Sat, 17 Aug 2024 05:56:28 -0700 (PDT)
Received: from clients-pool1-0074.vpn.uni-bremen.de (clients-pool1-0074.vpn.uni-bremen.de [134.102.107.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.zfn.uni-bremen.de (Postfix) with ESMTPSA id 4WmJlF427FzDCg9; Sat, 17 Aug 2024 14:56:25 +0200 (CEST)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
From: Carsten Bormann <cabo@tzi.org>
In-Reply-To: <4DDB6F09-D038-4A13-80F3-A4C13F3EF529@tzi.org>
Date: Sat, 17 Aug 2024 14:56:25 +0200
X-Mao-Original-Outgoing-Id: 745592185.199348-209e177dc7fdd04f08fb5cd97a7cb712
Content-Transfer-Encoding: quoted-printable
Message-Id: <219DCF2B-EBA4-4C28-9B40-4AA57F79AC33@tzi.org>
References: <FFD7DB6F-2313-4A64-B434-110B1C524D0C@cursive.net> <4DDB6F09-D038-4A13-80F3-A4C13F3EF529@tzi.org>
To: Joe Hildebrand <hildjj@cursive.net>
X-Mailer: Apple Mail (2.3608.120.23.2.7)
Message-ID-Hash: TJE5BDMZJBAJS57SGKLHH3FWAXWV2QFY
X-Message-ID-Hash: TJE5BDMZJBAJS57SGKLHH3FWAXWV2QFY
X-MailFrom: cabo@tzi.org
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-cbor.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: CBOR <cbor@ietf.org>
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [Cbor] Re: draft-ietf-cbor-edn-literals-10 implementation notes
List-Id: "Concise Binary Object Representation (CBOR)" <cbor.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/cbor/fU2BzADzS73JwXmB8s9FV7lvsJ8>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cbor>
List-Help: <mailto:cbor-request@ietf.org?subject=help>
List-Owner: <mailto:cbor-owner@ietf.org>
List-Post: <mailto:cbor@ietf.org>
List-Subscribe: <mailto:cbor-join@ietf.org>
List-Unsubscribe: <mailto:cbor-leave@ietf.org>

On 2024-08-17, at 13:40, Carsten Bormann <cabo@tzi.org> wrote:
> 
>> - (nit) I'd prefer basenumber to be split into 3 or 4 rules, one for each base, since each needs special processing.
> 
> I personally like the more compact way, but I’ll put up a change proposal in a PR.

https://github.com/cbor-wg/edn-literal/pull/59

Grüße, Carsten

v2.28.0 | Report a Bug | By Email | System Status