Re: [Cbor] 🔔 WGLC on draft-ietf-cbor-tags-oid-02

[Francesca Palombini <[e-mail]>]

Thanks Carsten, it looks good! Please upload v-04 with these changes.

Francesca

On 15/01/2021, 22:07, "Carsten Bormann" <[e-mail]> wrote:

    Hi Francesca,

    thank you for this review. 

    > * I am not sure (and please correct me if I am wrong!) there ever was a conclusion to Jim's comment about not seeing the necessity of going below one layer for maps and arrays: https://mailarchive.ietf.org/arch/msg/cbor/5lj35zvO85Yu2tVO_Fw__KWLadc/  - this was discussed at an interim: https://datatracker.ietf.org/meeting/interim-2020-cbor-14/materials/minutes-interim-2020-cbor-14-202009021700-00.txt  And I see the text Jim referred to was clarified, but as shepherd I'd like to see more opinions on this point: anybody else seeing a problem with Carsten's point of "if you don't need all bstr tagged, don't use the tag on the map/array" ? Anybody agrees with Jim and would rather this being a 1-level tag?

    I haven’t seen support for this, so I consider this a wontfix.

    > 
    > * Update references to RFC 8949

    Done.

    (Note that we have a downref to RFC 6256 SDNV; I wonder why that isn’t in the downref list https://datatracker.ietf.org/doc/downref/ .)

    > * normative references X.660, X.680 and X.690 are missing links

    Ugh.  
    I didn’t want to innovate here, but RFC 8951 has (inconsistent) ones to X.68x (why is the X.680 one different from the others?).

    I went with:
    https://www.itu.int/rec/T-REC-X.660
    https://www.itu.int/rec/T-REC-X.680
    https://www.itu.int/rec/T-REC-X.690

    (Wow, the last bib entry for X.660 was in RFC 5280!)

    > * add a reference to IANA PEN registry

    Done.

    > "the first byte of each SDNV cannot be 0x80 (which would be a
    >   leading zero in SDNV's base-128 arithmetic)."
    > 
    > "this requirement requires
    >      expressing the integer values in their shortest form, with no
    >      leading zeroes"
    > 
    > * I would suggest reversing this sentence: "the first byte cannot be a leading zero in SDNV's base-128 arithmetic, so it cannot take value 0x80", possibly mentioning the requirement on the integer values being expressed in their shortest form. By the way, does this requirement comes from BER OID rules? Can you add some reference to where this is specified?

    RFC 6256 says “Section 8.1.2.4.2 of X.690”, which contains the bullet:

    c) bits 7 to 1 of the first subsequent octet shall not all be zero.

    Reference added.

    > "except for the last byte, where it must be
    >   unset" 
    > 
    > * either replace "must" with "is" or with "MUST" (I would suggest is, because the normative MUST before covers the requirement already)

    “is” it is.

    > 
    > "its first byte" and "its last byte" 
    > 
    > * I would replace "its" by "the tag's" for clarity.

    “the byte string’s", actually.  Done.

    > * It seems to me that this document could benefit from a more expanded terminology section. In particular, I would quickly summarize the terms used from X.690 - e.g. arc - and SDNV.

    Well, I put this in the “Object Identifier” section:

    We also use the term "arc" when the focus is on the edge of the tree
    labeled by such an integer value, as well as in the sense of a "long
    arc", i.e. a (sub)sequence of such integer values.)

    The terminology of X.660 is really confused (they try to maintain the illusion the edges are labeled by Unicode strings), so this is probably the best we can do.

    I also added a pointer to RFC 6256 in the terminology section.

    > * Some introductory text for the examples in Section 3 would have been good.

    I added a sentence.

    > * I am a bit unsure about the reasoning behind section 4 "Discussion". Is this not background? Then in my opinion it would fit better in section 2.

    I moved it so it is now section 2.2 (initiating some renumbering of sections).

    > * I would have merged section 3 and 6 in one section “Examples”

    I moved what was Section 6 to a Section 4.1, titled:

    4.1.  Tag factoring example: X.500 Distinguished Name

    Separating the basic usage examples (now Section 2.2) and the tag factoring usage example (now Section 4.1) probably helps the user.  If you insist, we can of course reorder and merge back.

    			.oOo.

    Thank you again, I think the document is better now…

    I have made the updated version available at https://protect2.fireeye.com/v1/url?k=ec06175c-b39d2e5e-ec0657c7-869a14f4b08c-beba7de442b69289&q=1&e=77373f56-00e1-459f-99c9-b4227b5b0846&u=https%3A%2F%2Fgithub.com%2Fcbor-wg%2Fcbor-oid (pregenerated HTML at https://raw.githack.com/cbor-wg/cbor-oid/master/draft-ietf-cbor-tags-oid.html as indicated in the README; diff at https://tools.ietf.org/rfcdiff?url1=draft-ietf-cbor-tags-oid&url2=https://raw.githack.com/cbor-wg/cbor-oid/master/draft-ietf-cbor-tags-oid.txt in rfcdiff format).

    The plan is to submit -04 after a quick re-check of these updates.

    Grüße, Carsten