[Cbor] Iotdir telechat review of draft-ietf-cbor-tags-oid-06

Ines Robles via Datatracker <noreply@ietf.org> Tue, 06 April 2021 16:21 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: cbor@ietf.org
Delivered-To: cbor@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id A5B6B3A274D; Tue, 6 Apr 2021 09:21:09 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Ines Robles via Datatracker <noreply@ietf.org>
To: iot-directorate@ietf.org
Cc: cbor@ietf.org, draft-ietf-cbor-tags-oid.all@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.27.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <161772606961.13833.6830636143413776698@ietfa.amsl.com>
Reply-To: Ines Robles <mariainesrobles@googlemail.com>
Date: Tue, 06 Apr 2021 09:21:09 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/cbor/xtXQBYMB0UDnFV5rLFHebeda-tw>
Subject: [Cbor] Iotdir telechat review of draft-ietf-cbor-tags-oid-06
X-BeenThere: cbor@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "Concise Binary Object Representation \(CBOR\)" <cbor.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cbor>, <mailto:cbor-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cbor/>
List-Post: <mailto:cbor@ietf.org>
List-Help: <mailto:cbor-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cbor>, <mailto:cbor-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2021 16:21:10 -0000

Reviewer: Ines Robles
Review result: Ready with Nits


The document defines CBOR tags for object identifiers (OIDs).  The document is
well written.

Few minor questions/comments.

Major Issues: None

Minor Issues: None


- It would be nice to expand SDNV in section 1.1 instead of Section 2.

- Section 3.2 - Figure 4-MIB relative object identifier in CBOR:

0b010_01001 should be 0b010_00011 ? for major type 2, additional information 3

- Section 7.1:

 -- In order to mention the registry, maybe smth like

  to assign the CBOR tags --> to assign in the CBOR tags registry the following

 -- It would be nice to have the table with the same structure as the registry
 table (add reference column like in Section 7.2), I think template column does
 not apply here.

- Section 7.2:

-- In order to mention the registry, maybe smth similar as Section 7.1?

Thank you for this document,