Re: [CCAMP] Last Call: <draft-ietf-ccamp-layer0-types-06.txt> (A YANG Data Model for Layer 0 Types) to Proposed Standard

Zhenghaomian <zhenghaomian@huawei.com> Tue, 22 September 2020 04:06 UTC

Return-Path: <zhenghaomian@huawei.com>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B80A43A13F6; Mon, 21 Sep 2020 21:06:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ltsMaASktIVc; Mon, 21 Sep 2020 21:06:07 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 76DD93A155F; Mon, 21 Sep 2020 21:05:26 -0700 (PDT)
Received: from lhreml729-chm.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id 2B1F488C63B4BC4475B2; Tue, 22 Sep 2020 05:05:25 +0100 (IST)
Received: from lhreml729-chm.china.huawei.com (10.201.108.80) by lhreml729-chm.china.huawei.com (10.201.108.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Tue, 22 Sep 2020 05:05:25 +0100
Received: from DGGEML422-HUB.china.huawei.com (10.1.199.39) by lhreml729-chm.china.huawei.com (10.201.108.80) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.1.1913.5 via Frontend Transport; Tue, 22 Sep 2020 05:05:24 +0100
Received: from DGGEML511-MBX.china.huawei.com ([169.254.1.148]) by dggeml422-hub.china.huawei.com ([10.1.199.39]) with mapi id 14.03.0487.000; Tue, 22 Sep 2020 12:05:12 +0800
From: Zhenghaomian <zhenghaomian@huawei.com>
To: tom petch <daedulus@btconnect.com>
CC: "ccamp@ietf.org" <ccamp@ietf.org>, "ccamp-chairs@ietf.org" <ccamp-chairs@ietf.org>, Daniele Ceccarelli <daniele.ceccarelli@ericsson.com>, "db3546@att.com" <db3546@att.com>, "draft-ietf-ccamp-layer0-types@ietf.org" <draft-ietf-ccamp-layer0-types@ietf.org>
Thread-Topic: Last Call: <draft-ietf-ccamp-layer0-types-06.txt> (A YANG Data Model for Layer 0 Types) to Proposed Standard
Thread-Index: AdaQlXLis1tC4bI9Sq6ddt5vp62uKg==
Date: Tue, 22 Sep 2020 04:05:12 +0000
Message-ID: <E0C26CAA2504C84093A49B2CAC3261A43F97A870@dggeml511-mbx.china.huawei.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.24.176.178]
Content-Type: text/plain; charset="gb2312"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/ccamp/0tm0c13Si9S--JWCl8fkNuKKO_w>
Subject: Re: [CCAMP] Last Call: <draft-ietf-ccamp-layer0-types-06.txt> (A YANG Data Model for Layer 0 Types) to Proposed Standard
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Sep 2020 04:06:15 -0000

Hi Tom, 

Thank you for the valuable comments, again. We have updated the draft to address them, please find the draft-ietf-ccamp-layer0-types-07 and draft-ietf-ccamp-wson-yang-26. 

BTW, there will be a ccamp interim session on Sept 23rd, and you are more than welcome to join:)

Best wishes,
Haomian

-----邮件原件-----
发件人: tom petch [mailto:daedulus@btconnect.com] 
发送时间: 2020年9月19日 0:14
收件人: The IESG <iesg-secretary@ietf.org>
抄送: ccamp@ietf.org; ccamp-chairs@ietf.org; Daniele Ceccarelli <daniele.ceccarelli@ericsson.com>om>; db3546@att.com; draft-ietf-ccamp-layer0-types@ietf.org
主题: Re: Last Call: <draft-ietf-ccamp-layer0-types-06.txt> (A YANG Data Model for Layer 0 Types) to Proposed Standard

The YANG module references RFC4203, RFC7699 and G.694.2 but the I-D does not so these need adding. I note that the other references from the YANG are all Informative which seems to me debatable.

grouping wson-label-start-end is introduced as 'A YANG grouping that defines the label-start and label-end'
which leads me to expect two leaf but there is only one; the YANG description is "The WSON label-start or label-end ...
which seems more accurate but since the grouping is a choice of cwdm or dwdm could it find uses which are neither start nor end in which case a different name would be even more appropriate?

grouping flexi-grid-label-start-end is introduced as 'A YANG grouping that defines the label-start and label-end '
and again there is only one leaf; the YANG description is "Label-start and Label-end information for Flexi-grid."
which seems equally inappropriate.  I cannot see any uses of this grouping - I note that draft-ietf-ccamp-flexigrid-yang has not been updated to match this I-D - and since it is but one leaf, not even a choice, I wonder why it warrants a grouping with the increased difficulty of comprehension that groupings introduce.

leaf min-slot-width-factor {type uint16 {range "1..max";}
            default 1;
leaf max-slot-width-factor {type uint16 {range "1..max"; but with no default. Worth a YANG conditional perhaps for max>min or
max>=min as appropriate.  Can they be equal?  the equal ranges imply so
but has it any particular meaning?

I wonder how often l0 will be construed as ten or ell-oh with an attendant error!

Tom Petch


----- Original Message -----
From: "The IESG" <iesg-secretary@ietf.org>
To: "IETF-Announce" <ietf-announce@ietf.org>
Cc: <ccamp@ietf.org>rg>; <ccamp-chairs@ietf.org>rg>; "Daniele Ceccarelli"
<daniele.ceccarelli@ericsson.com>om>; <db3546@att.com>om>; <draft-ietf-ccamp-layer0-types@ietf.org>
Sent: Wednesday, September 16, 2020 9:44 PM
Subject: Last Call: <draft-ietf-ccamp-layer0-types-06.txt> (A YANG Data Model for Layer 0 Types) to Proposed Standard


> The IESG has received a request from the Common Control and
Measurement Plane
> WG (ccamp) to consider the following document: - 'A YANG Data Model
for Layer
> 0 Types'
>   <draft-ietf-ccamp-layer0-types-06.txt> as Proposed Standard
>
> The IESG plans to make a decision in the next few weeks, and solicits
final
> comments on this action. Please send substantive comments to the 
> last-call@ietf.org mailing lists by 2020-09-30. Exceptionally,
comments may
> be sent to iesg@ietf.org instead. In either case, please retain the
beginning
> of the Subject line to allow automated sorting.
>
>