[CCAMP] Review comments for ietf-l1csm YANG model

Italo Busi <Italo.Busi@huawei.com> Tue, 12 May 2020 15:58 UTC

Return-Path: <Italo.Busi@huawei.com>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A305F3A0B96 for <ccamp@ietfa.amsl.com>; Tue, 12 May 2020 08:58:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 1.102
X-Spam-Level: *
X-Spam-Status: No, score=1.102 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HEXHASH_WORD=2.999, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BvnIwq3GXS6F for <ccamp@ietfa.amsl.com>; Tue, 12 May 2020 08:58:46 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8A6AD3A0B95 for <ccamp@ietf.org>; Tue, 12 May 2020 08:58:45 -0700 (PDT)
Received: from lhreml743-chm.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id 9A4CEE37FB26B2F350D2 for <ccamp@ietf.org>; Tue, 12 May 2020 16:58:40 +0100 (IST)
Received: from fraeml711-chm.china.huawei.com (10.206.15.60) by lhreml743-chm.china.huawei.com (10.201.108.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Tue, 12 May 2020 16:58:40 +0100
Received: from fraeml715-chm.china.huawei.com (10.206.15.34) by fraeml711-chm.china.huawei.com (10.206.15.60) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Tue, 12 May 2020 17:58:39 +0200
Received: from fraeml715-chm.china.huawei.com ([10.206.15.34]) by fraeml715-chm.china.huawei.com ([10.206.15.34]) with mapi id 15.01.1913.007; Tue, 12 May 2020 17:58:39 +0200
From: Italo Busi <Italo.Busi@huawei.com>
To: "ccamp@ietf.org" <ccamp@ietf.org>
Thread-Topic: Review comments for ietf-l1csm YANG model
Thread-Index: AdYodRg3bPUCS3LLQLWjkDpgsiMOuw==
Date: Tue, 12 May 2020 15:58:39 +0000
Message-ID: <a436794a56b344cfb65b95ee8fdef426@huawei.com>
Accept-Language: it-IT, en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-originating-ip: [10.47.24.102]
Content-Type: multipart/related; boundary="_004_a436794a56b344cfb65b95ee8fdef426huaweicom_"; type="multipart/alternative"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/ccamp/2eH69nxLVBABXhmqZwNKDoK3EGw>
Subject: [CCAMP] Review comments for ietf-l1csm YANG model
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 12 May 2020 15:58:48 -0000

Hi all,

I have reviewed the ietf-l1csm YANG model in draft-ietf-ccamp-l1csm-yang-11 and I have some comments which may have an impact also on layer1-types YANG model (which has already gone through WG LC):


1)      The protocol attribute, as defined in MEF 63, is not the same as the client-signal in layer1-types. The protocol can assume only one of these values: Ethernet, Fibre Channel, SDH or SONET.



2)      The coding-function attribute, as defined in MEF 63, is almost equivalent to the client-signal.

For example, STM-1 can be used either as client-signal or as a coding-function.

However, there are some client-signals, defined by ITU-T G.709, which are not defined by MEF 63 as coding-function.
For example, FICON-4G is defined as a client-signal in ITU-T but not corresponding coding functions are defined in MEF 63.

There are also cases where the client-signal and the coding-function uses different names.
For example, the ETH-1Gb client-signal and the ETH-1000X coding-function are using different names to represent the same client-signal/coding-function.


3)      According to MEF63, the configuration of the protocol, coding-function and optical-interface-functions attributes should be consistent: see Tables 4, 5, 6 and 7 of MEF63



It would be good if we can capture these constraints in the YANG model



4)      According to MEF63, the protocol, coding-function and optical-interface-function attributes are mandatory. Therefore the corresponding leaves could not be optional in YANG



5)      The current YANG model allows requesting L1CSM only when the UNIs support a <protocol, coding-function, optical-interface-function> defined in MEF63



It would still be worthwhile being able to request L1CSM also when the UNIs support a client-signal defined by ITU-T G.709 for which MEF has not yet defined/assigned a <protocol, coding-function, optical-interface-function>



6)      It is the only YANG model using the service-performance-metric identities defined in layer1-types, which are aligned with MEF definitions



To avoid any potential issues with the PM metrics to be defined in other YANG model, it is better to move to this model to the service-performance-metric identities from layer1-types

Comments 2), 3) and 5) would impact also the layer1-types YANG model

These comments are also tracked on github:

https://github.com/haomianzheng/IETF-ACTN-YANG-Model/issues/64

Initial thoughts for resolving this comments are also tracked on github as work-in-progress:

https://github.com/haomianzheng/IETF-ACTN-YANG-Model/pull/65

Thanks, Italo

Italo Busi
Principal Optical Transport Network Research Engineer

[cid:image001.jpg@01D5AC11.9575BB40]
____________________________________________________________________

Huawei Technologies Italia S.r.l.
Address: Centro Direzionale Milano 2, Palazzo Verrocchio, 20090 Segrate (MI)
Tel: +39 345 4721946 - Mobile: Italo.busi@huawei.com<mailto:Italo.busi@huawei.com>

__________________________________________________________________________________
Huawei Technologies Italia S.r.l. is a company registered in Italy at the Company Registration Office of Milan, with registered number 04501190963 and equity capital €3,000,000 fully paid up, whose registered office is in Milan, Via Lorenteggio 240, Tower A, 20147 Milan, Italy. Huawei Technologies Italia S.r.l. is 100% owned by Huawei Technologies Cooperatief U.A.
CONAI Reg. No. cc 12639454 - A.E.E. Registry No. IT10010000006521 - Batteries and Accumulators Registry No. IT12050P00002839.
________________________________________________________________________________________________________________________
This e-mail and its attachments contain confidential information from HUAWEI, which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it! Thank you.
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PRIVACY NOTICE: Pursuant to Art. 13 of the General Data Protection Regulation 2016/679 (GDPR), Huawei Technologies Italia S.r.l. informs you that the personal data contained in this email will be collected and treated for the acquisition of information preliminary to the conclusion of contracts, for the definition of the contractual relationship, as well as for the fulfillment of legal requirements related to civil, tax and accounting law or any other legal obligation to which Huawei may be subject. Personal data will not be subject to disclosure and spread unless otherwise required by law. Huawei will take appropriate security measures to protect personal data against loss, misuse disclosure or destruction of the information. Personal Data held may be transferred to countries outside the European Union, however Huawei Italia has put in place appropriate safeguards for the transfer of personal data to third countries by adopting the standard data protection clauses of the EU Commission. Personal Data are kept for a period necessary for the fulfillment of contract obligations unless otherwise required by law. You can exercise your rights under Art. 15 and following of the GDPR (i.e. right of access, rectification, erasure, restriction, portability, object) by contacting Huawei at this email address: dataprotection@huawei.com<mailto:dataprotection@huawei.com> or through the following channel: www.huawei.com/en/personal-data-request<http://www.huawei.com/en/personal-data-request>st>. You have also the right to lodge a complaint with the competent supervisory authorities. If you need any further information or have any queries on how Huawei process your personal data, please send an email to our Data Protection Officer at dpo@huawei.com<mailto:dpo@huawei.com>.The Data Controller is Huawei Technologies Italia S.r.l. with registered office in Milan, Via Lorenteggio 240 Tower A, 20147.