[CCAMP] Yangdoctors last call review of draft-ietf-ccamp-otn-topo-yang-11

Radek Krejčí via Datatracker <noreply@ietf.org> Fri, 16 October 2020 13:33 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: ccamp@ietf.org
Delivered-To: ccamp@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 7729E3A0F62; Fri, 16 Oct 2020 06:33:27 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: =?utf-8?q?Radek_Krej=C4=8D=C3=AD_via_Datatracker?= <noreply@ietf.org>
To: <yang-doctors@ietf.org>
Cc: ccamp@ietf.org, draft-ietf-ccamp-otn-topo-yang.all@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.20.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <160285520741.9529.9792873960297912479@ietfa.amsl.com>
Reply-To: =?utf-8?b?UmFkZWsgS3JlasSNw60=?= <rkrejci@cesnet.cz>
Date: Fri, 16 Oct 2020 06:33:27 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/ccamp/CqHx1813l9OfKkA_6ijZ5E_zlvs>
Subject: [CCAMP] Yangdoctors last call review of draft-ietf-ccamp-otn-topo-yang-11
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Oct 2020 13:33:28 -0000

Reviewer: Radek Krejčí
Review result: Ready with Issues

This is my yang doctor review of draft draft-ietf-ccamp-otn-topo-yang-11 with
the ietf-otn-topology@2020-09-21 YANG module.

Despite the size of the module, its structure is very simple repeatedly
following a pattern of augmenting ietf-te-topology by groupings defined in
ietf-layer1-types module.

Datatracker's validation with yanglint reports a number of warnings, but they
are false positive (fixed in yanglint 1.9.16 - the fixed version still reports
warnings, but they are all from the imported ietf-layer1-type module).

My only note to the module itself is about the two defined groupings - I'm not
sure about the reusability of the groupings in other modules. If the
reusability is not the concern, I don't see any reason to define them.

Regarding the draft, as a reader, I would appreciate a more targeted
description in section 3. Instead of just dumping the tree diagram in section
3.2, it would be useful to split it into several areas with some brief
descriptions and examples.

The list of paths is introduced in Section 6 as "the subtrees and data nodes
and their sensitivity/vulnerability", but I don't see explained/described the
mentioned sensitivity/vulnerability of those paths.

The prefix of the YANG module (also referred to in Section 7 ) - 'otntopo' -
seems inconsistent to me. The relevant ietf-te-topology has 'tet' (so I would
expect 'otnt' here), on the other hand, the ietf-otn-tunnel has 'otn-tunnel'
prefix (then I would expect 'otn-topo' prefix here). The 'otntopo' seems to
introduce just another format. As a reader/user, I would prefer if the modules
from a common group could use some common and obvious rules for prefixes.