Re: [CCAMP] Warren Kumari's No Objection on draft-ietf-ccamp-alarm-module-08: (with COMMENT)

stefan vallin <stefan@wallan.se> Tue, 09 April 2019 12:27 UTC

Return-Path: <stefan@wallan.se>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BFBF91207C4 for <ccamp@ietfa.amsl.com>; Tue, 9 Apr 2019 05:27:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=wallan-se.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tBTC9sJ92B8X for <ccamp@ietfa.amsl.com>; Tue, 9 Apr 2019 05:27:30 -0700 (PDT)
Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BD6041207CB for <ccamp@ietf.org>; Tue, 9 Apr 2019 05:27:26 -0700 (PDT)
Received: by mail-lj1-x230.google.com with SMTP id f23so14315439ljc.0 for <ccamp@ietf.org>; Tue, 09 Apr 2019 05:27:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wallan-se.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=SYRdSR83pRoiadB56rd54QjS8i5q7fm54uFKjpYd5fE=; b=TPoIXBAt82BXG2pUeX3OjhJCfcSJQQpPxHoVKuf0QCz0i+yW42sJMBj8Bwmo4fXXsV iQnlK+tXHWbot8VhYJQ+yqK1R3oNYAOpXH5pcy1NF4j585gqYjE1XoavLAwryafoT5cA snXEePV9Ez4+82mD4fQ2+JCMEzIxhXa/dRTBOXa+qbsokubWVakoCKMnCdm+YUbSHxUS EYibETs6wdi6TFnytp9T0Wbl6WsjkxIjjnZpghaPetL2VnosHdLvxWYxcl9th1keJzbR eULYyc+VD83FwmkHn5GnK+y1L7iuB/Ov1ShXKHbN1Uo5USAzi0C+MU/qH9ye7l7KF/V5 coWQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=SYRdSR83pRoiadB56rd54QjS8i5q7fm54uFKjpYd5fE=; b=Xqp9fxvBfMIuc2x9NopY+gK783DgFShI+OQM4r4ZWeW3db7huk2iDxLV7tLfk1vLhW dZnjJkBz3RVqUhb8CO2p8YkUbBmQ15XPRU6XxSdNJV/9nUgAcayVLAUNMCzAn+5WgUTS otey2sbL4zSnxJMzJcnfGMHsN/a6Ga4VqGw2Tc5yWvW77bqyCtCs25HMt3gJOJl3xLiw 8W4wI2+nSG51il9zFfIlVwFi28Ne1EWsrrTAZIcf0ZOYWfXQHrzHlz87sWn39xvKA21o lU9BZzi6QMfEPWzNhJDnj6WQdE/S/7MPUuxEgyXavSf7oUDoxQtTtJ8n2IEP5wS2sw32 RYnQ==
X-Gm-Message-State: APjAAAWkhhWKcV4HycDUZ5wy/Srf4+akxVOFUdNOtZlx4gkyQ3y4pn3k vLg+hvdToROwTcoO5oH5kURwA+s6gubv9t7J
X-Google-Smtp-Source: APXvYqyDcAG8ZyJyfQRBIy9yTpNxnlTHEthFozBWyxV8m6MnwJLoXUR0DjSAS/DVjFsT4hKEPIovPA==
X-Received: by 2002:a2e:74f:: with SMTP id i15mr14295220ljd.156.1554812844988; Tue, 09 Apr 2019 05:27:24 -0700 (PDT)
Received: from [192.168.8.150] ([195.234.15.130]) by smtp.gmail.com with ESMTPSA id o27sm6536340lfi.25.2019.04.09.05.27.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Apr 2019 05:27:24 -0700 (PDT)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\))
From: stefan vallin <stefan@wallan.se>
In-Reply-To: <155475933548.30143.7125328513195195530.idtracker@ietfa.amsl.com>
Date: Tue, 9 Apr 2019 14:27:19 +0200
Cc: The IESG <iesg@ietf.org>, draft-ietf-ccamp-alarm-module@ietf.org, Daniele Ceccarelli <daniele.ceccarelli@ericsson.com>, ccamp-chairs@ietf.org, ccamp@ietf.org, jclarke@cisco.com
Content-Transfer-Encoding: quoted-printable
Message-Id: <532DF573-7040-4695-9A71-4AF1202DC98C@wallan.se>
References: <155475933548.30143.7125328513195195530.idtracker@ietfa.amsl.com>
To: Warren Kumari <warren@kumari.net>
X-Mailer: Apple Mail (2.3445.100.39)
Archived-At: <https://mailarchive.ietf.org/arch/msg/ccamp/DEB2BGk9P-p4v52Ldx4157VnqZs>
Subject: Re: [CCAMP] Warren Kumari's No Objection on draft-ietf-ccamp-alarm-module-08: (with COMMENT)
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Apr 2019 12:27:32 -0000

Hi Warren!
Thanks for your review
See inline

br Stefan and Martin


> 
> I support Roman's DISCUSS, especially #2.
See our response to Roman
> 
> Also, please see the OpsDir review here -- I believe that you have already
> discussed it with the reviewer (Thank you, Joe Clarke!), but wanted to make
> sure that you also catch the nits.
Yes, these are cateched
> 
> Like Joe, and others, I find the term "Alarm Shelving" to be confusing -  it
> may be a formal term of art, but I've working in / with many NOCs, and have
> never heard the term used; if anything the terminology I'm familiar with "Shut
> up stupid alarm! I'll suppress it for now....". Shelving evokes memories of
> https://pics.me.me/10-ill-just-put-this-over-here-with-the-rest-32772452.png I
> would suggest introducing the term earlier, and more fully describing it as a
> courtesy to other readers.
This has been a topic in the CCAMP group as well, but we stick to it.
It is an established term in alarm standards and alarm systems in the process industry.

See for example the ISA 18.2 standard. Agree that it is not that well-known within IP and Telco
but there is a point in bringing in this concept since it is not just filtering.
As a reviewer said, aha it is "stashing"

> 
> "X.733 and especially 3GPP were not really clear on this point." - this sounds
> (unncessarily) rude - I would suggest perhaps "The X.733 and 3GPP Alarm IRP
> documents are not really clear …"

Good comment. Changed
> 
> Nits:
> "For example, a system with digital inputs that allows users to connects
> detectors" s/connects/connect/ I would also think that a better term is
> “sensors"
Corrected s/connects/connect/
I can see your point on sensors, but will keep detector….

> 
> "A potential drawback of this is that there is a big risk that alarm operators
> will receive alarm types as a surprise, ..." "big" reads oddly - I would
> suggest "significant" instead.

Good point, changed
> 
> "Alarm deletion (using the action "purge-alarms"), can use this state as a
> criterion." - superfluous comma.
> 
Fixed

>