[CCAMP] [RTG-DIR] RTG-DIR QA Review: draft-ietf-ccamp-dwdm-if-mng-ctrl-fwk

Keyur Patel <keyur@arrcus.com> Tue, 08 August 2017 00:59 UTC

Return-Path: <keyur@arrcus.com>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 19FAC131D27; Mon, 7 Aug 2017 17:59:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.92
X-Spam-Level:
X-Spam-Status: No, score=-1.92 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=netorgft1331857.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j4zVisnnGoIW; Mon, 7 Aug 2017 17:58:59 -0700 (PDT)
Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0069.outbound.protection.outlook.com [104.47.36.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DD30F131CEA; Mon, 7 Aug 2017 17:58:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NETORGFT1331857.onmicrosoft.com; s=selector1-arrcus-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=iwKKkM7ZP7+PtF/NQDRqVpAtWTzsGqupTU0Xwa2jyuQ=; b=oCgH7CvR+DOsdC8FvKnBHgvSZCgtYhDl5kBPdwohw8oqCgtj8zLpr3Otfk0KrAA8RPTHCFla1xZzfApERjdQlgz6zZdh3KZ+vjsXUlKEJxnefVU9uLa5ZPRioFnAoEZTX6ZGOwbta98eUZR3D5hQGBdATPeRXqv5b+A+NoKRsmI=
Received: from CY4PR18MB1127.namprd18.prod.outlook.com (10.173.184.14) by CY4PR18MB1126.namprd18.prod.outlook.com (10.173.184.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1320.16; Tue, 8 Aug 2017 00:58:53 +0000
Received: from CY4PR18MB1127.namprd18.prod.outlook.com ([10.173.184.14]) by CY4PR18MB1127.namprd18.prod.outlook.com ([10.173.184.14]) with mapi id 15.01.1320.018; Tue, 8 Aug 2017 00:58:53 +0000
From: Keyur Patel <keyur@arrcus.com>
To: rtg-dir <rtg-dir-bounces@ietf.org>, "rtg-ads@ietf.org" <rtg-ads@ietf.org>, "draft-ietf-ccamp-dwdm-if-mng-ctrl-fwk.all@ietf.org" <draft-ietf-ccamp-dwdm-if-mng-ctrl-fwk.all@ietf.org>
CC: Daniele Ceccarelli <daniele.ceccarelli@ericsson.com>, Jonathan Hardwick <Jonathan.Hardwick@metaswitch.com>, "Yemin (Amy)" <amy.yemin@huawei.com>, "ccamp@ietf.org" <ccamp@ietf.org>
Thread-Topic: [RTG-DIR] RTG-DIR QA Review: draft-ietf-ccamp-dwdm-if-mng-ctrl-fwk
Thread-Index: AQHTD+GB2gf7k6mHdEybYLIVBrrqwg==
Date: Tue, 8 Aug 2017 00:58:53 +0000
Message-ID: <1A44565B-2B86-456E-869B-E3E5F09471CF@arrcus.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=keyur@arrcus.com;
x-originating-ip: [2600:1010:b058:f540:1d84:85f9:bc59:9c2c]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; CY4PR18MB1126; 6:xNXtJJISFRye9J0RbbhV7zpbtv9u7lEEqBcIgA67wW9RSyW5cq37xtwnJ6frYcivrjQ3u7JA1z2FU7ichxwYg6rkONMNulAKnbN/LINZmS3UuHshrQ1ZYUqUnParjt6EnHdFEL+m320FjOndK/W4jd4T8CfoaYK5jQk1QqSQr+Oj8PLsWULDI9JIWg24GpI0YkwVycbcjgJdegFSw5WPXuiVwj1FQ9O81UVCgGZSGwzawyb38QsEZjLX5kxpz7qmXiplByrrufnbwkDt9eoqGGY2vOIvQx5ekb0iFZP8gnI9a2bElJn97GsJEQbP+q4vrGR9eQYkW0iJ+BSsEnL42g==; 5:azlJ3SIGKXP7hvc100ns4b83SeyJDBW4RfA+wy2BE6PDL1IaW0+cmCQxQYmBiYIVg7l2FqLkiL0fyVTQatHE/wg/UkHXLshmh3vK7rds1+lxm8lpAW9yyOEnwlFimueL540zTKz724kjQnB1fP6MMg==; 24:YKj/Ai1WHam8xpm98UFiyOX4kgw6fRCYnojOcgn/zU81WCFYmUOIagBnxEOgGvUvalFta3Oe6J4qLeKzl2GqyGwEAhp5kA+t5E4a+I1mzvM=; 7:F0pbOnbegCpT6MRXwdmahHEXQ+xatcq5sWFqHZ3sBmRBO6vkoeElPG01flCSl8O98p+1gRmUqBdN1G4cqZOS7lCydyfphrNg/04EelLcvwCfVHGjSNqrqZpd9GyLLoKI4nr6rCitJkkPICoeD+aX2vG8AHteSRaOy1N5I4wapy93Smo75DfSHFMK3AQ2fty6RBU/c6KSj8cVd3rayQY2ek+JrDgbXs1FWI+7D1g9W00=
x-ms-exchange-antispam-srfa-diagnostics: SSOS;
x-ms-office365-filtering-correlation-id: 8d1a9d35-08fd-4553-6350-08d4ddf8a3be
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(2017082002075)(300000503095)(300135400095)(2017052603031)(201703131423075)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CY4PR18MB1126;
x-ms-traffictypediagnostic: CY4PR18MB1126:
x-exchange-antispam-report-test: UriScan:(21748063052155);
x-microsoft-antispam-prvs: <CY4PR18MB11263B1B7C1CF7196036419DC18A0@CY4PR18MB1126.namprd18.prod.outlook.com>
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(6041248)(20161123564025)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(2016111802025)(20161123562025)(20161123555025)(6072148)(6043046)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY4PR18MB1126; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY4PR18MB1126;
x-forefront-prvs: 03932714EB
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39830400002)(39410400002)(39400400002)(39450400003)(199003)(189002)(68736007)(106356001)(478600001)(2201001)(2906002)(7736002)(189998001)(25786009)(105586002)(6506006)(4326008)(50986999)(102836003)(6116002)(14454004)(54356999)(6486002)(97736004)(77096006)(38730400002)(53936002)(9326002)(5660300001)(2501003)(5890100001)(230783001)(82746002)(86362001)(33656002)(101416001)(6512007)(54896002)(6306002)(54906002)(36756003)(2900100001)(6436002)(81166006)(81156014)(99286003)(3660700001)(8676002)(83716003)(3280700002)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR18MB1126; H:CY4PR18MB1127.namprd18.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en;
received-spf: None (protection.outlook.com: arrcus.com does not designate permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative; boundary="_000_1A44565B2B86456E869BE3E5F09471CFarrcuscom_"
MIME-Version: 1.0
X-OriginatorOrg: arrcus.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Aug 2017 00:58:53.2061 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 697b3529-5c2b-40cf-a019-193eb78f6820
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR18MB1126
Archived-At: <https://mailarchive.ietf.org/arch/msg/ccamp/GBbbt9f3BdvMux2x6Iw_uAyi4EQ>
Subject: [CCAMP] [RTG-DIR] RTG-DIR QA Review: draft-ietf-ccamp-dwdm-if-mng-ctrl-fwk
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Aug 2017 00:59:02 -0000

Hi,

I have been selected as the Routing Directorate QA reviewer for this draft.

Document: draft-item-ccamp-dwdm-if-mng-ctrl-fwk
Reviewer: Keyur Patel
Review Date: August 7, 2017
Intended Status: Informational Track

Here are my comments.

Overall, the document is well organized and clear about the problem statement and requirements for the framework for Management and Control of DWDM optical interface. This document could simplify early draft sections text and fix few typos + grammatical errors.

Attached are my comments:

1 - Section 1, Consider replacing: "Carriers deploy their networks today based on transport und packet" with "Carriers deploy their networks today based on transport and packet".

2 - Section 1, Last Paragraph, consider replacing: "Optical routing and wavelength assignment based on WSON is out of scope although can benefit of the way the optical parameters are exchanged between the Client and the DWDM Network." with: "Although Optical routing and wavelength assignment based on WSON is out of scope, they can benefit from the optical parameters that are exchanged between the Client and the DWDM Network."

3 - Section 2, first Paragraph, consider replacing: "The DWDM interfaces migration…" with "The DWDM interface migration..."

4 - Section 2, fifth Paragraph: "Administrative domain [G.805]: For the purposes of this Recommendation"
   Perhaps the authors meant "this document" as oppose to "this Recommendation"?

5 - Section 3.1.2 last Paragraph: "The following documents[DWDM-interface-MIB], [YANG], [LMP] define such a protocol- FIX-THE-REFERENCE specific information using SNMP SMI, Yang models and LMP TLV to support the direct exchange of information between the client and the network management and control plane."
Does this also apply to Section 3.1.1 or it is specific to Section 3.1.2? If so, it should be moved out of Section 3.1.2.

6 - Section 4.1.2, third Paragraph and 5.1: LMP uses reliable UDP.  For any Indirect and Direct connections, how does the optical network node recover from partial network configurations upon LMP based adjacency failures? Does that need to be a requirement for LMP extensions?

7 - Section 5.2.1: The alarms that can be generated for use cases mentioned in 5.2.1 can be chatty particularly when sending over LMP (or protocol of choice). Is there a requirement to pace/damp the rate of Alarms (that would be carried within LMP)?