[CCAMP] Yangdoctors last call review of draft-ietf-ccamp-alarm-module-06

Carl Moberg <calle@tail-f.com> Wed, 19 December 2018 15:55 UTC

Return-Path: <calle@tail-f.com>
X-Original-To: ccamp@ietf.org
Delivered-To: ccamp@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 9B303130E2B; Wed, 19 Dec 2018 07:55:45 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Carl Moberg <calle@tail-f.com>
To: <yang-doctors@ietf.org>
Cc: draft-ietf-ccamp-alarm-module.all@ietf.org, ccamp@ietf.org, ietf@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.89.2
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <154523494557.2904.788634195669624933@ietfa.amsl.com>
Date: Wed, 19 Dec 2018 07:55:45 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/ccamp/H0GrCOoDDsc6XTbUYBhJpyyE9O0>
Subject: [CCAMP] Yangdoctors last call review of draft-ietf-ccamp-alarm-module-06
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Dec 2018 15:55:46 -0000

Reviewer: Carl Moberg
Review result: Ready

I have reviewed this document as part of the YANG doctors directorate's
ongoing effort to review all IETF documents being processed by the IESG.  These
comments were written with the intent of improving the operational aspects of
the IETF drafts. Comments that are not addressed in last call may be included
in AD reviews during the IESG review.  Document editors and WG chairs should
treat these comments just like any other last call comments.

This document includes two YANG modules:
- ietf-alarms-x733@2018-11-22.yang
- ietf-alarms@2018-11-22.yang

..and an example YANG module:
- example-xyz-alarms.yang

The modules are valid, well-written, concise and provide ample documentation.

I have pointed out two small spelling errors in descriptive text, but will
leave it to the editors to decide on the potential need for submitting a new
version.