Re: [CCAMP] Yangdoctors last call review of draft-ietf-ccamp-otn-tunnel-model-11

Daniele Ceccarelli <daniele.ceccarelli@ericsson.com> Mon, 19 October 2020 09:52 UTC

Return-Path: <daniele.ceccarelli@ericsson.com>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1EF0F3A099F; Mon, 19 Oct 2020 02:52:54 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.202
X-Spam-Level:
X-Spam-Status: No, score=-0.202 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id luM4MCgDlJT4; Mon, 19 Oct 2020 02:52:52 -0700 (PDT)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140055.outbound.protection.outlook.com [40.107.14.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 401883A0991; Mon, 19 Oct 2020 02:52:48 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=baq36PBLtQTNfBIDzTW1btNJ8Gy1NMyVuG4BIs4kob+C5yppwC6F6sptOm9eQ1ZbF/lYh4A1cC9u0QYfdj9OwsSNixeK75MdLxL4pSfloLW88oFT1hzANBwgyJxf+3uUyZHstfQIJfUGm41SWlBB5xn9+nZ1ssVw/M9mQrtaxqQr8leFjsco8RRfvF+fzUm6dYu4mXcIfnCg89Bp0b1rH/+lEMN9WoVKe4knetI4z0LSQYrzu0ETatRiuiX+oDseL54PSqryufvZv3n1JGnRA/2Cbu86kMuaZBOYFGbDrX+BYgTkKlj3Ng3dNvbsSAT7V4eEUxrFHSJp1Oj3Ejs/EA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bJdQ27yNk7SEv3w9oP8UPhhB/RMR59pIES4faof0o/o=; b=T9XdA2l3ks4x5szaGs/NBc8c4HYgXGI6Zb1MWnTuSLRx4YGiPWQtjKIKpp9gPoYLdIuzwG2lRCtNLZG3f+NIl+tspWFVWBuyl8W450dsBEJeJFQzbxRu6qiNVu1PIEULagW5YGin20h9GuPKjzzTcvpSp0Ue0VWPiMGLFAXgZaEShhL/xkuDbueCU7HTC/9UjYthQLNINT/5JfmlUcVL8NVQkiyMEi2JYT1POfNdSy1IxXZCxR0NzQq4os4yaSuLHMf+w9XBX9o3FLz/BaUlOCd0vTkFAPjRdCi8RWcnYjPJW/X3I/VlnfoyTUSfNr3D9Wj1hQUuwZEYoHGt9cxG4w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bJdQ27yNk7SEv3w9oP8UPhhB/RMR59pIES4faof0o/o=; b=kypnLsNfrxxu4XSoQw3mEHSRFc/3/FxW+j5ajVI82v6Qfh1hnx/YeeZSpUKLFnPz/zN0/LL0DzxUP+PlebAomMqQVc9BmhxndwtCb9DRbCmfmUkWVf4uoSxmE3OqQ99OyMCKg57pwgfcsBGg4W+CoNABgXgQX5Nlo6ckO2PBvPo=
Received: from HE1PR07MB4156.eurprd07.prod.outlook.com (2603:10a6:7:9b::16) by HE1PR0701MB2249.eurprd07.prod.outlook.com (2603:10a6:3:21::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.6; Mon, 19 Oct 2020 09:52:44 +0000
Received: from HE1PR07MB4156.eurprd07.prod.outlook.com ([fe80::8d9b:9ab1:1a37:6e93]) by HE1PR07MB4156.eurprd07.prod.outlook.com ([fe80::8d9b:9ab1:1a37:6e93%7]) with mapi id 15.20.3499.015; Mon, 19 Oct 2020 09:52:44 +0000
From: Daniele Ceccarelli <daniele.ceccarelli@ericsson.com>
To: =?utf-8?B?UmFkZWsgS3JlasSNw60=?= <rkrejci@cesnet.cz>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>
CC: "last-call@ietf.org" <last-call@ietf.org>, "ccamp@ietf.org" <ccamp@ietf.org>, "draft-ietf-ccamp-otn-tunnel-model.all@ietf.org" <draft-ietf-ccamp-otn-tunnel-model.all@ietf.org>
Thread-Topic: Yangdoctors last call review of draft-ietf-ccamp-otn-tunnel-model-11
Thread-Index: AQHWo8DzndQFPN0EtUmnQ8WJYvNd36messtg
Date: Mon, 19 Oct 2020 09:52:44 +0000
Message-ID: <HE1PR07MB4156B1C2A43AF39C469F75B0F01E0@HE1PR07MB4156.eurprd07.prod.outlook.com>
References: <160285520741.1658.15600224799776978218@ietfa.amsl.com>
In-Reply-To: <160285520741.1658.15600224799776978218@ietfa.amsl.com>
Accept-Language: it-IT, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: cesnet.cz; dkim=none (message not signed) header.d=none;cesnet.cz; dmarc=none action=none header.from=ericsson.com;
x-originating-ip: [93.38.67.165]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: bd2706cf-ee06-4ac9-048b-08d87414ba76
x-ms-traffictypediagnostic: HE1PR0701MB2249:
x-microsoft-antispam-prvs: <HE1PR0701MB2249B857381A82BA658DE021F01E0@HE1PR0701MB2249.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 3oPNLdp+QgIT556NfO6hh2kHYLQuMybpmIyMOPqNWuqHbyzYMW1Cng7M5x/eil6ug6a0vf5x3vzKlB/jrSMUFDgPfmKcljKcz5E9ba0Lo/nI1ypT5Gw+AnhaGxvIQ+0zS1DAB5M5Vq+oU3NnXReSrSXtlmkNhtDx7uOGQfC/gscVLdY49SnvO4MB0s2n5gK8G98krJuc6QQD4l4IWSUcGBI8zkI2QUbOq14wMXaZ1wZqMWoSNvTvYOTPtutD9yk/rrtqH9JcaevyBIlUCr1Q4SDCF5yMxQPY+Fa13iOWj+126CGbfeyzXPz98d7uTQiJu3Cha04NCQ9dVO3yZ+EFXmtsyGal8CspwNlCFojgRO6d2Qzhi4th7O01tdAwWPKntAE5HGwfgG5VOxUyaSIepQ==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HE1PR07MB4156.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(39860400002)(376002)(396003)(366004)(8936002)(52536014)(83380400001)(9686003)(71200400001)(55016002)(5660300002)(186003)(26005)(76116006)(66446008)(66476007)(66556008)(66946007)(64756008)(44832011)(86362001)(8676002)(478600001)(53546011)(110136005)(6506007)(2906002)(33656002)(316002)(7696005)(4326008)(54906003); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: YdN6FFTa7piivItX3jRtd/39UfXPjCNADbP0xmhH35qAh/cqUOAr11Z18H3z27laidLao0GKByZrr+IqfqCyHvSjqTW9xs1iqUN2w3BECsJ2XKsZJBRbNg5pNRJranTs0+SqvTliWq8YhCB3ThPKYkaXKyINJriNvrfFTmwVBvpQdOj6qliYN/tWguTCwZXm19SxPV+QxEy/dIdVNq+zFTSvYF/Xu/jKql8O+Q2CbpDfvBslyv3o0/36Ikek3/CcjYZBI0RlZhOMlCnMe+WO2uhT2uhUSCn0Ff4pIiwc9pAwpiKh2lqRdTRVZFm11401tGqu0bhpBhvcmuiFsp/jmpC6Q1bDdmQzpvNypsGcSqqPU+MOZlPSRm1GfXyWrme6y/8bJcEGqhRogAyeBxR15aobkC/hm1752g6I2R+Bw3P85iehnyGNl45PPvnBm7L6XYDDOScPTiKNgPC+leN47NpWttPShA+FsvMqa1dwhbGGEpggTZuGyx2hWcx78zVmG/omOFjms9kibelDWgAAmbBwhj8WBoagRDsDdKxo7e5H8p3+Y62RLARQBQo0So/+A0kJPIpldcFzoao/iZXkIeDGLMBKQAIOJGWFV/dJZ6XkvWxhyYs9u/tsvwNTnx6kbeodfxHW+zaaA3RkNLyGhA==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: HE1PR07MB4156.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd2706cf-ee06-4ac9-048b-08d87414ba76
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2020 09:52:44.7990 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: oWDPPohyhwbq438JCceqMsHTDOxEZi98I1us6ymqArX2lBC1Z+zSVKZ8IpZqBXk6VkVo1ja+xkoFQqpQxZdRt5cqFWQNWwlG72iG+qafpxM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0701MB2249
Archived-At: <https://mailarchive.ietf.org/arch/msg/ccamp/jIKE23UC1VT1DTi80elyTjofAAU>
Subject: Re: [CCAMP] Yangdoctors last call review of draft-ietf-ccamp-otn-tunnel-model-11
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Oct 2020 09:52:54 -0000

Hi Radek,

Thanks a lot for the review, much appreciated. 
We requested a joint review of the OTN tunnel model and the OTN topology model (https://tools.ietf.org/html/draft-ietf-ccamp-otn-topo-yang-11 ).
I'm just checking if you need a bit more time for the OTN topology model (which is perfectly fine) or if the request for the review of both drafts got lost.

Thanks a lot,
Daniele  

-----Original Message-----
From: Radek Krejčí via Datatracker <noreply@ietf.org> 
Sent: den 16 oktober 2020 15:33
To: yang-doctors@ietf.org
Cc: last-call@ietf.org; ccamp@ietf.org; draft-ietf-ccamp-otn-tunnel-model.all@ietf.org
Subject: Yangdoctors last call review of draft-ietf-ccamp-otn-tunnel-model-11

Reviewer: Radek Krejčí
Review result: Ready with Issues

This is my yang doctor review of draft draft-ietf-ccamp-otn-tunnel-model-11
with the ietf-otn-tunnel@2020-03-09 YANG module.

Despite the size of the module, its structure is very simple repeatedly following a pattern of augmenting ietf-te by groupings defined in ietf-layer1-types module (except the single grouping defined in the module itself).

Validation tools report a number of errors in the module. The problem is, that the module references (in augments) /te:te/te:tunnels/te:tunnel/te:p2p-primary-paths/ and /te:te/te:tunnels/te:tunnel/te:p2p-secondary-paths/ which are not present in current ietf-te@2020-07-12 module (the nodes were removed in draft-ietf-teas-yang-te-23, the reference in the Section 10 of the draft is to
draft-ietf-teas-yang-te-25 but the module is not in line with this revision).
So the module needs a crucial update. Also please consider if the grouping otn-tunnel-attributes is reusable in other modules. If the reusability is not the concern, I don't see any reason to define it instead of specifying the grouping content directly in the augment.

Regarding the draft, as a reader, I would appreciate a more targeted description in section 3. Instead of just dumping the tree diagram in section 3.2, it would be useful to split it into several areas with some brief descriptions and examples.

The list of paths is introduced in Section 6 as "the subtrees and data nodes and their sensitivity/vulnerability", but I don't see explained/described the mentioned sensitivity/vulnerability of those paths. Besides that, the paths include '..' as ellipsis, but '..' has its usual meaning in paths, please unify it with the format used in ietf-otn-topology and use '...'.