Re: [CCAMP] I-D Action: draft-ietf-ccamp-wson-yang-16.txt

[tom petch <[e-mail]>]

I think that this I-D needs some more work on it.

- I have never seen a YANG module with so few Normative References; in
fact, you cannot validly have one with so few.  Recall that Normative
means you need to understand them in order to understand the I-D and at
the very least RFC7950 is in that category and I suspect most of the
others are too (but not RFC8340).

- IANA Considerations references RFC7950; all this RFC does is tell the
reader to go to RFC6020 so that should be the reference here.

- The Security Considerations is not current - it lacks any mention of
RESTCONF.  This will require Normative References to RFC6241, RFC6242,
RFC8341 amd RFC8446.

RFC6536 is referenced but not in the I-D References

The Abstract and Introduction fail to mention whether or not the modules
are NMDA-compliant.

The YANG module has a lower case 'must' but no indication in the body of
the I-D as to how this should be interpreted.

The YANG module contains

" ...the generic TE topology module [TE-TOPO] based on the information
model developed in [RFC7446] and the two encoding documents [RFC7581]
and [RFC7579] that developed protocol independent encodings based on
[RFC7446]. "
AYANG module must be plain text so XML-style references in the module
itself are not permitted; all those [....] look suspiciously like
references in which case, they must go.

The YANG module 'import' statements

 import ietf-network {   prefix "nw";  }
 import ietf-network-topology {    prefix "nt";  }
 import ietf-te-topology {    prefix "tet";  }
 import ietf-layer0-types {    prefix "layer0-types";

need to reference the RFC where these modules can be found, e.g.
  import ietf-network { prefix "nw";
   reference "RFC 8345: A YANG Data Model for Network Topologies"; }

The YANG module references
RFC6163
RFC6205
RFC7698
none of which are in the References.  'reference' statements in the
module must be plain text but the document must be referenced from the
body of the I-D with a suitable entry in the References of the I-D.

module ietf-layer0-types
lacks a YANG version statement.

Tom Petch

----- Original Message -----
From: <[e-mail]>
To: <[e-mail]>
Cc: <[e-mail]>
Sent: Monday, November 19, 2018 6:00 PM
Subject: I-D Action: draft-ietf-ccamp-wson-yang-16.txt


>
> A New Internet-Draft is available from the on-line Internet-Drafts
directories.
> This draft is a work item of the Common Control and Measurement Plane
WG of the IETF.
>
>         Title           : A YANG Data Model for WSON Optical Networks
>         Authors         : Young Lee
>                           Dhruv Dhody
>                           Aihua Guo
>                           Victor Lopez
>                           Daniel King
> Filename        : draft-ietf-ccamp-wson-yang-16.txt
> Pages           : 74
> Date            : 2018-11-19
>
> Abstract:
>    This document provides a YANG data model for the routing and
>    wavelength assignment (RWA) TE topology in wavelength switched
>    optical networks (WSONs).
>
>
>
>
> The IETF datatracker status page for this draft is:
> https://datatracker.ietf.org/doc/draft-ietf-ccamp-wson-yang/
>
> There are also htmlized versions available at:
> https://tools.ietf.org/html/draft-ietf-ccamp-wson-yang-16
> https://datatracker.ietf.org/doc/html/draft-ietf-ccamp-wson-yang-16
>
> A diff from the previous version is available at:
> https://www.ietf.org/rfcdiff?url2=draft-ietf-ccamp-wson-yang-16
>
>
> Please note that it may take a couple of minutes from the time of
submission
> until the htmlized version and diff are available at tools.ietf.org.
>
> Internet-Drafts are also available by anonymous FTP at:
> ftp://ftp.ietf.org/internet-drafts/
>
> _______________________________________________
> I-D-Announce mailing list
> [e-mail]
> https://www.ietf.org/mailman/listinfo/i-d-announce
> Internet-Draft directories: http://www.ietf.org/shadow.html
> or ftp://ftp.ietf.org/ietf/1shadow-sites.txt