Re: [CCAMP] FW: I-D Action: draft-ietf-ccamp-l1csm-yang-02.txt

"t.petch" <ietfc@btconnect.com> Thu, 21 June 2018 11:32 UTC

Return-Path: <ietfc@btconnect.com>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DEE5D131230 for <ccamp@ietfa.amsl.com>; Thu, 21 Jun 2018 04:32:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.91
X-Spam-Level:
X-Spam-Status: No, score=-1.91 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j_kOQBJk6UpZ for <ccamp@ietfa.amsl.com>; Thu, 21 Jun 2018 04:32:37 -0700 (PDT)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0093.outbound.protection.outlook.com [104.47.0.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CA5F4130E7E for <ccamp@ietf.org>; Thu, 21 Jun 2018 04:32:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector1-btconnect-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IX6FM2b/YnAg3e7WlSE3O4Xiko14TYSA1/wsToijDIY=; b=ZRB8psArTTcFxSeHtHu/Ts323/j9ksBHPNK7C4t72Ta0xdCQD2NcHm+4honrCI6lvTDbU+0LDoLWhicB7LYg47PoMBoLOudbfvARMMR4lPaoCcCrEJD6ZAWC0ODMwx3Vrl3wlV7IpQBRePfj2zpNIRGoPjGYD4LxP/EolGliNxA=
Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ietfc@btconnect.com;
Received: from pc6 (86.156.84.71) by DB5PR07MB0822.eurprd07.prod.outlook.com (2a01:111:e400:5106::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.15; Thu, 21 Jun 2018 11:32:33 +0000
Message-ID: <026401d40953$3ea4a4a0$4001a8c0@gateway.2wire.net>
From: "t.petch" <ietfc@btconnect.com>
To: "Leeyoung" <leeyoung@huawei.com>, <ccamp@ietf.org>
Cc: "Martin, David \(Nokia - CA/Ottawa\)" <david.martin@nokia.com>
References: <152950916788.10950.7997577566216514206@ietfa.amsl.com> <7AEB3D6833318045B4AE71C2C87E8E173D01A588@sjceml521-mbx.china.huawei.com>
Date: Thu, 21 Jun 2018 12:29:57 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2800.1106
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1106
X-Originating-IP: [86.156.84.71]
X-ClientProxiedBy: LO2P265CA0191.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a::35) To DB5PR07MB0822.eurprd07.prod.outlook.com (2a01:111:e400:5106::12)
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6d09da4d-1bec-48bf-5e9b-08d5d76aaec6
X-Microsoft-Antispam: UriScan:(109105607167333); BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989080)(4534165)(4627221)(201703031133081)(201702281549075)(8990040)(5600026)(711020)(2017052603328)(7193020); SRVR:DB5PR07MB0822;
X-Microsoft-Exchange-Diagnostics: 1; DB5PR07MB0822; 3:1EyOIBac3+P6jyWKm8bSLGC96KwWwEz+HY1Qrfgt0mwDHM1uFPwpg0OKvar9Q6SkWPM0Mz1M6sHP2JpiAuwP057Z+WmXNU26tdG8mIpwmQy8CugDjWD+JVEbiCzuHw0t5iTywjsjj8OLcCkJMvJPrKNH+rXyyOR/fi7/2IK4xiCp8LACSEL4aFtq0hj7A2MjMLSbfn/Yk9U23B0WvHSU8Mk0hjdqY0vEIsZH6MHO5hZrQ+CaSby142qYYUrHLjd2GnZc1t7feLcJJyHNOmC2g+j1mX3UMzX7F72eV82KpOI=; 25:q+aztKLJTPwOAnkafhdzl43+XRrl7VsUoi6T0hWFW97kxasKJ+vwxw1EIwziSsHPYv48/oeaLpsQDJ6hw1clLJUB2hhxtbrVL0ylOcm1wkvac3o9EpI6uUGqDb57FuOwt2EzeJAYAz4LSTiGjm2jQrcPk/o3BfgBU+r2xtVAUuvYfU2lcpFMemAE/ggHNUbUNGfazid5Ih+NMwzolKQaxyExjwURnDIdAP2bf3ae1+9YRJ+pGJHhbTZdF9vrbf0S4kCTCpLW8tyBth13IMLSgH1RNCW+fXOSZ57uRQxW2PGRbut14mwA0NeIWel8AeXa2G8LTB3qahUH3XHOb0HveuZB1Bj/NK/ceicWvvn+/Yw=; 31:SjyyM+ogxN8d1ipYh9TsGpxRRWVW5xtlW9srHSk2xhpVOHIyn09aI/Afjhc4nHPhednpy/Ei7VRLtc7kecyQH9wVcfNiaJk5iX7YBdTr9dH3SqQI8poD55GTsMRIEhLeBbZwz+LbL0zwOh9AFCqyq5K+vIYCg0jaNzk67iTnVOuhEKnZHEnXTMHh75hMg5ysBxMk6pW5SPuUlC4uML/CaXn0a46JstGTAvfOBZ9PHMg=
X-MS-TrafficTypeDiagnostic: DB5PR07MB0822:
X-Microsoft-Antispam-PRVS: <DB5PR07MB0822F7F6D8A012F527F04A7CA0760@DB5PR07MB0822.eurprd07.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:(120809045254105)(192374486261705)(50582790962513)(82608151540597)(109105607167333);
X-MS-Exchange-SenderADCheck: 1
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:DB5PR07MB0822; BCL:0; PCL:0; RULEID:; SRVR:DB5PR07MB0822;
X-Microsoft-Exchange-Diagnostics: 1; DB5PR07MB0822; 4:r/smrpGSYFYw0DV/UO4VCccu8U+I0oSDZX7fx/YBnQov0t1Syb96W2+dR8E1+7qfcMQSuncTo7i5Ws5XgXpiJ0NAFBtyqD1AcVhq5T1HuJqRgW+Vj/HH4tT0R0mAlZCtZe7BlgGXg3+dovt86udK4nW6NYxG84zGpxLfq7q1X0qn4aSi1VxGl/AWUCf4PKUsUFXrQk7leNDa7r1I6kr9mH9ggE5FDzcSMeN6c7Af1m1pUnMmRiAHvQmXCqMu+Ptjxj22fS3nJeitKf/iVg5bJjTbW3HhkDpKXzko2pt1XrVWRZNEc9vVoKovmC+obDLszkj1fihfuk8YGm8Ev79JudtLSt8IQDM+d9d3xyL2iJAQpd3mjXPmZIOFrGeIH/afwL3JJPWPgU9vWOTgtHcLFaDdICKNXHARToM1UIuiS/d3OfpAJYYpY5QVc1qwN3+JCtE+IoC3NcJF+E8AYJMN2Q==
X-Forefront-PRVS: 07106EF9B9
X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(366004)(39380400002)(376002)(396003)(39860400002)(346002)(13464003)(189003)(51444003)(199004)(54094003)(2906002)(9686003)(44736005)(84392002)(3846002)(5660300001)(86362001)(106356001)(6116002)(229853002)(14496001)(53936002)(97736004)(6486002)(61296003)(105586002)(476003)(446003)(486006)(956004)(8656006)(4326008)(6246003)(478600001)(966005)(230700001)(25786009)(59450400001)(81686011)(33896004)(52116002)(316002)(7736002)(305945005)(26005)(81816011)(76176011)(110136005)(50466002)(23756003)(386003)(53546011)(186003)(6306002)(68736007)(66066001)(16526019)(47776003)(62236002)(44716002)(81166006)(1556002)(4720700003)(6666003)(81156014)(6496006)(8676002)(8936002)(50226002)(74416001)(7726001); DIR:OUT; SFP:1102; SCL:1; SRVR:DB5PR07MB0822; H:pc6; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:0;
Received-SPF: None (protection.outlook.com: btconnect.com does not designate permitted sender hosts)
X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1; DB5PR07MB0822; 23:19RNQr4AC3LkHHmoQjcMDYttkYsF+fPHtwyIbZJ?= =?iso-8859-1?Q?dEWysm2WRHPVaTv7ZNwMYuWA4IaRl4KgvBRUjmSPp5QzQ9MxCPNoQ9VZFV?= =?iso-8859-1?Q?UvNi9ESUYQlh0Mkr+N7hqeLwF48Evqh8WtrEsBx7OTR8ItCeBIlbd6BRwO?= =?iso-8859-1?Q?Rmk3/Bq0RS2X60Jtcue7A2LYpGfGV/vjDX6HEpo2w1GMyQxNGhplorEYKn?= =?iso-8859-1?Q?xFAgxqqarjxhWNsDP93paAjX+q2xY0iNHW95ct6z1oZBSH+z+mSANOJXwN?= =?iso-8859-1?Q?IRTvcPtRYISDIHiqMYLExt5Na1cN8nlLK1IqzoyzVoIkkiJO5vrqLB3eHz?= =?iso-8859-1?Q?AB2QfaZ4o7I9x8gKhQ3PHAMNrxJ//8wuppO/Em1+Mv5cFOiq4G1WallcZ+?= =?iso-8859-1?Q?inz0HUcWj3YY+uOLNTckcZCfck/3q95vG8WHwT9apUcU3AMlMk7nu+ZF5d?= =?iso-8859-1?Q?uOzEC5Mibk2NrKRsMcXxDBouggIIFLUaNzwD3ElCWVTcS3LWU+xbmSRCQs?= =?iso-8859-1?Q?Xu9TPaG2xe8Qx9tGaPPmKIA58eM8xJsO1UMup0oTVTut8YYk4WLe8U5voQ?= =?iso-8859-1?Q?EcYVVK3NHW+G6dPQe7RpRiwwh6geQ2mV/Ds3EoAcckOUvz8GkecKbnE6lU?= =?iso-8859-1?Q?12K26q8dhCpyIxfwXb2vPJX/XjLbeeNfYCYKX9yXWiNMGeJe1rt4R5WMrM?= =?iso-8859-1?Q?plZaSdP2+y7YswAll7ssZQ2CFvPKtsT7bWfc8cFWY1cP/A3XRmhZAtuuov?= =?iso-8859-1?Q?vNRQpbN0x0QZcyIJg7MAI/5PDMO9aDbSHFLNSwpwQptGYUDhP9AGpJkF+r?= =?iso-8859-1?Q?sOzf1lhzD8xLS3ihkHVdPr+t2b5TtLxHHHENCTiCrjqEVtwziVGF2vp3DQ?= =?iso-8859-1?Q?HunwlyZxPVmddleWd4rTH3cakG8f99Qdd/a7pEIUJVUxt7gx5GUDOZD9bN?= =?iso-8859-1?Q?cyIerIDwTDIVScZ5ggbVZ/UoCbLETSkW8QT0Y0tl5zVpJL2xfQNkKBDkN/?= =?iso-8859-1?Q?1qNSiMHqMdOSqdxNFVifei++/ApUVfiaH6dBdunX2Z/wui/cCKHMf2vgZQ?= =?iso-8859-1?Q?FAbfPRoZBQns0rC5A9sI68KMXsnllEiLXhkA4v4iSUOpkf0xQZl64MKajG?= =?iso-8859-1?Q?NftStao/eLO2ihHpFqJOroq2qnKHslIvUHi+viqi3+yxu7D1ki6HrALGR5?= =?iso-8859-1?Q?uQ6dEbBiyewK6bl5eO5xdWjQkZXfJ1GmaLeKcQHJBgBsj9W3XF53H3VDiK?= =?iso-8859-1?Q?qO7AFKrqtQf19CT5/zwRVwJz50wBP4cE0Kl/yGsR9yM/eQAEB6Gc1vEreW?= =?iso-8859-1?Q?5vaitLD9xcaGGkbKgpEB0Zn2+i8JjTjna5pAhz9VT/9b0PXxDM8gwNVe/a?= =?iso-8859-1?Q?HweU7QC3DepPNTyziiv9gvvFUCboIZLlrdAw/UddV4oQreEZTyIH9fdj3U?= =?iso-8859-1?Q?oAYBasPCDgyD5BnOvw6Y+vZr8l430cNYh0MI0J1IKEkyhCEaSi54n9/W51?= =?iso-8859-1?Q?kHAppXBMdbCqTZ3PFazYWvhR9SMck8BG3eq1jQt9ckeUYQ8ySgnD8tcoTg?= =?iso-8859-1?Q?Qjm8Cse+OAYJ2CtdU6PqMoAuErJ3508xrNTgmPaKm2LBvGPXHH9rjJaKcb?= =?iso-8859-1?Q?OVjcYw8ZQdYNypgOaY7kG9Fx0O2aY4tTGVhjqzsVIoj6zE8Bzic3j?=
X-Microsoft-Antispam-Message-Info: yFKWl1HVJgcBd5w0fNLbm4mOkvDlWqSnFnvq8qJm6+8QW4zZRFpgM0XGEB+47xRGPXrUR0EaBFdKWKLIzRxJhrqCm/6w2gBOEDYx+7xA8/8wiWfhbOkVpSmVTUtpTBkFFwJZTUHhPe1RCj/mYX7zkCCKbJt4+MNPqkefXx3DvY/4qTy/BiwogkvAeEUDmpaeBJiEbuUq/O+aFPcIp+kQy6NmHbTYbwCHsjjzjqXvznunpxL8M5Nz5i/nsRqCVzDf4Du2Hb5UM4bN8/C9jtR+ZWkl7JjQPlMIVg5WDnP+SY8Jm249kWPsZJkgsGzFgM1xC/D8U6R0uyaBBBSr8ZAHlA==
X-Microsoft-Exchange-Diagnostics: 1; DB5PR07MB0822; 6:3NINlUi7sO4ESDN/VLUGLUytI0tGcS1oSOF9oobNY8ivKr091tHfYTf0VesTemv33kiEgwWMB7362c33AVEXGea76cr+7XkvavKdVqVG6otQe3x8LAuxPMGUhoVNCcCZLn1Eq+IiYbz2qESPZ1nmLeYrU3ZcBFxJoztTV/ykxMnLrqxZx4dme7cOCA9awLmCJbpdyCfWDX5qU53UppnM9hCpktD2vaGOdmjrw1hKDAo4XHYy+15TTMihbVrMtk/fLKKDvxP0s6B0WYjM2lwOfVfkghJG7/uJU6Zcv+MXSp9czHxsGWdyt5fgmgma4VeF5nH1iS6BPv2/hAJaF5EE/3PwAIh9Ne5QPeakGvtnHGE9k7JsQe9dOtXQWfFYr4M0uGsw4VuoyGp992tC62Qo+tJVpeyZW6UVkBg3VgmCG3MSgul1MOQEWlhoGoPlCPl8GViydde0GDds3Kj/Iclw/Q==; 5:L17ROLC8cSVFi0vW5rZ564L3Cod2frn8JjtVLMtGvPF2m1eT7uffG/rQHYfVThyuTvrinpWTN3oM0P/Y7ygSOaU26dmk3wTYgBgbNpvLfLEkMRMuN/Ao9IdRcIZVde/kHm+pWqbW36+HZEYtqVIhshEcUfvBxxid6l60rB4r65o=; 24:+RYckkuyC8pzet28ZOeYOIccdAm5AvS8X4MAmsFEPju6QnriiBsXnEMS4gGLGFI/Y9dy0bR9KvOianboi8V/0Zx+77iyDrQNv+qsh+B7Eho=
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-Microsoft-Exchange-Diagnostics: 1; DB5PR07MB0822; 7:LTypgXJ0kjesFrl4W5sOwfhadUD16sHjp0zmoEps81OLvyT9karWdfahEoyyxK31v1U8U+WmNS4vXz+2GEHapEDTbG8ADwsHQGbQfyJ01qOqLkQ7Ocz1DAUhoJa012Tp1mCh09qIUJVeRlbwliBpBGaHvsjc8FpJn5psQa0tIwBFr4t7sev5W1z25SD+ss0vYKxN3hBKE94yvpKJhmYHWIn4cgZa/KdQsL+CuWxy53PVFskNBYdwSNKNUVghsXMK
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2018 11:32:33.8722 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d09da4d-1bec-48bf-5e9b-08d5d76aaec6
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR07MB0822
Archived-At: <https://mailarchive.ietf.org/arch/msg/ccamp/PSQD3R7eFTBgBeEaqXbwovlH_44>
Subject: Re: [CCAMP] FW: I-D Action: draft-ietf-ccamp-l1csm-yang-02.txt
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Jun 2018 11:32:41 -0000

----- Original Message -----
From: "Leeyoung" <leeyoung@huawei.com>
To: <ccamp@ietf.org>
Cc: "Martin, David (Nokia - CA/Ottawa)" <david.martin@nokia.com>
Sent: Wednesday, June 20, 2018 4:49 PM

> Hi,
>
> The revision incorporated comments received from the last CCAMP
meeting and the MEF Q2 meeting in April.
>
> I believe the draft is stable.

I hope not:-)

I find it hard to read; the indentation is, for me excessive, causing
lines to spill off the page.  You are indenting each lower level in the
YANG model by 10 spaces whereas I would prefer you followed in the
footsteps of
draft-ietf-ccamp-mw-yang
which uses two.

The tree diagram notation is now an RFC and I would expect you to
reference that and not include your own notation, again as in
draft-ietf-ccamp-mw-yang

5 Security Considerations needs to call out the sensitive nodes by name
or say that there are none, again as in
draft-ietf-ccamp-mw-yang-.

The YANG modules need Copyright as in
draft-ietf-ccamp-mw-yang

The Introduction needs to say whether or not the YANG module is NMDA
compatible, as in
draft-ietf-ccamp-mw-yang

The import in the YANG modules should have reference statements, as in
draft-ietf-ccamp-mw-yang

You need references in the I-D for YANG and Netconf, as in
draft-ietf-ccamp-mw-yang

I would expect to see examples, as in
draft-ietf-ccamp-mw-yang

I think that some abbreviations should be expanded in the definitions
 SLS
UNI
PE
CE
p,c,o

I wonder if the future would be simpler if the protocol types were
grouped, eg into Ethernet, FiberChannel, STM etc.  It depends how they
will be used, but I would expect there to be conditional statements
based on these groups.Your view of what makes a sensible group will be
better than mine but I think that the current flat structure is unlikely
to be easy to use.  A comparable change was introduced after the YANG
doctor review of
draft-ietf-ccamp-mw-yang

Tom Petch

                                Please feel free to provide your
feedback.
> Thanks & best regards,
>
> Young (on behalf of other co-authors)
>
> -----Original Message-----
> From: CCAMP [mailto:ccamp-bounces@ietf.org] On Behalf Of
internet-drafts@ietf.org
> Sent: Wednesday, June 20, 2018 10:39 AM
> To: i-d-announce@ietf.org
> Cc: ccamp@ietf.org
> Subject: [CCAMP] I-D Action: draft-ietf-ccamp-l1csm-yang-02.txt
>
>
> A New Internet-Draft is available from the on-line Internet-Drafts
directories.
> This draft is a work item of the Common Control and Measurement Plane
WG of the IETF.
>
>         Title           : A Yang Data Model for L1 Connectivity
Service Model (L1CSM)
>         Authors         : G. Fioccola
>                           K. Lee
>                           Y. Lee
>                           D. Dhody
>                           D. Ceccarelli
> Filename        : draft-ietf-ccamp-l1csm-yang-02.txt
> Pages           : 24
> Date            : 2018-06-20
>
> Abstract:
>    This document provides a YANG data model for Layer 1 Connectivity
>    Service Model (L1CSM).
>
>
>
>
> The IETF datatracker status page for this draft is:
> https://datatracker.ietf.org/doc/draft-ietf-ccamp-l1csm-yang/
>
> There are also htmlized versions available at:
> https://tools.ietf.org/html/draft-ietf-ccamp-l1csm-yang-02
> https://datatracker.ietf.org/doc/html/draft-ietf-ccamp-l1csm-yang-02
>
> A diff from the previous version is available at:
> https://www.ietf.org/rfcdiff?url2=draft-ietf-ccamp-l1csm-yang-02
>
>
> Please note that it may take a couple of minutes from the time of
submission until the htmlized version and diff are available at
tools.ietf.org.
>
> Internet-Drafts are also available by anonymous FTP at:
> ftp://ftp.ietf.org/internet-drafts/
>
> _______________________________________________
> CCAMP mailing list
> CCAMP@ietf.org
> https://www.ietf.org/mailman/listinfo/ccamp
>
> _______________________________________________
> CCAMP mailing list
> CCAMP@ietf.org
> https://www.ietf.org/mailman/listinfo/ccamp