Re: [CCAMP] I-D Action: draft-ietf-ccamp-wson-yang-18.txt

Hi Tom,

Thanks for your further comment. It is well noted and agreed. Please see inline for additional comment. 

Thanks.
You ng

-----Original Message-----
From: tom petch [mailto:ietfc@btconnect.com] 
Sent: Friday, December 7, 2018 6:49 AM
To: Leeyoung <leeyoung@huawei.com>; ccamp@ietf.org
Subject: Re: [CCAMP] I-D Action: draft-ietf-ccamp-wson-yang-18.txt

----- Original Message -----
From: "Leeyoung" <leeyoung@huawei.com>
To: <ccamp@ietf.org>
Sent: Wednesday, December 05, 2018 5:23 PM
>
> This revision, we hope, incorporated all comments from Tom and others.
The co-authors believe that it is ready for WG LC.

Almost but I fear that there is a step backwards as well.

You still have two
Wavelenghth
which should probably be
Wavelength

YL>> Yes, thanks for catching this. 

More problematically, you have introduced

  description
    " ...
     The YANG model described in this document is a WSON
     technology-specific YANG model augmenting the generic TE
     topology module [TE-TOPO] based on the information model
     developed in [RFC7446] and the two encoding documents
     [RFC7581] and [RFC7579] that developed protocol independent
     encodings based on [RFC7446].

Those [RFC..] look like XML/HTML style references which will not do.  A YANG module must be plain text so
  RFC6163
is fine in a YANG module but
  [RFC6163]
is not, which is why, in my last comment, I suggested putting a reference to RFC6163 in section 1.4 lest you get an unused reference for the I-D; which you have done, so that is fine, but all those [RFC...] in the YANG module must go.  AFAICS it is only the description clause that has them.

YL>> OK. Will remove the reference brackets within the YANG modules. 

For TE-TOPO, you need to use the same text as you have correctly done on the YANG import statement i.e.

 "RFC YYYY: YANG Data Model for Traffic Engineering (TE) Topologies";

/* Note: The RFC Editor will replace YYYY with the number assigned to the RFC once draft-ietf-teas-yang-te-topo becomes an RFC.*/

YL>> OK. 

Whether this is fixed before or after Last Call is one for the WG Chairs.

I probably said before that the nature of the module, which you are forced to use because of the way that tet: is structured, makes the module very hard to read and that I have not done; I hope to but may never find the time.

YL>> Yes, we are augmenting all groupings from TE-topo model which is in the RFC Editor's Queue now and any fix should've been done before this stage. 

Tom Petch

> Thanks & best regards,
> Young
>
> -----Original Message-----
> From: CCAMP [mailto:ccamp-bounces@ietf.org] On Behalf Of
internet-drafts@ietf.org
> Sent: Wednesday, December 5, 2018 11:18 AM
> To: i-d-announce@ietf.org
> Cc: ccamp@ietf.org
> Subject: [CCAMP] I-D Action: draft-ietf-ccamp-wson-yang-18.txt
>
>
> A New Internet-Draft is available from the on-line Internet-Drafts
directories.
> This draft is a work item of the Common Control and Measurement Plane
WG of the IETF.
>
>         Title           : A YANG Data Model for WSON (Wavelength
Switched Optical Networks)
>         Authors         : Young Lee
>                           Dhruv Dhody
>                           Aihua Guo
>                           Victor Lopez
>                           Daniel King
> Filename        : draft-ietf-ccamp-wson-yang-18.txt
> Pages           : 77
> Date            : 2018-12-05
>
> Abstract:
>    This document provides a YANG data model for the routing and
>    wavelength assignment (RWA) TE topology in wavelength switched
>    optical networks (WSONs). The YANG data model defined in this
>    document conforms to the Network Management Datastore Architecture
>    defined in RFC 8342.
>
>
> The IETF datatracker status page for this draft is:
> https://datatracker.ietf.org/doc/draft-ietf-ccamp-wson-yang/
>
> There are also htmlized versions available at:
> https://tools.ietf.org/html/draft-ietf-ccamp-wson-yang-18
> https://datatracker.ietf.org/doc/html/draft-ietf-ccamp-wson-yang-18
>
> A diff from the previous version is available at:
> https://www.ietf.org/rfcdiff?url2=draft-ietf-ccamp-wson-yang-18
>
>
> Please note that it may take a couple of minutes from the time of
submission until the htmlized version and diff are available at tools.ietf.org.
>
> Internet-Drafts are also available by anonymous FTP at:
> ftp://ftp.ietf.org/internet-drafts/
>
> _______________________________________________
> CCAMP mailing list
> CCAMP@ietf.org
> https://www.ietf.org/mailman/listinfo/ccamp
>
> _______________________________________________
> CCAMP mailing list
> CCAMP@ietf.org
> https://www.ietf.org/mailman/listinfo/ccamp