Re: [CCAMP] I-D Action: draft-ietf-ccamp-wson-yang-18.txt

Leeyoung <leeyoung@huawei.com> Fri, 14 December 2018 15:22 UTC

Return-Path: <leeyoung@huawei.com>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B9977130DE5 for <ccamp@ietfa.amsl.com>; Fri, 14 Dec 2018 07:22:25 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.599
X-Spam-Level:
X-Spam-Status: No, score=-1.599 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HK_RANDOM_ENVFROM=0.001, HK_RANDOM_FROM=1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yCzdPr17Dytu for <ccamp@ietfa.amsl.com>; Fri, 14 Dec 2018 07:22:24 -0800 (PST)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D9D46130E25 for <ccamp@ietf.org>; Fri, 14 Dec 2018 07:22:23 -0800 (PST)
Received: from lhreml701-cah.china.huawei.com (unknown [172.18.7.108]) by Forcepoint Email with ESMTP id B5F2842C7A7C9 for <ccamp@ietf.org>; Fri, 14 Dec 2018 15:22:19 +0000 (GMT)
Received: from SJCEML701-CHM.china.huawei.com (10.208.112.40) by lhreml701-cah.china.huawei.com (10.201.108.42) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 14 Dec 2018 15:22:20 +0000
Received: from SJCEML521-MBX.china.huawei.com ([169.254.1.179]) by SJCEML701-CHM.china.huawei.com ([169.254.3.191]) with mapi id 14.03.0415.000; Fri, 14 Dec 2018 07:22:15 -0800
From: Leeyoung <leeyoung@huawei.com>
To: tom petch <ietfc@btconnect.com>, "ccamp@ietf.org" <ccamp@ietf.org>
Thread-Topic: [CCAMP] I-D Action: draft-ietf-ccamp-wson-yang-18.txt
Thread-Index: AQHUjL6hoFeFYc4MWU+jA66sTwaQxKV+ZaiA
Date: Fri, 14 Dec 2018 15:22:14 +0000
Message-ID: <7AEB3D6833318045B4AE71C2C87E8E173D0AA196@sjceml521-mbx.china.huawei.com>
References: <154403028111.31922.11742637644752499043@ietfa.amsl.com> <7AEB3D6833318045B4AE71C2C87E8E173D0A03A9@SJCEML521-MBB.china.huawei.com> <002301d48e2a$d9dd0be0$4001a8c0@gateway.2wire.net>
In-Reply-To: <002301d48e2a$d9dd0be0$4001a8c0@gateway.2wire.net>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.192.11.123]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/ccamp/T2hhONkZtkdGnq3BXYOm4RVdfQM>
Subject: Re: [CCAMP] I-D Action: draft-ietf-ccamp-wson-yang-18.txt
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Dec 2018 15:22:30 -0000

Hi Tom,

Thanks for your further comment. It is well noted and agreed. Please see inline for additional comment. 

Thanks.
You ng

-----Original Message-----
From: tom petch [mailto:ietfc@btconnect.com] 
Sent: Friday, December 7, 2018 6:49 AM
To: Leeyoung <leeyoung@huawei.com>;; ccamp@ietf.org
Subject: Re: [CCAMP] I-D Action: draft-ietf-ccamp-wson-yang-18.txt

----- Original Message -----
From: "Leeyoung" <leeyoung@huawei.com>;
To: <ccamp@ietf.org>;
Sent: Wednesday, December 05, 2018 5:23 PM
>
> This revision, we hope, incorporated all comments from Tom and others.
The co-authors believe that it is ready for WG LC.

Almost but I fear that there is a step backwards as well.

You still have two
Wavelenghth
which should probably be
Wavelength

YL>> Yes, thanks for catching this. 

More problematically, you have introduced

  description
    " ...
     The YANG model described in this document is a WSON
     technology-specific YANG model augmenting the generic TE
     topology module [TE-TOPO] based on the information model
     developed in [RFC7446] and the two encoding documents
     [RFC7581] and [RFC7579] that developed protocol independent
     encodings based on [RFC7446].

Those [RFC..] look like XML/HTML style references which will not do.  A YANG module must be plain text so
  RFC6163
is fine in a YANG module but
  [RFC6163]
is not, which is why, in my last comment, I suggested putting a reference to RFC6163 in section 1.4 lest you get an unused reference for the I-D; which you have done, so that is fine, but all those [RFC...] in the YANG module must go.  AFAICS it is only the description clause that has them.

YL>> OK. Will remove the reference brackets within the YANG modules. 

For TE-TOPO, you need to use the same text as you have correctly done on the YANG import statement i.e.

 "RFC YYYY: YANG Data Model for Traffic Engineering (TE) Topologies";

/* Note: The RFC Editor will replace YYYY with the number assigned to the RFC once draft-ietf-teas-yang-te-topo becomes an RFC.*/

YL>> OK. 

Whether this is fixed before or after Last Call is one for the WG Chairs.

I probably said before that the nature of the module, which you are forced to use because of the way that tet: is structured, makes the module very hard to read and that I have not done; I hope to but may never find the time.

YL>> Yes, we are augmenting all groupings from TE-topo model which is in the RFC Editor's Queue now and any fix should've been done before this stage. 

Tom Petch

> Thanks & best regards,
> Young
>
> -----Original Message-----
> From: CCAMP [mailto:ccamp-bounces@ietf.org] On Behalf Of
internet-drafts@ietf.org
> Sent: Wednesday, December 5, 2018 11:18 AM
> To: i-d-announce@ietf.org
> Cc: ccamp@ietf.org
> Subject: [CCAMP] I-D Action: draft-ietf-ccamp-wson-yang-18.txt
>
>
> A New Internet-Draft is available from the on-line Internet-Drafts
directories.
> This draft is a work item of the Common Control and Measurement Plane
WG of the IETF.
>
>         Title           : A YANG Data Model for WSON (Wavelength
Switched Optical Networks)
>         Authors         : Young Lee
>                           Dhruv Dhody
>                           Aihua Guo
>                           Victor Lopez
>                           Daniel King
> Filename        : draft-ietf-ccamp-wson-yang-18.txt
> Pages           : 77
> Date            : 2018-12-05
>
> Abstract:
>    This document provides a YANG data model for the routing and
>    wavelength assignment (RWA) TE topology in wavelength switched
>    optical networks (WSONs). The YANG data model defined in this
>    document conforms to the Network Management Datastore Architecture
>    defined in RFC 8342.
>
>
> The IETF datatracker status page for this draft is:
> https://datatracker.ietf.org/doc/draft-ietf-ccamp-wson-yang/
>
> There are also htmlized versions available at:
> https://tools.ietf.org/html/draft-ietf-ccamp-wson-yang-18
> https://datatracker.ietf.org/doc/html/draft-ietf-ccamp-wson-yang-18
>
> A diff from the previous version is available at:
> https://www.ietf.org/rfcdiff?url2=draft-ietf-ccamp-wson-yang-18
>
>
> Please note that it may take a couple of minutes from the time of
submission until the htmlized version and diff are available at tools.ietf.org.
>
> Internet-Drafts are also available by anonymous FTP at:
> ftp://ftp.ietf.org/internet-drafts/
>
> _______________________________________________
> CCAMP mailing list
> CCAMP@ietf.org
> https://www.ietf.org/mailman/listinfo/ccamp
>
> _______________________________________________
> CCAMP mailing list
> CCAMP@ietf.org
> https://www.ietf.org/mailman/listinfo/ccamp