Re: [CCAMP] WG Last Call: WSON documents - draft-ietf-ccamp-general-constraint-encode

Lou Berger <lberger@labn.net> Thu, 30 January 2014 13:46 UTC

Return-Path: <lberger@labn.net>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8CC421A0270 for <ccamp@ietfa.amsl.com>; Thu, 30 Jan 2014 05:46:19 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.667
X-Spam-Level:
X-Spam-Status: No, score=-1.667 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, IP_NOT_FRIENDLY=0.334, SPF_PASS=-0.001] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dD5k_b_bNmOf for <ccamp@ietfa.amsl.com>; Thu, 30 Jan 2014 05:46:18 -0800 (PST)
Received: from oproxy16-pub.mail.unifiedlayer.com (oproxy16-pub.mail.unifiedlayer.com [69.89.22.201]) by ietfa.amsl.com (Postfix) with SMTP id 229DF1A026C for <ccamp@ietf.org>; Thu, 30 Jan 2014 05:46:18 -0800 (PST)
Received: (qmail 18804 invoked by uid 0); 30 Jan 2014 13:46:11 -0000
Received: from unknown (HELO box313.bluehost.com) (69.89.31.113) by oproxy16.mail.unifiedlayer.com with SMTP; 30 Jan 2014 13:46:11 -0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=labn.net; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Subject:To:MIME-Version:From:Date:Message-ID; bh=OMl/J9gKk9WxLpXbrBoaafB+UKo1qSAQpfjM4PY6H2s=; b=KkK+I/GWNf0MxpDkIVs+mXA10j5+iLH5aqOAaBIFCOTGzsFljaE3KaqQkU3m64imXL4X9GVSh49JU5135grGrBIGN3a4SrxszIzPaDqNnLcijbbeKzd7evACopRUJ8FO;
Received: from box313.bluehost.com ([69.89.31.113]:40639 helo=[127.0.0.1]) by box313.bluehost.com with esmtpa (Exim 4.80) (envelope-from <lberger@labn.net>) id 1W8rwZ-0004V3-3G; Thu, 30 Jan 2014 06:46:11 -0700
Message-ID: <52EA579F.2020800@labn.net>
Date: Thu, 30 Jan 2014 08:46:07 -0500
From: Lou Berger <lberger@labn.net>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0
MIME-Version: 1.0
To: Leeyoung <leeyoung@huawei.com>, CCAMP <ccamp@ietf.org>, "draft-ietf-ccamp-general-constraint-encode@tools.ietf.org" <draft-ietf-ccamp-general-constraint-encode@tools.ietf.org>
References: <524AF9A9.3040006@labn.net> <5266E138.8080605@labn.net> <526FFDF8.1060101@labn.net> <7AEB3D6833318045B4AE71C2C87E8E17291E3DF3@dfweml511-mbs.china.huawei.com> <52DD7EA6.2030200@labn.net> <7AEB3D6833318045B4AE71C2C87E8E1729BB456E@dfweml706-chm.china.huawei.com> <52E830AA.3060503@labn.net> <7AEB3D6833318045B4AE71C2C87E8E1729BB4FFC@dfweml706-chm.china.huawei.com>
In-Reply-To: <7AEB3D6833318045B4AE71C2C87E8E1729BB4FFC@dfweml706-chm.china.huawei.com>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Identified-User: {1038:box313.bluehost.com:labnmobi:labn.net} {sentby:smtp auth 69.89.31.113 authed with lberger@labn.net}
Subject: Re: [CCAMP] WG Last Call: WSON documents - draft-ietf-ccamp-general-constraint-encode
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jan 2014 13:46:19 -0000

Young,

Looks good to me.

Much thanks,
Lou

On 1/30/2014 1:26 AM, Leeyoung wrote:
> Hi Lou,
> 
> Please see inline for my comments. Here's working version draft-ietf-ccamp-general-constraint-encode-14 and the idnits results. 
> 
> Let me know if this is ready to publish.
> 
> Thanks.
> Young
> 
> -----Original Message-----
> From: Lou Berger [mailto:lberger@labn.net] 
> Sent: Tuesday, January 28, 2014 4:35 PM
> To: Leeyoung; CCAMP; draft-ietf-ccamp-general-constraint-encode@tools.ietf.org
> Subject: Re: [CCAMP] WG Last Call: WSON documents - draft-ietf-ccamp-general-constraint-encode
> 
> Young,
> 
> 
> On 1/27/2014 8:04 PM, Leeyoung wrote:
>> Hi Lou,
>>
>> All missing references are added. 
>>
>> Yes, the "second 32 bit field is referring to "Additional fields as necessary per action" field shown on page 14."
>>
>> Old: The second 32 bit field is a part of the base label used as a starting point in many of the specific formats.
>> New: The second 32 bit field (which is referred to by "Additional fields as necessary per action" in the below encoding) is a part of the base label used in many of the specific formats.
> 
> Well, this still isn't clear as the packet diagram doesn't show a 32 bit field, it shows a variable length one.  How about:
> OLD
>   The second 32 bit field (which is referred to by "Additional fields
>    as necessary per action" in the below encoding) is a part of the
>    base label used in many of the specific formats.
>  and
>      +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>      |      Additional fields as necessary per action                |
>      |                                                               |
> 
> NEW
>    Action specific fields are defined below.
>  and
>      +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>      |                   (Action specific fields)                    |
>      |                            ....                               |
>      +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> 
> YOUNG>> This is fine with me. Accepted. 
> 
> 
> Also, just noticed:
> 2.2.3. LABEL_RANGE1
> 
> What does the 1 indicate in the name?
> 
> YOUNG>> Deleted "1". 
> 
> Much thanks,
> Lou
> 
>>
>> Attached is a working version of draft-ietf-ccamp-general-constraint-encode-14.txt. 
>>
>> Let me know if this is ready to publish.
>>
>> Regards,
>> Young
>>
>> -----Original Message-----
>> From: Lou Berger [mailto:lberger@labn.net]
>> Sent: Monday, January 20, 2014 1:53 PM
>> To: Leeyoung; CCAMP; 
>> draft-ietf-ccamp-general-constraint-encode@tools.ietf.org
>> Subject: Re: [CCAMP] WG Last Call: WSON documents - 
>> draft-ietf-ccamp-general-constraint-encode
>>
>> Young, (all),
>>
>> You have two idnit issues:
>>   == Missing Reference: 'RWA-INFO' is mentioned on line 198, but not defined
>>   == Missing Reference: 'RFC 6205' is mentioned on line 779, but not 
>> defined
>>
>> I have just one question on this one:
>>
>>> - section 2.2.
>>>    Labels are variable in lengh and need not be 4 bytes long.  This
>>>    needs to be represented and accounted for in the encodings defined
>>>    in this section.
>>>
>>> YOUNG>> Agreed. Added the following sentence in Section 2.6 (new section due to shuffling):
>>>    "Labels are variable in length. The second 32 bit field is a part of the base label used as a
>>>    starting point in many of the specific formats."
>>>
>>
>> I don't understand what you mean by the "second 32 bit field" are you referring to the " Additional fields as necessary per action" field shown on page 14?
>>
>> Thanks,
>>
>> Lou
>>