[CCAMP] Benjamin Kaduk's Discuss on draft-ietf-ccamp-mw-yang-10: (with DISCUSS and COMMENT)
Benjamin Kaduk <kaduk@mit.edu> Wed, 24 October 2018 16:38 UTC
Return-Path: <kaduk@mit.edu>
X-Original-To: ccamp@ietf.org
Delivered-To: ccamp@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id CFC49126DBF; Wed, 24 Oct 2018 09:38:12 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Benjamin Kaduk <kaduk@mit.edu>
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-ccamp-mw-yang@ietf.org, Fatai Zhang <zhangfatai@huawei.com>, ccamp-chairs@ietf.org, zhangfatai@huawei.com, ccamp@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.87.1
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <154039909284.6959.3022479150712399029.idtracker@ietfa.amsl.com>
Date: Wed, 24 Oct 2018 09:38:12 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/ccamp/bloaSaz0WxEUPSYY6A9Chcao0zE>
Subject: [CCAMP] Benjamin Kaduk's Discuss on draft-ietf-ccamp-mw-yang-10: (with DISCUSS and COMMENT)
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Oct 2018 16:38:13 -0000
Benjamin Kaduk has entered the following ballot position for draft-ietf-ccamp-mw-yang-10: Discuss When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.) Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html for more information about IESG DISCUSS and COMMENT positions. The document, along with other ballot positions, can be found here: https://datatracker.ietf.org/doc/draft-ietf-ccamp-mw-yang/ ---------------------------------------------------------------------- DISCUSS: ---------------------------------------------------------------------- A fairly minor point, really, but several of the nodes within "container error-performance-statistics" discuss "the interval" or "a fixed measurement interval". These values are not interoperable unless the interval (or the way to determine it) is specified. My understanding is that normally this sort of counter would be using the interval since last startup, and would also track the time of last discontinuity (i.e., startup), but I am not really an expert in this area. ---------------------------------------------------------------------- COMMENT: ---------------------------------------------------------------------- Please expand TDM on first usage. leaf carrier-id { type string; default "A"; description "ID of the carrier. (e.g. A, B, C or D) Used in XPIC & MIMO configurations to check that the carrier termination is connected to the correct far-end carrier termination. Should be the same carrier ID on both sides of the hop. Defaulted when not MIMO or XPIC."; } nit: I think the "Defaulted when" statement might be better as "Left as default value when MIMO and XPIC are not in use" Alternately, only expose the node under the appropriate if-features? choice freq-or-distance { [...] description "A choice to configure rx-frequency directly or by computing it as tx-frequency subtracted with the configured duplex-distance." ; } nit: what does "subtracted with" mean? Normally I see "subtract A from B" to indicate which operand is added with negation. , but I am not really an expert in this area.ow was the range of -99 to 99 dBm for the maximum-nominal-power/actual-transmitted-level/etc. nodes selected? Similarly, is there a physical limit that makes -20dBm the cap for actual-received-level? Even if I have an unrealistic situation of the antennas separated by just a meter or two? (Other nodes, e.g., max-rltm, may have similar questions posed, too.) leaf bbe { type yang:counter32; units "number of block errors"; description "Number of Background Block Errors (BBE) during the interval. A BBE is an errored block not occurring as part of an SES."; SES is not expanded until two leafs later. Section 7 nit: I know this is the standard boilerplate, but in: The YANG module specified in this document defines a schema for data that is designed to be accessed via network management protocols such we have a singular/plural mismatch, since this document specifies multiple YANG modules, which define schemas for data, and are designed to be accessed[...]. Interfaces of type radio-link-terminal: /if:interfaces/if:interface/carrier-terminations, /if:interfaces/if:interface/rlp-groups, /if:interfaces/if:interface/xpic-pairs, /if:interfaces/if:interface/mimo-groups, and /if:interfaces/if:interface/tdm-connections: not the 'mode' sibling as well? Appendix A I guess this is really a matter of style, so arguably I shouldn't be saying anything, but it is a bit confusing to me to have the '-' present in the identifiers for the boxes in the figures (e.g., "Carrier Termination -1", "Radio Link Terminal -B") -- I see that the '-' is present as a separator in the actual YANG field data, but humans can typically add/remove the separator as needed. (Also, the figures are inconsistent about whether it's "- A" or "-A".)
- [CCAMP] Benjamin Kaduk's Discuss on draft-ietf-cc… Benjamin Kaduk
- Re: [CCAMP] Benjamin Kaduk's Discuss on draft-iet… Jonas Ahlberg
- Re: [CCAMP] Benjamin Kaduk's Discuss on draft-iet… Benjamin Kaduk
- Re: [CCAMP] Benjamin Kaduk's Discuss on draft-iet… Jonas Ahlberg
- Re: [CCAMP] Benjamin Kaduk's Discuss on draft-iet… Benjamin Kaduk