Re: [CCAMP] comments/questions on draft-ietf-ccamp-lsp-attribute-ro
Cyril Margaria <cyril.margaria@gmail.com> Fri, 24 October 2014 16:37 UTC
Return-Path: <cyril.margaria@gmail.com>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B48371A6F97 for <ccamp@ietfa.amsl.com>; Fri, 24 Oct 2014 09:37:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V4levdMQm2ms for <ccamp@ietfa.amsl.com>; Fri, 24 Oct 2014 09:37:43 -0700 (PDT)
Received: from mail-wg0-x22f.google.com (mail-wg0-x22f.google.com [IPv6:2a00:1450:400c:c00::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 27A8C1A6F8D for <ccamp@ietf.org>; Fri, 24 Oct 2014 09:37:43 -0700 (PDT)
Received: by mail-wg0-f47.google.com with SMTP id x13so1469065wgg.18 for <ccamp@ietf.org>; Fri, 24 Oct 2014 09:37:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=YWYkVVipZjl+keZZK0YRt2XEX5nYRYL6LlugVgTUf4w=; b=0QEGekyYymmIOiPrqetipMMziXjsFpWS62H3tnArAM+koSHtzcRymxZ2pvfbi20eyc QSOTjuKMBzwohy+78h32MCslXtHSi5xYe5YwofAv88rSd69p7jRWC9l9/CI8cyVacbc+ 2B0miSnotmqk6sNM9fERPjDq1vCLFrVItuHWE8O/xjf4mLMOO4cl8eaOHImSeiiPVHPP vKXauv84Ezg3TzRNuoQVElfxn++xIzX5mffNPP4+JKfMSo8YiQjHQ81QbTZxcoZu5Xmc 3OPuwhyXM6qGOI1dPMvEi1uKcriH1bFJ5BcKNP4bqtYgVoC/DNQtoYuQSA6mDXi6xRsn uigA==
MIME-Version: 1.0
X-Received: by 10.180.149.169 with SMTP id ub9mr5267154wib.73.1414168661639; Fri, 24 Oct 2014 09:37:41 -0700 (PDT)
Received: by 10.217.170.134 with HTTP; Fri, 24 Oct 2014 09:37:41 -0700 (PDT)
In-Reply-To: <542F01CD.9020709@labn.net>
References: <542F01CD.9020709@labn.net>
Date: Fri, 24 Oct 2014 12:37:41 -0400
Message-ID: <CADOd8-uVS4VyDyAgY8_Wu0oFGd_cteKXt++og8hcQVYaGXCXKg@mail.gmail.com>
From: Cyril Margaria <cyril.margaria@gmail.com>
To: Lou Berger <lberger@labn.net>
Content-Type: multipart/alternative; boundary="001a11c38aeabac95605062dccab"
Archived-At: http://mailarchive.ietf.org/arch/msg/ccamp/cdcHAcTXj8NYYQQsN57-7Zf0hAc
Cc: "<draft-ietf-ccamp-lsp-attribute-ro@tools.ietf.org>" <draft-ietf-ccamp-lsp-attribute-ro@tools.ietf.org>, CCAMP <ccamp@ietf.org>
Subject: Re: [CCAMP] comments/questions on draft-ietf-ccamp-lsp-attribute-ro
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Oct 2014 16:37:46 -0000
Hi, Thank you for the comments, we believe we did address all of them in the new version we posted: URL: http://www.ietf.org/internet-drafts/draft-ietf-ccamp-lsp-attribute-ro-05.txt Status: https://datatracker.ietf.org/doc/draft-ietf-ccamp-lsp-attribute-ro/ Htmlized: http://tools.ietf.org/html/draft-ietf-ccamp-lsp-attribute-ro-05 please find answers to individual comments inline. Best Regards, Cyril On 3 October 2014 16:06, Lou Berger <lberger@labn.net> wrote: > Hi, > At the last meeting it was mentioned that folks should take a look > at > draft-ietf-ccamp-lsp-attribute-ro in anticipation of an upcoming LC. > Consequently, I took a re look at the document and have some > comments/questions (for authors/contributors/WG/...): > > - You have a couple of editorial notes in the document, do these still > apply or should they be dropped. > > They should be dropped, we cleaned-up the notes. > - There are cases where you use 2114 language in lower case (e.g., > section 3.1). As I've mentioned before on the list, such usage, even > when correct, often leads to unneeded discussion during IESG review, I'd > suggest avoiding lower cases usage wherever possible. That said, I > think you have some cases where upper case was intended. > > We changed the language to be RFC2114 compliant. > - In section 3.1, 3.3 you are giving the definition for fields (length > and type) that are defined in 3209. You should just point to that > definition rather than seeming to provide the authoritative definition > in this document. > > Agree > - In section 3.2, you are similarly doing this for the Attribute TLV > defined in section 3 of 5420. Why not just include the reference and > the (re)definition? > > Agree > - Section 4. Isn't recording applicable to required attributes as well? > I.e.,why no R bit recording in section 4.1? > > RFC5420 does not make that distinction in the RRO attribute subobject, In addition the R bit is known to the node that inserted that ERO subobject and the requiered presence of the attribute depends on the given attribute. For those reasons we did include the R bit in the RRO_HOP_ATTRIBUTE. If there is a use case for it, we will include it. > - I think it would be good to have a compatibility section / discussion > which should at least discuss how to deal with the now two ways to > encode / record attribute flags. -- This document could replace > (deprecate) the old way, but this document would then need to be an > update to 5420... > > We added a section on compatibility. We see that both are compatible, the RFC5420 one should be used to report if an RFC5420 attribute has been processed, a node is allowed to use RRO_HOP attribute to report a LSP attribute value, but this must be in addition to the RFC5420 RRO attribute recording. for ro attributes, the node SHOULD use the RRO_HOP and SHOULD NOT use the RFC5420 mechanism if no LSP_ATTRIBUTE is present. > - The IANA section needs to be updated with the proper format. See > RFC5226. draft-ietf-ccamp-rsvp-te-srlg-collect-07 is good example (but > don't include values and use the non-xml version of the registry links.) > > We updated the IANA section to match more closely the register format. > - Section 6 won't make it through the IESG. Again > draft-ietf-ccamp-rsvp-te-srlg-collect-07 is good example of recent > language produced by the WG, and is a fine starting point. > > We filled the Security section > I think that's it. > > Thanks again for your review. > Lou > > _______________________________________________ > CCAMP mailing list > CCAMP@ietf.org > https://www.ietf.org/mailman/listinfo/ccamp >
- [CCAMP] comments/questions on draft-ietf-ccamp-ls… Lou Berger
- Re: [CCAMP] comments/questions on draft-ietf-ccam… Cyril Margaria
- Re: [CCAMP] comments/questions on draft-ietf-ccam… Lou Berger