Re: [CCAMP] [Gen-art] Gen-Art LC review draft-ietf-ccamp-gmpls-ospf-g709v3-09

Daniele Ceccarelli <daniele.ceccarelli@ericsson.com> Fri, 22 November 2013 11:22 UTC

Return-Path: <daniele.ceccarelli@ericsson.com>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 690521AD7C1; Fri, 22 Nov 2013 03:22:39 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.387
X-Spam-Level:
X-Spam-Status: No, score=-0.387 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001, URIBL_RHS_DOB=1.514] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EXABHhhNiZR4; Fri, 22 Nov 2013 03:22:37 -0800 (PST)
Received: from sesbmg20.ericsson.net (sesbmg20.ericsson.net [193.180.251.56]) by ietfa.amsl.com (Postfix) with ESMTP id 93EC91AE120; Fri, 22 Nov 2013 03:22:32 -0800 (PST)
X-AuditID: c1b4fb38-b7f2c8e000006d25-09-528f3e707da8
Received: from ESESSHC023.ericsson.se (Unknown_Domain [153.88.253.125]) by sesbmg20.ericsson.net (Symantec Mail Security) with SMTP id 39.A4.27941.07E3F825; Fri, 22 Nov 2013 12:22:24 +0100 (CET)
Received: from ESESSMB301.ericsson.se ([169.254.1.247]) by ESESSHC023.ericsson.se ([153.88.183.87]) with mapi id 14.02.0328.009; Fri, 22 Nov 2013 12:22:23 +0100
From: Daniele Ceccarelli <daniele.ceccarelli@ericsson.com>
To: "jari.arkko@piuha.net" <jari.arkko@piuha.net>
Thread-Topic: [CCAMP] [Gen-art] Gen-Art LC review draft-ietf-ccamp-gmpls-ospf-g709v3-09
Thread-Index: Ac7ndCxaqmAG17XGS92n4CnwVSCC4A==
Date: Fri, 22 Nov 2013 11:22:23 +0000
Message-ID: <4A1562797D64E44993C5CBF38CF1BE481260D975@ESESSMB301.ericsson.se>
Accept-Language: it-IT, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [153.88.183.18]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDLMWRmVeSWpSXmKPExsUyM+JvrW6BXX+QwbkdmhZP5txgsfjb8JrF 4uqrzywWM/atYLO4NqeRzYHVY8mSn0wes3Y+YfHYumQ6m8eXy5/ZAliiuGxSUnMyy1KL9O0S uDKe3FUu+KFS0Tt5CVsDY59cFyMnh4SAicTD5ddYIWwxiQv31rN1MXJxCAkcYZRYceAJC0hC SGAJo8SGReZdjBwcbAJWEk8O+YCERQQMJU5/u8EIUs8s0MIk8eLoIbB6YYEIif5XXxkhiiIl Lp27ww5h60lcmb6AGWQOi4CqxKZXtiBhXgFfiX9//zGD2IwCshITdi8Ca2UWEJe49WQ+E8Rt AhJL9pxnhrBFJV4+/gd1s6LEx1f7oOr1JG5MncIGYWtLLFv4mhlivqDEyZlPWCYwisxCMnYW kpZZSFpmIWlZwMiyipGjOLU4KTfdyGATIzBGDm75bbGD8fJfm0OM0hwsSuK8H986BwkJpCeW pGanphakFsUXleakFh9iZOLglGpgzPQpWnJz5zdVBb5Hy26one3dcezUEi6FY+/FtYxbD5qv /FAc8+l+g+fv3zts7votssi8/Wmdw+3LU7Y7NG/7eWhvmmKpKaMQl2vRhyfv32VV9hbWvXs9 Z52K+Mo/axtOfNGcmbN4mfeaGwvnzz8R8Ztbw6So+I1Hc/jNTK4XJ2+8Nd4umW77XkOJpTgj 0VCLuag4EQAgu6NMXwIAAA==
Cc: "gen-art@ietf.org" <gen-art@ietf.org>, "draft-ietf-ccamp-gmpls-ospf-g709v3@tools.ietf.org" <draft-ietf-ccamp-gmpls-ospf-g709v3@tools.ietf.org>, "CCAMP (ccamp@ietf.org)" <ccamp@ietf.org>, "Robert Sparks (rjsparks@nostrum.com)" <rjsparks@nostrum.com>
Subject: Re: [CCAMP] [Gen-art] Gen-Art LC review draft-ietf-ccamp-gmpls-ospf-g709v3-09
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Nov 2013 11:22:39 -0000

Hi Jari,

Yes, you're right. When doing the modifications is missed the IANA section ones.

I just uploaded the v12 to fix it.

Many thanks
Daniele




Many thanks for your review, Robert! Daniele, thank you for the modifications. However, I do not see the IANA section modification yet in -11. But maybe I missed it. Has that been incorporated to the latest version? (I thought your text suggestion looked fine.)

Jari

On Oct 15, 2013, at 5:21 AM, Daniele Ceccarelli <daniele.ceccarelli at ericsson.com> wrote:

> Hi Robert,
>  
> Many thanks for your review. Please find comments/replies in line.
>  
> BR
> Daniele (& co-authors)
>  
> From: Robert Sparks [mailto:rjsparks at nostrum.com] 
> Sent: venerdì 11 ottobre 2013 17:16
> To: General Area Review Team; ccamp at ietf.org; draft-ietf-ccamp-gmpls-ospf-g709v3 at tools.ietf.org
> Subject: Gen-Art LC review draft-ietf-ccamp-gmpls-ospf-g709v3-09
>  
> I am the assigned Gen-ART reviewer for this draft. For background on 
> Gen-ART, please see the FAQ at 
> 
> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. 
> 
> Please resolve these comments along with any other Last Call comments 
> you may receive. 
> 
> Document: draft-ietf-ccamp-gmpls-ospf-g709v3-09
> Reviewer: Robert Sparks
> Review Date: 11-Oct-2013
> IETF LC End Date: 16-Oct-2013
> IESG Telechat date: Not yet scheduled for a telechat
> 
> Summary: This draft is basically ready for publication, but has nits that should be fixed before publication.
> 
> This document is dense (as in it puts a lot of information in a small number of characters), but it reads clearly.
> I did not carefully review the contents of the example fields for editorial mistakes - please be sure someone in the group has done that.
> 
> The largest issue I see is on the border of being more than a nit. I'm calling it a nit because it should be very easy to fix:
> The sentence "Same type of modification needs to applied to the IANA-GMPLS-TC-MIB at https://www.iana.org/assignments/ianagmplstc-mib/ianagmplstc-mib"; is not sufficient instruction to IANA to cause that registry to be modified. Please provide more precise
> instructions as to how this mib should change.
> 
> [[Authors]] How about the following?
> 
> OLD
> 
> Same type of modification needs to applied to the IANA-GMPLS-TC-MIB at https://www.iana.org/assignments/ianagmplstc-mib/ianagmplstc-mib
> 
> NEW
> 
> Same type of modification needs to applied to the IANA-GMPLS-TC-MIB at https://www.iana.org/assignments/ianagmplstc-mib/ianagmplstc-mib, where the value
> 
> OTN-TDM (110),     -- Time-Division-Multiplex OTN-TDM capable
> 
> Will be added to the IANAGmplsSwitchingTypeTC ::= TEXTUAL-CONVENTION syntax list.
> 
> 
> 
> I note also that the value 40 from RFC6060 didn't make it into the mib.
> 
> The rest of these are more nitty nits:
> 
> ---
> In section 4, I think you've repeated a MUST, and risk introducing confusion.
> It's awkward to point to this with paragraph numbers because of the interspersed tables, so I'll quote the relevant block:
> 
>    When supporting the extensions defined in this document, the
>    Switching Capability and Encoding values MUST be used as follows:
>  
>    - Switching Capability = OTN-TDM
>    - Encoding Type = G.709 ODUk (Digital Path) as defined in [RFC4328]
>  
>    Both for fixed and flexible ODUs the same switching type and encoding
>    values MUST be used.
> If I read that correctly , those are the same MUST and you're saying it's a MUST no matter whether you're talking about fixed or flexible ODUs.
> If that's correct I suggest replacing this with:
> 
>    When supporting the extensions defined in this document, for both
>    fixed and flexible ODUs, the Switching Capability and Encoding values 
>    MUST be used as follows:
>  
>    - Switching Capability = OTN-TDM
>    - Encoding Type = G.709 ODUk (Digital Path) as defined in [RFC4328]
> (or leave out the fixed and flexible clarification altogether - I would not have been confused without it). 
> [[Authors]] Comment correct. New text adopted.
> 
> 
> ---
> 
> In section 8.2, where you say "IANA will create and maintain a new registry", I suggest you say "new sub-registry".
> [[Authors]] OK
> 
> 
> RjS
> _______________________________________________
> Gen-art mailing list
> Gen-art at ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art