[CCAMP] AD review of draft-ietf-ccamp-gmpls-signaling-g709v3

"Adrian Farrel" <adrian@olddog.co.uk> Sun, 18 August 2013 19:11 UTC

Return-Path: <adrian@olddog.co.uk>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4CFBB21F9E45 for <ccamp@ietfa.amsl.com>; Sun, 18 Aug 2013 12:11:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[AWL=-0.000, BAYES_00=-2.599]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rm8hasxcMV6S for <ccamp@ietfa.amsl.com>; Sun, 18 Aug 2013 12:11:35 -0700 (PDT)
Received: from asmtp4.iomartmail.com (asmtp4.iomartmail.com [62.128.201.175]) by ietfa.amsl.com (Postfix) with ESMTP id 3597B21F9D0D for <ccamp@ietf.org>; Sun, 18 Aug 2013 12:11:34 -0700 (PDT)
Received: from asmtp4.iomartmail.com (localhost.localdomain [127.0.0.1]) by asmtp4.iomartmail.com (8.13.8/8.13.8) with ESMTP id r7IJBX6E020142; Sun, 18 Aug 2013 20:11:33 +0100
Received: from 950129200 (dsl-sp-81-140-15-32.in-addr.broadbandscope.com [81.140.15.32]) (authenticated bits=0) by asmtp4.iomartmail.com (8.13.8/8.13.8) with ESMTP id r7IJBWin020132 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Sun, 18 Aug 2013 20:11:33 +0100
From: "Adrian Farrel" <adrian@olddog.co.uk>
To: <draft-ietf-ccamp-gmpls-signaling-g709v3.all@tools.ietf.org>
Date: Sun, 18 Aug 2013 20:11:33 +0100
Message-ID: <045e01ce9c46$c1042080$430c6180$@olddog.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-Index: Ac6cRrn+HX0rSFNVT2WODMAhTBetcA==
Content-Language: en-gb
Cc: ccamp@ietf.org
Subject: [CCAMP] AD review of draft-ietf-ccamp-gmpls-signaling-g709v3
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: adrian@olddog.co.uk
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ccamp>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Aug 2013 19:11:40 -0000

Hi,

Here is my usual AD review of this document.  You have approached a
pretty icky-complex topic well, and produced a readable (if technical)
document. Well done!

I have only a few nits as comments and propose to enter them as IETF
last-call comments as the document moves forward. (They care copied
below for your information).

The next thing you should see is the IETF last call announcement.

Thanks,
Adrian

---

Please fix the two lines that are too long (see idnits)

---

Please expand "OTN" on first use in the main text.
Please expand "TS" on its first use.

---

6.2

   The ingress node of an LSP MAY include Label ERO (Explicit Route 
   Object) to indicate the label in each hops along the path.

Missing "subobject".

---

6.2.1

   When an upstream node receives a Resv message containing an 
   GENERALIZED_LABEL object

s/an/a/

---

Please consider and note what updates to GMPLS management tools are
needed.

Are there any changes to the Alarms that might arise? We have a document
for that.

Are there any changes to the way OAM is controlled? We have a document
for that.

Should the new G-PIDs show in the TC MIB managed by IANA at
https://www.iana.org/assignments/ianagmplstc-mib/ianagmplstc-mib.xhtml
This should happen automgically when the feeding registries are updated
but it is probably best to add a specific request for IANA.

Will other MIB work be needed (in the future) to make it possible to 
read new information (labels, tspecs) from network devices?

---

Please fix so that you have three sections:

Authors' Addresses (only those people on the front page)
Contributors (other people who made significant text contributions to
the document)
Acknowledgements (other people who helped with the work)

---

[OTN-OSPF] should be a normative reference for its use to define the 
value of the switching type used in signaling.