Re: [CCAMP] WG Last Call: WSON documents - rwa-info, general-constraint-encode, rwa-wson-encode, gmpls-general-constraints-ospf-te, wson-signal-compatibility-ospf, wson-signaling

"Margaria, Cyril (Coriant - DE/Munich)" <cyril.margaria@coriant.com> Tue, 22 October 2013 10:53 UTC

Return-Path: <cyril.margaria@coriant.com>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A08AD11E8256 for <ccamp@ietfa.amsl.com>; Tue, 22 Oct 2013 03:53:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.597
X-Spam-Level:
X-Spam-Status: No, score=-4.597 tagged_above=-999 required=5 tests=[AWL=2.002, BAYES_00=-2.599, RCVD_IN_DNSWL_MED=-4]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RiJV75OFCT7B for <ccamp@ietfa.amsl.com>; Tue, 22 Oct 2013 03:53:51 -0700 (PDT)
Received: from co9outboundpool.messaging.microsoft.com (co9ehsobe005.messaging.microsoft.com [207.46.163.28]) by ietfa.amsl.com (Postfix) with ESMTP id BFDE811E8117 for <ccamp@ietf.org>; Tue, 22 Oct 2013 03:53:51 -0700 (PDT)
Received: from mail97-co9-R.bigfish.com (10.236.132.245) by CO9EHSOBE042.bigfish.com (10.236.130.105) with Microsoft SMTP Server id 14.1.225.22; Tue, 22 Oct 2013 10:53:51 +0000
Received: from mail97-co9 (localhost [127.0.0.1]) by mail97-co9-R.bigfish.com (Postfix) with ESMTP id 3768018008F for <ccamp@ietf.org>; Tue, 22 Oct 2013 10:53:51 +0000 (UTC)
X-Forefront-Antispam-Report: CIP:157.56.253.53; KIP:(null); UIP:(null); IPV:NLI; H:DB3PRD0411HT005.eurprd04.prod.outlook.com; RD:none; EFVD:NLI
X-SpamScore: -21
X-BigFish: PS-21(zzc89bh31c5Izz1f42h208ch1ee6h1de0h1fdah2073h1202h1e76h1d1ah1d2ah1fc6hzz1de098h1033IL17326ah8275dh1de097h186068h1954cbh8275bhz2fh2a8h839h947hd25hf0ah1288h12a5h12a9h12bdh137ah13b6h1441h1504h1537h153bh15d0h162dh1631h1758h18e1h1946h19b5h19ceh1ad9h1b0ah1d07h1d0ch1d2eh1d3fh1dc1h1de9h1dfeh1dffh1e1dh1fe8h1ff5h1155h)
Received-SPF: pass (mail97-co9: domain of coriant.com designates 157.56.253.53 as permitted sender) client-ip=157.56.253.53; envelope-from=cyril.margaria@coriant.com; helo=DB3PRD0411HT005.eurprd04.prod.outlook.com ; .outlook.com ;
Received: from mail97-co9 (localhost.localdomain [127.0.0.1]) by mail97-co9 (MessageSwitch) id 1382439229359746_24988; Tue, 22 Oct 2013 10:53:49 +0000 (UTC)
Received: from CO9EHSMHS007.bigfish.com (unknown [10.236.132.249]) by mail97-co9.bigfish.com (Postfix) with ESMTP id 4A6E8900067 for <ccamp@ietf.org>; Tue, 22 Oct 2013 10:53:49 +0000 (UTC)
Received: from DB3PRD0411HT005.eurprd04.prod.outlook.com (157.56.253.53) by CO9EHSMHS007.bigfish.com (10.236.130.17) with Microsoft SMTP Server (TLS) id 14.16.227.3; Tue, 22 Oct 2013 10:53:49 +0000
Received: from DB3PRD0411MB427.eurprd04.prod.outlook.com ([169.254.6.169]) by DB3PRD0411HT005.eurprd04.prod.outlook.com ([10.255.73.40]) with mapi id 14.16.0371.000; Tue, 22 Oct 2013 10:53:48 +0000
From: "Margaria, Cyril (Coriant - DE/Munich)" <cyril.margaria@coriant.com>
To: "CCAMP (ccamp@ietf.org)" <ccamp@ietf.org>
Thread-Topic: Re: [CCAMP] WG Last Call: WSON documents - rwa-info, general-constraint-encode, rwa-wson-encode, gmpls-general-constraints-ospf-te, wson-signal-compatibility-ospf, wson-signaling
Thread-Index: Ac7PFPsDhmt/uF1bTWymUSOtwlOYqw==
Date: Tue, 22 Oct 2013 10:53:47 +0000
Message-ID: <523C37072C291347B9730C9291CCA07D02DE3549@DB3PRD0411MB427.eurprd04.prod.outlook.com>
Accept-Language: fr-FR, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [62.159.77.167]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: coriant.com
X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn%
X-Mailman-Approved-At: Tue, 22 Oct 2013 06:17:49 -0700
Subject: Re: [CCAMP] WG Last Call: WSON documents - rwa-info, general-constraint-encode, rwa-wson-encode, gmpls-general-constraints-ospf-te, wson-signal-compatibility-ospf, wson-signaling
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ccamp>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Oct 2013 10:55:30 -0000

http://tools.ietf.org/html/draft-ietf-ccamp-rwa-info-18

I've reviewed this document and believe it is ready for publication, with comments:
I think the document is good to go, I have two editorial comments:
 - I find the document history good to have, but maybe in an annex.
 - My stable mail address is cyril.margaria@gmail.com , affiliation is Coriant.

http://tools.ietf.org/html/draft-ietf-ccamp-general-constraint-encode-11

I've reviewed this document and believe it is ready for publication, with comment:
I have the same comment as the rwa info regarding the history to be maybe moved to the annex 

http://tools.ietf.org/html/draft-ietf-ccamp-rwa-wson-encode-21

I've reviewed this document and believe it is ready for publication, with comments:
- editorial: The document history could be moved to the annex 
- section 3.3 : rbState (16 bit) : nits : is it signed or unsigned integer ? I would tend to understand unsigned.
- My stable mail address is cyril.margaria@gmail.com , affiliation is Coriant, not NSN

http://tools.ietf.org/html/draft-ietf-ccamp-gmpls-general-constraints-ospf-te-05

I've reviewed this document and believe it is ready for publication

http://tools.ietf.org/html/draft-ietf-ccamp-wson-signal-compatibility-ospf-12

I've reviewed this document and believe it is ready for publication, with comments:
- editorial: The document history could be moved to the annex 
- Section 2 : the section reference to WSON-Encode are wrong (this affect section 2, section 2.1
- Section 3 : it would be useful to reference the exact section of [Gen-encode] for the Available Label Sub-TLV and  Shared Backup Label Sub-TLV. 

http://tools.ietf.org/html/draft-ietf-ccamp-wson-signaling-06 
I've reviewed this document and I have the following comments:
 - section 4.3 : "If more than two objects are encountered,
   two MUST be processed and the rest SHOULD be ignored."
	This is ambiguous : the section refers to the RB information sub tlv, does this refers to the WSON_signaling object or RBInformation?
 - section 4.3 : http://trac.tools.ietf.org/wg/ccamp/trac/ticket/52, please remove this paragraph, the restriction is strong and would not allow a node to choose one RB per local policy /sharing.. etc
 - section 7 : the section assume a LSP_REQUIRED_ATTRIBUTE, but this is a targeted information as described in section 4.2, or should it be distinguished between targeted attribute (to be assigned in the ERO HOP_attribut, this depends on the space choosen by the draft-ietf-ccamp-lsp-attribute-ro) and e2e attribute (WA)?.
 

Best Regards/ Mit freundlichen Grüßen
Cyril Margaria

cyril.margaria@gmail.com
http://www.coriant.com

Coriant R&D GmbH
Geschäftsleitung / Board of Directors: Robert Richter, Rolf Nauerz 
Sitz der Gesellschaft: München / Registered office: Munich
Registergericht: München / Commercial registry: Munich, HRB 197143