[CCAMP] A review of draft-ietf-ccamp-flexigrid-yang
Adrian Farrel <adrian@olddog.co.uk> Thu, 24 December 2020 09:24 UTC
Return-Path: <adrian@olddog.co.uk>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7DB6D3A1116; Thu, 24 Dec 2020 01:24:37 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.896
X-Spam-Level:
X-Spam-Status: No, score=-1.896 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wIvNNlvKYoTs; Thu, 24 Dec 2020 01:24:36 -0800 (PST)
Received: from mta7.iomartmail.com (mta7.iomartmail.com [62.128.193.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C669D3A1118; Thu, 24 Dec 2020 01:24:34 -0800 (PST)
Received: from vs2.iomartmail.com (vs2.iomartmail.com [10.12.10.123]) by mta7.iomartmail.com (8.14.4/8.14.4) with ESMTP id 0BO9OXR9012541; Thu, 24 Dec 2020 09:24:33 GMT
Received: from vs2.iomartmail.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E97382204C; Thu, 24 Dec 2020 09:24:32 +0000 (GMT)
Received: from asmtp1.iomartmail.com (unknown [10.12.10.248]) by vs2.iomartmail.com (Postfix) with ESMTPS id DB69E22052; Thu, 24 Dec 2020 09:24:32 +0000 (GMT)
Received: from LAPTOPK7AS653V ([87.113.187.83]) (authenticated bits=0) by asmtp1.iomartmail.com (8.14.4/8.14.4) with ESMTP id 0BO9OVIh030901 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 24 Dec 2020 09:24:32 GMT
Reply-To: adrian@olddog.co.uk
From: Adrian Farrel <adrian@olddog.co.uk>
To: 'CCAMP' <ccamp@ietf.org>
Cc: draft-ietf-ccamp-flexigrid-yang@ietf.org
Date: Thu, 24 Dec 2020 09:24:32 -0000
Organization: Old Dog Consulting
Message-ID: <03b201d6d9d6$96ace3f0$c406abd0$@olddog.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AdbZ1o2+DNnOvRizQ0CycP9wKoZEvg==
Content-Language: en-gb
X-Originating-IP: 87.113.187.83
X-Thinkmail-Auth: adrian@olddog.co.uk
X-TM-AS-GCONF: 00
X-TM-AS-Product-Ver: IMSVA-9.0.0.1623-8.2.0.1013-25868.007
X-TM-AS-Result: No--5.899-10.0-31-10
X-imss-scan-details: No--5.899-10.0-31-10
X-TMASE-Version: IMSVA-9.0.0.1623-8.2.1013-25868.007
X-TMASE-Result: 10--5.899300-10.000000
X-TMASE-MatchedRID: EsGFgrCrGks/9d9Rtcc0QzjNGpWCIvfT8QCUCx466G8AIXlMppp3X5VH MRn1pNBtxx/zddJYPOYr1eX6aNt6lGhZZNLQIirOGUlF/M3Dxp/iXOoSlo9AtfteNl2n0p87dVd Df+p3DnJG7P4H2rDIUiwaVH0hcLnzYY3ozW+EngdqZ6OipRp3elsP0tBwe3qDWGzy6KaAc0KjbS jt44ojS4fPYzPi5upN8+h2uDCVWGqUMZdi2hnmAHE8DpquRinQKyD9W9BY6NZJfyfUaPjAAS9xy QrT0inisYs+qfknc+lbcMalNTqVv1zuVRUabQqpTPsVRSNcbWPtxxKdg1q1QIEBeX0uQ+npFfp/ nE2o3QudhDZUQZn1rnVYxiwxDQDxLx38t4JoaBd6a7qHolmGuToSfZud5+GggU38wRbnPPKejEx 8E/02ZaGe3mb13hctbjp++G722FLWcdASlk7lViEO3+fZxzIjYu1jAfiXSs7925yPtrh9BKPFjJ EFr+olfeZdJ1Xsorj72mXKge0hlwtuKBGekqUpI/NGWt0UYPCdIWuSdBZA9jOBRlRZ7/1tlesRt Gc47jeZgx+OlA4rCLUAzM040TIQ
X-TMASE-SNAP-Result: 1.821001.0001-0-1-12:0,22:0,33:0,34:0-0
Archived-At: <https://mailarchive.ietf.org/arch/msg/ccamp/foUbVnfpO0BsPZoBMDdT48-kURw>
Subject: [CCAMP] A review of draft-ietf-ccamp-flexigrid-yang
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Dec 2020 09:24:38 -0000
Hi, As this draft is getting close to WG last call, I thought I would give it a review. I worked on the flexi-grid control plane RFCs so I have some interest in how this draft develops. I think it is looking in good shape although there may need to be some tweaks to align with the other models that describe tunnels. Here are some suggested edits. Regards, Adrian --- 1. OLD [RFC7698] provides a framework GMPLS-Based control NEW [RFC7698] provides a framework for GMPLS-Based control END --- 1. OLD This document identifies the flexi-grid components, parameters and their values, characterizes the features and the performances of the flexi-grid elements. NEW This document identifies the flexi-grid components, parameters and their values, and it characterizes the features and the performance of the flexi-grid elements. END OLD An application example is provided towards the end of the document to better understand their utility. NEW An application example is provided towards the end of the document to better understand the utility of this YANG model. END --- I think that sections 3 and 3.1 look a bit odd how they are. How about moving them to 2.1 and 2.2 respectively. It would also be good to add a diagram showing the relationship between the various YANG modules. --- I think Figure 2 could be cleaned up a little to show that the transponders are in optical edge nodes. Possibly... Media channel <=======================================> Path x <---------------------------------------> +-----------+ +-----------+ | Optical | | Optical | | Edge | | Edge | | | | | | ........| +------+ +------+ |........ | | : | Link 1 |Flexi-| Link 2 |Flexi-| Link 3 | : | | : Flexi-|<------>| grid|<------>| grid|<------>|Flexi- : | | : grid| |node B| |node C| | grid : | | : Trans-| +------+ +------+ |Trans- : | | : ponder| |ponder : | | : A | +----------+ | E : | | : | Link 4 |Flexi-grid| Link 5 | : | | : |<------------>| node |<------------>| : | | :.......| | D | |.......: | | | +----------+ | | +-----------+ +-----------+ <---------------------------------------> Path y --- Section 4 Could you please expand "TED" on first use. s/provided on each situation/provided in each situation/ --- Section 4 We refer to [I-D.ietf-ccamp-flexigrid-media-channel-yang] to complete this example. Maybe... Details of how to configure a flexi-grid media channel can be found in [I-D.ietf-ccamp-flexigrid-media-channel-yang]. --- OLD 5. YANG Model (Tree Structure) for Flexi-grid topology NEW 5. YANG Model (Tree Structure) for Flexi-Grid Topology END --- I think three of your informative references should be moved to normative: - [I-D.ietf-ccamp-flexigrid-media-channel-yang] - [I-D.ietf-ccamp-layer0-types] - [I-D.ietf-ccamp-optical-impairment-topology-yang]
- [CCAMP] A review of draft-ietf-ccamp-flexigrid-ya… Adrian Farrel