[CCAMP] Yangdoctors last call review of draft-ietf-ccamp-otn-tunnel-model-11

Radek Krejčí via Datatracker <noreply@ietf.org> Fri, 16 October 2020 13:33 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: ccamp@ietf.org
Delivered-To: ccamp@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 720363A0F5F; Fri, 16 Oct 2020 06:33:27 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: =?utf-8?q?Radek_Krej=C4=8D=C3=AD_via_Datatracker?= <noreply@ietf.org>
To: <yang-doctors@ietf.org>
Cc: last-call@ietf.org, ccamp@ietf.org, draft-ietf-ccamp-otn-tunnel-model.all@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.20.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <160285520741.1658.15600224799776978218@ietfa.amsl.com>
Reply-To: =?utf-8?b?UmFkZWsgS3JlasSNw60=?= <rkrejci@cesnet.cz>
Date: Fri, 16 Oct 2020 06:33:27 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/ccamp/hevNlzTnh9ra4Ru0q2VwmFmMwU4>
Subject: [CCAMP] Yangdoctors last call review of draft-ietf-ccamp-otn-tunnel-model-11
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Oct 2020 13:33:27 -0000

Reviewer: Radek Krejčí
Review result: Ready with Issues

This is my yang doctor review of draft draft-ietf-ccamp-otn-tunnel-model-11
with the ietf-otn-tunnel@2020-03-09 YANG module.

Despite the size of the module, its structure is very simple repeatedly
following a pattern of augmenting ietf-te by groupings defined in
ietf-layer1-types module (except the single grouping defined in the module
itself).

Validation tools report a number of errors in the module. The problem is, that
the module references (in augments)
/te:te/te:tunnels/te:tunnel/te:p2p-primary-paths/ and
/te:te/te:tunnels/te:tunnel/te:p2p-secondary-paths/ which are not present in
current ietf-te@2020-07-12 module (the nodes were removed in
draft-ietf-teas-yang-te-23, the reference in the Section 10 of the draft is to
draft-ietf-teas-yang-te-25 but the module is not in line with this revision).
So the module needs a crucial update. Also please consider if the grouping
otn-tunnel-attributes is reusable in other modules. If the reusability is not
the concern, I don't see any reason to define it instead of specifying the
grouping content directly in the augment.

Regarding the draft, as a reader, I would appreciate a more targeted
description in section 3. Instead of just dumping the tree diagram in section
3.2, it would be useful to split it into several areas with some brief
descriptions and examples.

The list of paths is introduced in Section 6 as "the subtrees and data nodes
and their sensitivity/vulnerability", but I don't see explained/described the
mentioned sensitivity/vulnerability of those paths. Besides that, the paths
include '..' as ellipsis, but '..' has its usual meaning in paths, please unify
it with the format used in ietf-otn-topology and use '...'.