[CCAMP] Balazs Review of alarm-module-04

Balázs Lengyel <balazs.lengyel@ericsson.com> Fri, 12 October 2018 13:52 UTC

Return-Path: <balazs.lengyel@ericsson.com>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4EFC5130DE4 for <ccamp@ietfa.amsl.com>; Fri, 12 Oct 2018 06:52:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.054
X-Spam-Level:
X-Spam-Status: No, score=-3.054 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.456, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FROM_EXCESS_BASE64=0.979, HTML_MESSAGE=0.001, MIME_HTML_ONLY=0.723, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com header.b=cLXExtlA; dkim=pass (1024-bit key) header.d=ericsson.com header.b=EAlrvU27
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ANfIdq58BSyx for <ccamp@ietfa.amsl.com>; Fri, 12 Oct 2018 06:52:13 -0700 (PDT)
Received: from sessmg23.ericsson.net (sessmg23.ericsson.net [193.180.251.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EB977127148 for <ccamp@ietf.org>; Fri, 12 Oct 2018 06:52:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1539352331; x=1541944331; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=aO4pFrGs4Zn1kizlN1Ym68zujVsPJmqHJTG1wTnH9+I=; b=cLXExtlAX7zJvFoapm1xJiIanICSGi9YoIBGv8Mp3DT19FTuRnz0bb2tMSwO0rmV 55/djoBFnttxmh7hZwEKtJL42fsSuzFz9ts0lsfc6RJc5Shx4q2qTDFdCW3aiJKL u7avFJgvYDs94u0dAobG0sE/CGTv3M28t5mbdsbjXNQ=;
X-AuditID: c1b4fb2d-fb3d09e000003a27-85-5bc0a70b8c96
Received: from ESESSMB502.ericsson.se (Unknown_Domain [153.88.183.120]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 6F.9B.14887.B07A0CB5; Fri, 12 Oct 2018 15:52:11 +0200 (CEST)
Received: from ESESSMR501.ericsson.se (153.88.183.108) by ESESSMB502.ericsson.se (153.88.183.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Fri, 12 Oct 2018 15:52:03 +0200
Received: from ESESBMB505.ericsson.se (153.88.183.172) by ESESSMR501.ericsson.se (153.88.183.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Fri, 12 Oct 2018 15:52:03 +0200
Received: from EUR03-AM5-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB505.ericsson.se (153.88.183.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Fri, 12 Oct 2018 15:52:03 +0200
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rYn4TQRX65qCh5QzvL9uGwOX1yxJaJct/yB7pGgDh/A=; b=EAlrvU27Gj7U6qmWRVuyz5RYgNRxTLPR+GMCutJI2/ikwDY46mSsKq3jNqjxnL7kEpMFjsWhmr3IxCMRl1W5xxAx6kFIW0vSAJ8txk9PvW38v3P+8AD1vdT+B9dQFahDJfOay/ryXN36Hqd8dhmUSOmc8zLmY72vbuYQScHKI08=
Received: from VI1PR0701MB2736.eurprd07.prod.outlook.com (10.173.80.148) by VI1PR0701MB2557.eurprd07.prod.outlook.com (10.173.85.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.9; Fri, 12 Oct 2018 13:52:02 +0000
Received: from VI1PR0701MB2736.eurprd07.prod.outlook.com ([fe80::4e4:6761:27d5:5bd]) by VI1PR0701MB2736.eurprd07.prod.outlook.com ([fe80::4e4:6761:27d5:5bd%10]) with mapi id 15.20.1228.020; Fri, 12 Oct 2018 13:52:02 +0000
From: =?utf-8?B?QmFsw6F6cyBMZW5neWVs?= <balazs.lengyel@ericsson.com>
To: "ccamp@ietf.org" <ccamp@ietf.org>
Thread-Topic: Balazs Review of alarm-module-04
Thread-Index: AQHUYjLA7XbIPBCis02+gbpbmhzY1g==
Date: Fri, 12 Oct 2018 13:52:01 +0000
Message-ID: <41cfebeb-0e81-838a-e3e1-9aaac3fea947@ericsson.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-originating-ip: [89.135.192.225]
user-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1
x-clientproxiedby: HE1PR05CA0156.eurprd05.prod.outlook.com (2603:10a6:7:28::43) To VI1PR0701MB2736.eurprd07.prod.outlook.com (2603:10a6:801:8::20)
authentication-results: spf=none (sender IP is ) smtp.mailfrom=balazs.lengyel@ericsson.com;
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; VI1PR0701MB2557; 6:oHvhvm4pM+VtQpUSiP7tfYjSd67J5UAQcyGajTxzyCaQGAPFayXGXUvIwxkl9CGhqar6RjR75LyDwuPnfdkMNQFqzsO0dn088u8KXxDTqpW8qD1DAiSyB23oDwTA/jADSHfCzFIfIzWhdR0mkdQexywDqOp2J/G/zLkMCu0+i6x2LUUIJWDjdrlMMbXLUzQXDBwEvKc3GfywgcGomHDbyYPhWMBhizU/BuEABRO+49HL3OdCdMpMAav6qDM39+IIdEywh7iHqvzqxDT8ZhZ1Abj5/B+MhSSScKSe4yYtSmUoF1DI3Opxp4cXqT1jHBhxTAl0S7vMaNbZAhTz9cfvY775mhLLn4JIKNsO6v0FfoDnpWCVoJIkluZcFCNnobpeZs7fdMc9ak9KWZrZlz1RzA+quFI9ZQmmlTohUD0ogrfg+lrdr2uIv5aMREJYTmZX+RMav+5o/PZDDRAsIsYReQ==; 5:DR+Mm3VP7ZC7jQn51eY5uX6KudUvzGxOnf7QfTQF93AJGBG46W/JicM8w0WA56hsSUPm/ZQmmonezhxztqNz8tRaI10QIaoNKKDeVPHgOD700TsLsBHm8RY2MzogWPUow9CEbX3zCvJDO/R7zBe8Bfm+dzX2d6pAez2MgHrOn3w=; 7:AZcTImddMCfCrcXy0ZXcR1fCqovppKS6j0tsdezVc1/zaQ9FTl7Uw7TNYfcCM1xYuLo7+YzeflfEcZ54uWpe7tZJsbdJWrGMzdKWRpUbRKPceedS6/1GF6eKw5XqC4fRcPEEAnK4k2dRSARZjr3kht6GbZwuoyOYUmzqSX7WwVAKIwienrA9dmIoobfB317nWBu30PSoTDoFrnd6Xz1tKBb+ZIZu9Af/Hmra3BceNmzw4PXWlXXT04bDn4HOd+4s
x-ms-office365-filtering-correlation-id: dcfa5fb5-f637-4761-45ac-08d63049e1b3
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(49563074)(7193020); SRVR:VI1PR0701MB2557;
x-ms-traffictypediagnostic: VI1PR0701MB2557:
x-microsoft-antispam-prvs: <VI1PR0701MB2557EDED88458C3DE66A80CFF0E20@VI1PR0701MB2557.eurprd07.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(158342451672863)(248295561703944)(37575265505322);
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(102415395)(6040522)(2401047)(8121501046)(5005006)(3231355)(944501410)(4983020)(52105095)(3002001)(10201501046)(93006095)(93001095)(149066)(150057)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123560045)(201708071742011)(7699051); SRVR:VI1PR0701MB2557; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0701MB2557;
x-forefront-prvs: 0823A5777B
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(346002)(366004)(376002)(136003)(39860400002)(396003)(252514010)(199004)(189003)(486006)(14454004)(5250100002)(3260700006)(2501003)(25786009)(476003)(5660300001)(31686004)(36756003)(106356001)(105586002)(8676002)(2351001)(2616005)(85202003)(81156014)(99936001)(81166006)(386003)(1730700003)(6506007)(478600001)(99286004)(65826007)(97736004)(7736002)(58126008)(316002)(3846002)(8936002)(68736007)(186003)(26005)(966005)(52116002)(71200400001)(71190400001)(102836004)(6916009)(236005)(6512007)(6486002)(64126003)(606006)(31696002)(256004)(2900100001)(6116002)(85182001)(6436002)(65956001)(65806001)(6306002)(54896002)(66066001)(86362001)(53936002)(2906002)(14444005)(5640700003)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0701MB2557; H:VI1PR0701MB2736.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
x-microsoft-antispam-message-info: qWOkVBwiNYxqr/lMqhIiaDRtbWdpxw5iD/wLehY+5QQKWkjBsNvwFBVdHZ+9ipxCFqigpwcv0VZGcKfQqmvTHCRSxHrmEM/NzsYTiuZYXomAJ/3CCIBWThuE8Y6ovpEpPhHfiUytz501O4ShgcrI0TxPVl/hgG272dOlejgQAvfrm6vEjTpsL0mLG55LoYV/W7MER9e+ejZU6uFnWjjC8ddbEzO1CcmwgmDmVkpJ1HTR34hPaPrh5q7TRUpWFTsiOOhaT+ift7hBGXnwAJ9jl+W4J52htDep89Jft8hY6DRrxv3xA1uNDB28fmCQbzypynKXpcr5tMbB1r+9iZtj+rFU6tlB/vghXT494HCunk8=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="------------ms040307070901060108030200"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: dcfa5fb5-f637-4761-45ac-08d63049e1b3
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2018 13:52:01.8747 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0701MB2557
X-OriginatorOrg: ericsson.com
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrAKsWRmVeSWpSXmKPExsUyM2J7hS738gPRBhN2s1o8mXODxYHRY8mS n0wBjFFcNimpOZllqUX6dglcGY92vGEteBJfcfDJbMYGxslBXYycHBICJhKv5y1m7GLk4hAS OMoocfXzD2YI5xujxJHps9jhnGub/kI5S5gk3pyZDVbGIjCBWeL96xtQmalMEv/nfWKBcB4z SvzbdZ4JZA2bgItE+7v9YLaIgKrEmZsXGUFsYQFNiSM9m9gg4noSj6++AbI5wOz7lyVAwixA 5cvn7ARr5RWwl5je/5gdxGYUEJP4fmoNWJxZQFzi1pP5TBAfiUg8vHiaDcIWlXj5+B8rhK0k MePVLTBbVCBWouXkLFaQOyUEpjFKfN3XxwgxNE5iz70OqGYdibPXnzBC2LISl+Z3M0I0HGCX WPSzAyrhK7F6y1KoxGVGiZvTHrHDdL+YOx3sGwmBfInOLyEQ4RiJGw0PoRbISazqfcgygdFg FpInIOxORol1l2pmgT0tKHFy5hOWWUCTmAXUJJa1KmEq15ZYtvA1M4RtLTHj10E2CFtRYkr3 Q3YI21Ti9dGPjBC2scSydX/ZFjByrWIULU4tLs5NNzLWSy3KTC4uzs/Ty0st2cQITFsHt/zW 3cG4+rXjIUYBDkYlHt4brQeihVgTy4orcw8xqgDNebRh9QVGKZa8/LxUJRHeBVlAad6UxMqq 1KL8+KLSnNTiQ4zSHCxK4rx6q/ZECQmkJ5akZqemFqQWwWSZODilGhjn/y6Uzy+XlGAXN/Ld ecj+8rOddXuYzL4VxKcbWiWU6pxq/e3xbMrN/2u7pdU2RKsJnnYMvmRzctmDZXyGLtIN3Mpe kVskQzKbmQ7XTg7nYP/2grXl56MKyfa4Of97t+cai92Qi5VNkmU+4DXvgfjBmc9nPz4RKe38 TPNUb1bpFx//q4uUVyuxFGckGmoxFxUnAgBl80XuYwMAAA==
Archived-At: <https://mailarchive.ietf.org/arch/msg/ccamp/iFUrppXL9IuDtaDh6vMEZ2TsTD8>
Subject: [CCAMP] Balazs Review of alarm-module-04
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Oct 2018 13:52:16 -0000

Hello,

I have reviewed draft-ietf-ccamp-alarm-module-04

General:

IMHO the draft is in a fairly good shape.

The draft https://tools.ietf.org/html/draft-lengyel-netmod-yang-instance-data-04" rel="nofollow">https://tools.ietf.org/html/draft-lengyel-netmod-yang-instance-data-04 describes how to document YANG instance data. One of the main use case for documenting YANG instance data in a file is to provide information about the YANG server's capabilities. The alarm-inventory is exactly such a set of server capabilities that could, that SHOULD be documented in a YANG Instance Data file already in design-time to help users integrate management systems. The draft is in the process of being adopted by the Netmod WG.

It should be mentioned somewhere that a cleared alarm can be raised again thus become is-cleared=false; potentially many times during its life.

IMHO the counters defined are not the best. For me the two most important statistics would be:

  1. How many active (is-cleared=false) alarms do I have in my system?   total-not-cleared This could be added both to the list alarm and the list alarm-summary. I know this can be derived from the total minus total-cleared but I feel that this is the primary information, so this should be available just by a read operation without any maths.
  2. How many alarms did my system generate in the last hour/day/week ?   total-raised, this should be a yang:counter32 that increments whenever a new alarm is added or set to is-cleared=false. (types, severity, shelving could be considered)

We have neither counter in the module.

I would generally prefer using YANG actions instead of rpcs. I would place all RPCs as actions under the /alarms container.

  • These are not general system-wide operations, they are specific to alarm-handling. They belong under /alarms
  • It makes setting up access control simpler. As the access control for the /alarms container already controls access to the RPCs too. Otherwise you need separate rules for each RPC.
  • On a CLI if you ask for help, all top level RPCs are listed as options. If there are many RPCs the list gets really long. With actions you do not have this problem.

4.4) I don't understand the first sentence.

5)

type resource)

  • required-instance false; Is not needed as that is the default meaning for instance-identifiers. Specifying default statements is not recommended by RFC6087bis
  • IMHO Distinguished names are more common then UUIDs. I would list them as more preferred then UUIDs.
typedef resource-match) The following two lines are redundant and contradictory (choose one :-)   )
  • The context node is the root node in the data tree. 
    AFAIK YANG has many root nodes. Please clarify.

list-alarm)

I am missing a leaf: time-alarm-raised.  As an alarm can be raised then cleared, then raised again I have no way of knowing when the current alarm condition started. If an interface is down I can't check how long has it been down. We have the leaf time-created, however if the alarm is repeatedly raised/cleared/raised but never purged this leaf will tell me when this alarm was first raised in the history of the system, which is not very interesting.

container shelved-alarms)

alarm-shelf-last-changed) The name of the leaf seems to indicate that this refers to the time when one specific alarm-shelf changed. However as I understand this is the time when any of the shelves changed. Please clarify / rename

list alarm-profile)

Why is this user-ordered ? I see no meaning of the order.

rpc compress-alarms)  leaf resource) IMHO this could be of type resource-match

6)  module-description)

Mention that shelved-alarms are also augmented

Appendix F.1)

Clarify whether this annex is normative or informative. To me this seems, this should be normative text.

regards Balazs

P.S. Please send any replies to me personally too as I am not always reading the cccamp list.

-- 
Balazs Lengyel                       Ericsson Hungary Ltd.
Senior Specialist
Mobile: +36-70-330-7909              email: Balazs.Lengyel@ericsson.com