Re: [CCAMP] [Last-Call] Last Call: <draft-ietf-ccamp-wson-yang-25.txt> (A YANG Data Model for WSON (Wavelength Switched Optical Networks)) to Proposed Standard

Italo Busi <Italo.Busi@huawei.com> Mon, 05 October 2020 06:54 UTC

Return-Path: <Italo.Busi@huawei.com>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5E7EE3A0DDB; Sun, 4 Oct 2020 23:54:25 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.399
X-Spam-Level:
X-Spam-Status: No, score=-0.399 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_COMMENT_SAVED_URL=1.391, HTML_MESSAGE=0.001, HTML_TAG_BALANCE_BODY=0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_HTML_ATTACH=0.01, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id D3M83VD8mCWB; Sun, 4 Oct 2020 23:54:20 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E84293A0DD8; Sun, 4 Oct 2020 23:54:18 -0700 (PDT)
Received: from lhreml716-chm.china.huawei.com (unknown [172.18.7.108]) by Forcepoint Email with ESMTP id E28A729A343BBBDFCCC1; Mon, 5 Oct 2020 07:54:15 +0100 (IST)
Received: from fraeml709-chm.china.huawei.com (10.206.15.37) by lhreml716-chm.china.huawei.com (10.201.108.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Mon, 5 Oct 2020 07:54:15 +0100
Received: from fraeml715-chm.china.huawei.com (10.206.15.34) by fraeml709-chm.china.huawei.com (10.206.15.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Mon, 5 Oct 2020 08:54:14 +0200
Received: from fraeml715-chm.china.huawei.com ([10.206.15.34]) by fraeml715-chm.china.huawei.com ([10.206.15.34]) with mapi id 15.01.1913.007; Mon, 5 Oct 2020 08:54:14 +0200
From: Italo Busi <Italo.Busi@huawei.com>
To: tom petch <daedulus@btconnect.com>, "last-call@ietf.org" <last-call@ietf.org>
CC: "ccamp@ietf.org" <ccamp@ietf.org>, "ccamp-chairs@ietf.org" <ccamp-chairs@ietf.org>, Daniele Ceccarelli <daniele.ceccarelli@ericsson.com>, "draft-ietf-ccamp-wson-yang@ietf.org" <draft-ietf-ccamp-wson-yang@ietf.org>, "db3546@att.com" <db3546@att.com>
Thread-Topic: [CCAMP] [Last-Call] Last Call: <draft-ietf-ccamp-wson-yang-25.txt> (A YANG Data Model for WSON (Wavelength Switched Optical Networks)) to Proposed Standard
Thread-Index: AQHWkcciKbIs/9+XKUK2+XzFSVhvwqmIoitg
Date: Mon, 5 Oct 2020 06:54:14 +0000
Message-ID: <714532e813a2425781a1b2f72a1d22bb@huawei.com>
References: <160028912088.19211.8121836627102846350@ietfa.amsl.com> <5F6339B2.9090501@btconnect.com> <5F6B1DF6.3080009@btconnect.com>
In-Reply-To: <5F6B1DF6.3080009@btconnect.com>
Accept-Language: it-IT, en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-originating-ip: [10.47.90.249]
Content-Type: multipart/mixed; boundary="_002_714532e813a2425781a1b2f72a1d22bbhuaweicom_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/ccamp/ieyzEKZhxHP69KpsRvU0d4aoK5Y>
Subject: Re: [CCAMP] [Last-Call] Last Call: <draft-ietf-ccamp-wson-yang-25.txt> (A YANG Data Model for WSON (Wavelength Switched Optical Networks)) to Proposed Standard
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Oct 2020 06:54:25 -0000

Hi Tom,

I have changed the order of the code to align this huge piece of code across multiple technology-specific topology models.

Since this piece of code is quite huge and error-prone, it would be good for the editors to be able to copy&paste from multiple technology-specific topology models.

I understand you concerns with reviewing the YANG code in the -26 revision. In order to address it, I have prepared a version of the YANG module with the former order and created a diff with the YANG module in -25 (see in attachment).

The plan is not to change this order any more in the next revisions so you can keep reviewing the I-D diffs from the -27 revision onward.

Regarding the issue with the YANG tree, let me check with co-authors. We can fix any issue with the YANG tree in the next revision.

Thanks, Italo

> -----Original Message-----
> From: tom petch [mailto:daedulus@btconnect.com]
> Sent: mercoledì 23 settembre 2020 12:06
> To: last-call@ietf.org
> Cc: ccamp@ietf.org; ccamp-chairs@ietf.org; Daniele Ceccarelli
> <daniele.ceccarelli@ericsson.com>om>; draft-ietf-ccamp-wson-yang@ietf.org;
> db3546@att.com
> Subject: Re: [CCAMP] [Last-Call] Last Call: <draft-ietf-ccamp-wson-yang-25.txt>
> (A YANG Data Model for WSON (Wavelength Switched Optical Networks)) to
> Proposed Standard
> 
> A new verson of this I-D has been posted with substantial changes.  In
> particular, the sequence of definitions in the YANG module has been changed
> while the YANG tree diagram has not been updated to match.  Look for
> example at augments 4, 5, 6 and 7.  In the tree diagram, as in -25, they are to
> label-start, label-end, label-step, label-hop; in the module they are to 'from',
> 'to' and then switch from node attributes to information source.
> 
> It is technically possible for me to review -26 against -25 but it would take so
> long that I am not going to do it.  My review is to compare, side by side, old
> and new, so resequencing destroys that and with a 62 page I-D I will not
> contemplate any other approach.
> 
> A new tree diagram, to match the YANG module, again would not make it
> feasible.  The module sequence needs to be the same as in -25 for me.
> 
> Tom Petch
> 
> On 17/09/2020 11:25, tom petch wrote:
> > On 16/09/2020 21:45, The IESG wrote:
> >>
> >> The IESG has received a request from the Common Control and
> >> Measurement Plane WG (ccamp) to consider the following document: - 'A
> >> YANG Data Model for WSON (Wavelength Switched Optical Networks)'
> >>    <draft-ietf-ccamp-wson-yang-25.txt> as Proposed Standard
> >>
> >> The IESG plans to make a decision in the next few weeks, and solicits
> >> final comments on this action. Please send substantive comments to
> >> the last-call@ietf.org mailing lists by 2020-09-30. Exceptionally,
> >> comments may be sent to iesg@ietf.org instead. In either case, please
> >> retain the beginning of the Subject line to allow automated sorting.
> >
> > Two glitches and some trivia:
> >
> > Introduction
> > /impairement/impairment/
> >
> > The only key word I see is a 'should' in IANA which is going to go so
> > whether or not Requirements Language should be included is a moot point.
> >
> > YANG import for layer0-types references the wrong I-D
> >
> > YANG module description talks of two encoding documents but omits
> > RFC7581
> >
> > grouping wson-node-attributes has the same 'e.g.' for both true and
> > false which looks odd; and I wonder if 'i.e.' is intended
> >
> > the e-mail address for Aihua Guo is different for the YANG module and
> > for Authors' Addresses
> >
> > Tom Petch
> >
> >> Abstract
> >>
> >>
> >>     This document provides a YANG data model for the routing and
> >>     wavelength assignment (RWA) TE topology in wavelength switched
> >>     optical networks (WSONs).  The YANG data model defined in this
> >>     document conforms to the Network Management Datastore Architecture
> >>     (NMDA).
> >>
> >>
> >>
> >>
> >> The file can be obtained via
> >> https://datatracker.ietf.org/doc/draft-ietf-ccamp-wson-yang/
> >>
> >>
> >>
> >> No IPR declarations have been submitted directly on this I-D.
> >>
> >>
> >> The document contains these normative downward references.
> >> See RFC 3967 for additional information:
> >>      draft-ietf-ccamp-optical-impairment-topology-yang: A Yang Data
> >> Model for Optical Impairment-aware Topology (None - IETF stream)
> >>      draft-ietf-ccamp-flexigrid-yang: YANG data model for Flexi-Grid
> >> Optical Networks (None - IETF stream)
> >>
> >>
> >>
> >>
> >> _______________________________________________
> >> IETF-Announce mailing list
> >> IETF-Announce@ietf.org
> >> https://www.ietf.org/mailman/listinfo/ietf-announce
> >> .
> >>
> >
>