Re: [CCAMP] [Last-Call] Last Call: <draft-ietf-ccamp-wson-yang-25.txt> (A YANG Data Model for WSON (Wavelength Switched Optical Networks)) to Proposed Standard

[Italo Busi <[e-mail]>]

Hi Tom,

I have changed the order of the code to align this huge piece of code across multiple technology-specific topology models.

Since this piece of code is quite huge and error-prone, it would be good for the editors to be able to copy&paste from multiple technology-specific topology models.

I understand you concerns with reviewing the YANG code in the -26 revision. In order to address it, I have prepared a version of the YANG module with the former order and created a diff with the YANG module in -25 (see in attachment).

The plan is not to change this order any more in the next revisions so you can keep reviewing the I-D diffs from the -27 revision onward.

Regarding the issue with the YANG tree, let me check with co-authors. We can fix any issue with the YANG tree in the next revision.

Thanks, Italo

> -----Original Message-----
> From: tom petch [mailto:[e-mail]]
> Sent: mercoledì 23 settembre 2020 12:06
> To: [e-mail]
> Cc: [e-mail]; [e-mail]; Daniele Ceccarelli
> <[e-mail]>; [e-mail];
> [e-mail]
> Subject: Re: [CCAMP] [Last-Call] Last Call: <draft-ietf-ccamp-wson-yang-25.txt>
> (A YANG Data Model for WSON (Wavelength Switched Optical Networks)) to
> Proposed Standard
> 
> A new verson of this I-D has been posted with substantial changes.  In
> particular, the sequence of definitions in the YANG module has been changed
> while the YANG tree diagram has not been updated to match.  Look for
> example at augments 4, 5, 6 and 7.  In the tree diagram, as in -25, they are to
> label-start, label-end, label-step, label-hop; in the module they are to 'from',
> 'to' and then switch from node attributes to information source.
> 
> It is technically possible for me to review -26 against -25 but it would take so
> long that I am not going to do it.  My review is to compare, side by side, old
> and new, so resequencing destroys that and with a 62 page I-D I will not
> contemplate any other approach.
> 
> A new tree diagram, to match the YANG module, again would not make it
> feasible.  The module sequence needs to be the same as in -25 for me.
> 
> Tom Petch
> 
> On 17/09/2020 11:25, tom petch wrote:
> > On 16/09/2020 21:45, The IESG wrote:
> >>
> >> The IESG has received a request from the Common Control and
> >> Measurement Plane WG (ccamp) to consider the following document: - 'A
> >> YANG Data Model for WSON (Wavelength Switched Optical Networks)'
> >>    <draft-ietf-ccamp-wson-yang-25.txt> as Proposed Standard
> >>
> >> The IESG plans to make a decision in the next few weeks, and solicits
> >> final comments on this action. Please send substantive comments to
> >> the [e-mail] mailing lists by 2020-09-30. Exceptionally,
> >> comments may be sent to [e-mail] instead. In either case, please
> >> retain the beginning of the Subject line to allow automated sorting.
> >
> > Two glitches and some trivia:
> >
> > Introduction
> > /impairement/impairment/
> >
> > The only key word I see is a 'should' in IANA which is going to go so
> > whether or not Requirements Language should be included is a moot point.
> >
> > YANG import for layer0-types references the wrong I-D
> >
> > YANG module description talks of two encoding documents but omits
> > RFC7581
> >
> > grouping wson-node-attributes has the same 'e.g.' for both true and
> > false which looks odd; and I wonder if 'i.e.' is intended
> >
> > the e-mail address for Aihua Guo is different for the YANG module and
> > for Authors' Addresses
> >
> > Tom Petch
> >
> >> Abstract
> >>
> >>
> >>     This document provides a YANG data model for the routing and
> >>     wavelength assignment (RWA) TE topology in wavelength switched
> >>     optical networks (WSONs).  The YANG data model defined in this
> >>     document conforms to the Network Management Datastore Architecture
> >>     (NMDA).
> >>
> >>
> >>
> >>
> >> The file can be obtained via
> >> https://datatracker.ietf.org/doc/draft-ietf-ccamp-wson-yang/
> >>
> >>
> >>
> >> No IPR declarations have been submitted directly on this I-D.
> >>
> >>
> >> The document contains these normative downward references.
> >> See RFC 3967 for additional information:
> >>      draft-ietf-ccamp-optical-impairment-topology-yang: A Yang Data
> >> Model for Optical Impairment-aware Topology (None - IETF stream)
> >>      draft-ietf-ccamp-flexigrid-yang: YANG data model for Flexi-Grid
> >> Optical Networks (None - IETF stream)
> >>
> >>
> >>
> >>
> >> _______________________________________________
> >> IETF-Announce mailing list
> >> [e-mail]
> >> https://www.ietf.org/mailman/listinfo/ietf-announce
> >> .
> >>
> >
>