[CCAMP] Review of alarm-module-06

"Beauville, Yves (Nokia - BE/Antwerp)" <yves.beauville@nokia.com> Mon, 03 December 2018 07:51 UTC

Return-Path: <yves.beauville@nokia.com>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5C80F128D68 for <ccamp@ietfa.amsl.com>; Sun, 2 Dec 2018 23:51:37 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.36
X-Spam-Level:
X-Spam-Status: No, score=-3.36 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=nokia.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7K-HphKr5S9c for <ccamp@ietfa.amsl.com>; Sun, 2 Dec 2018 23:51:35 -0800 (PST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70107.outbound.protection.outlook.com [40.107.7.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0D88B124C04 for <ccamp@ietf.org>; Sun, 2 Dec 2018 23:51:34 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.onmicrosoft.com; s=selector1-nokia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rLXlyvtNSGROqzzwPHYYP7ueQPkDEeWuAqZtNVVdIUI=; b=pFUK19OFKgw2mAT4yQFawF6CP/vRavMESFwRBlDOTw02U+KzNbci2OxE9xG3iiJsjz9E6gZtz2taQRKyX1dSR9CoX6/tYzmV5ppOpBYdGVIFDRBvLAY40IkLQQ0jNWDmMD92s1LCEmTNICy3A9/BwOaLkpUMGTkst84JNgiaUmY=
Received: from VI1PR07MB5983.eurprd07.prod.outlook.com (20.178.123.97) by VI1PR07MB5407.eurprd07.prod.outlook.com (20.178.14.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1404.10; Mon, 3 Dec 2018 07:51:32 +0000
Received: from VI1PR07MB5983.eurprd07.prod.outlook.com ([fe80::c1f6:22d7:2f05:4a5]) by VI1PR07MB5983.eurprd07.prod.outlook.com ([fe80::c1f6:22d7:2f05:4a5%2]) with mapi id 15.20.1404.016; Mon, 3 Dec 2018 07:51:32 +0000
From: "Beauville, Yves (Nokia - BE/Antwerp)" <yves.beauville@nokia.com>
To: stefan vallin <stefan@wallan.se>
CC: "ccamp@ietf.org" <ccamp@ietf.org>
Thread-Topic: Review of alarm-module-06
Thread-Index: AQHUit0BhfwD8aEovEixksx3NGCEFQ==
Date: Mon, 3 Dec 2018 07:51:31 +0000
Message-ID: <8cf0b0b5-93ac-ccdd-1a13-4d107ce7cb5d@nokia.com>
References: <41cfebeb-0e81-838a-e3e1-9aaac3fea947@ericsson.com> <E8A526FA-19A6-4AC9-B612-CEB2B044EB24@wallan.se> <a7f2d666-8a9e-fc9d-cfca-722d258b48f5@ericsson.com> <CD8F1007-4B76-4ED4-B47F-958EDC645005@wallan.se>
In-Reply-To: <CD8F1007-4B76-4ED4-B47F-958EDC645005@wallan.se>
Accept-Language: fr-BE, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [135.245.212.94]
user-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
x-clientproxiedby: LO2P265CA0429.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::33) To VI1PR07MB5983.eurprd07.prod.outlook.com (2603:10a6:803:d5::33)
authentication-results: spf=none (sender IP is ) smtp.mailfrom=yves.beauville@nokia.com;
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; VI1PR07MB5407; 6:Ci/bIvGm0WJdiFIT7qz2UuRsQDzIR+qJubn47uxvegJoZyZEh7pMEbom+usCxxpDdQxG9ZC77c28DKYv1N1WNtJ3MkQ3l/kNn1xr+Pmwf0dg0ReHfeol6xdW8J3+NyKnxnyLt70fkS5g80KoyoOcoR9I8K4ildwFOof2dPZC374NKKKhfwx7nme0bBjr1iNmj0gTrcXqyLjh0EKmjlo9ahvn1/pBI7PJmvVfMx2ozDMnUmIvUtfCgeznDZeSKQrzf8kipeHqm2sCa40T+I/G/EiPPZVHEcOz/UGGK8aFQ4PZMnhan6QjIM1oDnxmJ9Xe5So0I0evqXvc9HskMECWa7tRlJPsPkPllLfFiG9oWDKmfQY9/x0n22v+D6xrA7KUro9DWV1b1OGCA+vWYRskX/xwMHqorZF82lg0bufXePOS0rldWAZggYdOQ7oEN0NKlhrWvG7RJnsYncGAj6+P+g==; 5:XTDRdr+MUGcqpfquA7/QvCkO/p6VesbVSAgnLyl2aj67C4CPwIQog5hXsnWHX7Vvb5AbfW23+o+cTQOFDR78EyImyx2pPFB2WlotrtYFeIe+S4Y6ht+U3ld7d0T+yZmhwvH3mF5o0Mf4FsBkQbhzFbZd8jHljnso6qxb9P8K4z0=; 7:arpK+LouhN4udD5fcJH+kROzQDbnRphRZIMWEU98ClYf8QbUd4txs6zVLDROlLfxF2GquR7nLF7nkUTQQe3uPrUa2sf+MrMqIPtF8A2Qp90pJEH4OpJod6J3MfFZLJQcID2pKsFMoKvlTBRgvQyjig==
x-ms-office365-filtering-correlation-id: 55ccc343-20d5-4bcc-f020-08d658f4233f
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7193020); SRVR:VI1PR07MB5407;
x-ms-traffictypediagnostic: VI1PR07MB5407:
x-microsoft-antispam-prvs: <VI1PR07MB5407C06967E5A867F2EA0CC689AE0@VI1PR07MB5407.eurprd07.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231455)(999002)(11241501185)(806100)(944501493)(52105112)(93006095)(93001095)(10201501046)(6055026)(148016)(149066)(150057)(6041310)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(201708071742011)(7699051)(76991095); SRVR:VI1PR07MB5407; BCL:0; PCL:0; RULEID:; SRVR:VI1PR07MB5407;
x-forefront-prvs: 08756AC3C8
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(979002)(366004)(136003)(376002)(346002)(396003)(39860400002)(199004)(189003)(81156014)(81166006)(86362001)(8676002)(31696002)(65806001)(6916009)(65956001)(99286004)(386003)(102836004)(76176011)(52116002)(6506007)(486006)(476003)(2616005)(11346002)(71190400001)(71200400001)(446003)(8936002)(6436002)(6486002)(66066001)(186003)(36756003)(256004)(14444005)(26005)(93886005)(25786009)(2906002)(316002)(58126008)(54896002)(6512007)(6116002)(3846002)(5660300001)(65826007)(53936002)(97736004)(4326008)(7736002)(106356001)(68736007)(478600001)(31686004)(105586002)(64126003)(14454004)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1102; SCL:1; SRVR:VI1PR07MB5407; H:VI1PR07MB5983.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: nokia.com does not designate permitted sender hosts)
x-microsoft-antispam-message-info: dp3NgMP+Fx/NoH1P4JcSsAuywVIKyokYLIoL6Bwpa7NLaaCwxEIYnzo0q7GYyXUp96nvSuLvaoWgNpyr5kIM6Tx+z3qAwd7JJX60TTb00xao5flbL3At1xf9VhRKki+hJ5exjcEbEJzkZcSC9Xy/sCjtJb2a93S9mjpXgyjwUgxWGaX7Y7NAUbz0bZQPdE9SdCPtJZEY6FtNO4WGICPNk+RmoTi+f7tkqZ6U1gOCl/p4ndpflVYGA53HSMDZLqpXvBKaugS2kWkIoiq6PnXUI/QENaMN9r7abHoloEJDiuBBmkhO9ui/tuPbIJg1bu8fzHgu6kzcUDlkOpC3s7vhV9l5sE7oOGLhYRudQa9G5I4=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative; boundary="_000_8cf0b0b593acccdd1a134d107ce7cb5dnokiacom_"
MIME-Version: 1.0
X-OriginatorOrg: nokia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 55ccc343-20d5-4bcc-f020-08d658f4233f
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Dec 2018 07:51:31.8974 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR07MB5407
Archived-At: <https://mailarchive.ietf.org/arch/msg/ccamp/jPUZxcrXTZFytB2hiuXRIRdHPtE>
Subject: [CCAMP] Review of alarm-module-06
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Dec 2018 07:51:37 -0000

Hi Stefan,

I am very happy with the outcome of the reviews of the alarm module. I fully support it.

I have one comment though, hopefully easy to address.

I have noticed an inconsistency with X.733. In section 8.1.2.3, Perceived severity, of the CCITT specification, the following is documented:

>> Those severity levels which represent service affecting conditions ordered from most severe to least severe are Critical, Major, Minor and Warning

In the alarm-module-06, the type 'severity' is defined as below (omitting the descriptions):

     typedef severity {
       type enumeration {
         enum indeterminate {
           value 2;
         }
         enum minor {
           value 3;
         }
         enum warning {
           value 4;
         }
         enum major {
           value 5;
         }
         enum critical {
           value 6;
       }


The enum value provided for 'minor' and 'warning' is not consistent with the severity ordering defined in X.733.

The severity order is relevant in the IETF model when using severity filters with 'above' or 'below' criteria.

Should we swap the order (and enum values) of 'minor' and 'warning' in the above type definition?

Thanks
Yves