[CCAMP] 答复: A few thoughts for draft-yu-ccamp-optical-resource-pm-yang

yuchaode <yuchaode@huawei.com> Fri, 26 April 2024 01:24 UTC

Return-Path: <yuchaode@huawei.com>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7C4F4C151089 for <ccamp@ietfa.amsl.com>; Thu, 25 Apr 2024 18:24:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.894
X-Spam-Level:
X-Spam-Status: No, score=-6.894 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gr3zHLzqxurz for <ccamp@ietfa.amsl.com>; Thu, 25 Apr 2024 18:24:15 -0700 (PDT)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AB710C14F69F for <ccamp@ietf.org>; Thu, 25 Apr 2024 18:24:14 -0700 (PDT)
Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4VQZgv45yNz6JB95 for <ccamp@ietf.org>; Fri, 26 Apr 2024 09:21:47 +0800 (CST)
Received: from lhrpeml100006.china.huawei.com (unknown [7.191.160.224]) by mail.maildlp.com (Postfix) with ESMTPS id 603D3140A34 for <ccamp@ietf.org>; Fri, 26 Apr 2024 09:24:11 +0800 (CST)
Received: from canpemm100002.china.huawei.com (7.192.105.47) by lhrpeml100006.china.huawei.com (7.191.160.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 26 Apr 2024 02:24:10 +0100
Received: from canpemm500002.china.huawei.com (7.192.104.244) by canpemm100002.china.huawei.com (7.192.105.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 26 Apr 2024 09:24:08 +0800
Received: from canpemm500002.china.huawei.com ([7.192.104.244]) by canpemm500002.china.huawei.com ([7.192.104.244]) with mapi id 15.01.2507.035; Fri, 26 Apr 2024 09:24:07 +0800
From: yuchaode <yuchaode@huawei.com>
To: "'daniel@olddog.co.uk'" <daniel@olddog.co.uk>, 'CCAMP' <ccamp@ietf.org>
Thread-Topic: [CCAMP] A few thoughts for draft-yu-ccamp-optical-resource-pm-yang
Thread-Index: AQHal0LZwMOQxFbI6EqL6NSda4oh6bF5wSGg
Date: Fri, 26 Apr 2024 01:24:07 +0000
Message-ID: <d18579c833bd4533b8bae178887eb150@huawei.com>
References: <009701da96ef$8bf94410$a3ebcc30$@olddog.co.uk>
In-Reply-To: <009701da96ef$8bf94410$a3ebcc30$@olddog.co.uk>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.117.46.217]
Content-Type: text/plain; charset="gb2312"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/ccamp/lt7JOxSA7jyTqHomt5tJCx_dF3s>
Subject: [CCAMP] 答复: A few thoughts for draft-yu-ccamp-optical-resource-pm-yang
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Apr 2024 01:24:18 -0000

Hi Daniel and CCAMP working group,

A lot of thanks to Daniel for your very professional comments.
I will issue a new version in the next week.
And comments from CCAMP working group are always welcome.


B.R.
Chaode

-----邮件原件-----
发件人: daniel@olddog.co.uk [mailto:daniel@olddog.co.uk] 
发送时间: 2024年4月25日 17:04
收件人: 'CCAMP' <ccamp@ietf.org>
主题: [CCAMP] A few thoughts for draft-yu-ccamp-optical-resource-pm-yang

Hi draft-yu-ccamp-optical-resource-pm-yang authors, 

Re: A YANG Data Model for Optical Resource Performance Monitoring https://datatracker.ietf.org/doc/draft-yu-ccamp-optical-resource-pm-yang/

Having read the document a few times, including as a component to assist in optical network digital twin solution development and the recent discussion of fine-grain network management for ACTN, I would like to share some thoughts on the work. 

The document is well-written and proposes several YANG functions related to real-time and historical performance monitoring for optical parameters. It builds on existing core data models (topology), VPN service monitoring and ACTN telemetry autonomics. It may also be worth including the inventory work in the discussion. Overall, the proposal provides an important YANG module for optical network service setup and operation, which will be used with several other well-defined and developing YANG models.  

It's good to see the requirements derived from the TMF MTOSI specification for resource management; however, the reference
(https://www.tmforum.org/resources/collection/mtosi-4-0) used in the document takes you to the general area for MTOSI 4.0 and not the specific resource describing the requirements, which I think might be the TMF518 document, so a more direct accurate link might be useful, especially as you list this as a normative reference. Furthermore, some of the recent MEF work on (optical) transport as an underlay connectivity service - UCS activation might also referenced, as it also requires TCA capability. I will follow up with the authors offline on this topic. 

The introduction of the document does a good job of summarising existing work that relates to the proposed YANG work of optical PMs; I would suggest some additional text, maybe before the final paragraph in Section 1
(Introduction):

"The YANG data model in this document may be used to monitor and manage the performance of optical network resources. It provides the three key elements for performance management: control, retrieval and threshold crossing alert.
These interfaces can then be used with technology-specific models to collect data performance related to bandwidth utilization, latency, error rates, availability, environmental, and other key performance indicators (KPIs) specific to optical networking."

Also, the following grammar NITS could be squashed in this early section:

OLD: Performance monitoring is a basic function of optical networks management. 

NEW: Performance monitoring is a basic function of optical network management.

OLD: Mostly, they are fear of introducing issues into their network due to the protocol changes and O&M habits changes.

NEW: Mostly, they are concerned with introducing problems into their network due to protocol changes and changes to Operation and Maintenance (O&M) habits.

OLD: Such as session 10 of [ITU-T_G.7710] has provided very detail description of performance management application and functions.

NEW: Such as section 10 of [ITU-T_G.7710] provides a detailed description of performance management applications and functions.

OLD: Currently, there are some existing documents related to performance monitoring in IETF, but there is no overlap with our current work. For
example:

NEW: There are existing documents which relate to performance monitoring in IETF but do not overlap with the function in this document; these include: 

OLD: VN is determinate to be used in CMI (CNC-MDSC Interface) level and TE tunnel is more service or connection related. 

NEW: The VN is used via the CMI (CNC-MDSC Interface) level, and the Traffic Engineered (TE) tunnel is typically service or connection-based. 

The "Terminology" section needs a fuller list of acronyms (non-ACTN) used in this document. 

In the "YANG Data Model for Optical Performance Monitoring," you list some requirements; those might be easier to read as bullets rather than paragraphs.

>>
According to the business requirements stated in [TMF-518], resource performance management requirements include:

o The Interface shall support the control of performance monitoring in the network. This includes PM control, e.g., the enabling and disabling of PM collection and Threshold Crossing Alerts (TCA) control, e.g., the enabling and disabling of TCA generation;

o The Interface shall support the retrieval of current and historical performance measurements for network resources;

o The Interface shall support the distribution of TCAs to subscribed OSs.
<<

The final bullet mentions "OSs," which I think should read Operational Support System (OSS). 

Including a simple ASCII diagram showing the OSS component, ACTN architecture, and Optical Nodes would be very useful, with the relevant interfaces described earlier in the document. This would provide a useful visualization of the concepts and interface discussed.

In the "YANG Data Model for Optical Performance Monitoring" section, grammar improvements could be made. 

OLD: For these requirements of PM, there are three group of interfaces are defined in TMF, including PerformanceManagementControl, PerformanceManagementRetrieval and ThresholdCrossingAlertControl.

NEW: For PM requirements, three interface functions are defined in TMF, including PerformanceManagementControl, PerformanceManagementRetrieval and ThresholdCrossingAlertControl.

In the "Generic Resource" section, grammar improvements could be made.

OLD: And it is also similar that the functionalities of both alarm and performance monitoring can be defined with a generic structure, regardless of what kind of object is operated on. 

NEW: The functionalities of alarm and performance monitoring may be defined with a generic structure, regardless of the operated object. 

Finally, the examples (use cases) are excellent. You might mention in the Appendix that these should be removed by the RFC Editor if the document is published as an RFC. If the document becomes a WG item (and I believe it
should) the examples could be moved to the CCAMP GitHub. 

Thanks, Dan.