Re: [CCAMP] Yangdoctors last call review of draft-ietf-ccamp-alarm-module-06

Daniele Ceccarelli <daniele.ceccarelli@ericsson.com> Wed, 19 December 2018 16:38 UTC

Return-Path: <daniele.ceccarelli@ericsson.com>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BC394130E4D for <ccamp@ietfa.amsl.com>; Wed, 19 Dec 2018 08:38:07 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.366
X-Spam-Level:
X-Spam-Status: No, score=-4.366 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com header.b=KJX0Joeg; dkim=fail (1024-bit key) reason="fail (body has been altered)" header.d=ericsson.com header.b=jx2DQ+Ps
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wxUT0lIqv7PS for <ccamp@ietfa.amsl.com>; Wed, 19 Dec 2018 08:38:06 -0800 (PST)
Received: from sessmg22.ericsson.net (sessmg22.ericsson.net [193.180.251.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D6549130E66 for <ccamp@ietf.org>; Wed, 19 Dec 2018 08:38:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1545237481; x=1547829481; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=daoa0CneoHjCDAEYfV13WhwXmDmhB+Y0n6mNvrxI/OY=; b=KJX0Joegj4g4zPnV6hnr0wP/WAZxTy8lnF9UecQdMp1MGRhNIBOhXabeEwH3LTT4 uIILizERmcx8BNuu75BPkQP7nGKjJts04SHbf53ZhK2dlFHCc/Sf3MaeqF17sRJV aqHVFrTbC1NwTYay4SpjJYtnORK0cqjRqvnePbErMDo=;
X-AuditID: c1b4fb3a-14fff7000000672c-c6-5c1a73e956ac
Received: from ESESBMB503.ericsson.se (Unknown_Domain [153.88.183.116]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id 86.29.26412.9E37A1C5; Wed, 19 Dec 2018 17:38:01 +0100 (CET)
Received: from ESESBMB504.ericsson.se (153.88.183.171) by ESESBMB503.ericsson.se (153.88.183.170) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 19 Dec 2018 17:38:00 +0100
Received: from EUR02-AM5-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB504.ericsson.se (153.88.183.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Wed, 19 Dec 2018 17:38:00 +0100
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C0YmtHCH5En2cZPO93CHt5rBZcWkJ/XPalQQY/1Bqic=; b=jx2DQ+PsrP8vO74oZ6S2UKPPI3xCxL8CzJNIJU4CkaTuhh+ZRMeqa4TjE8SrZa9eJ07a671OdmigYs4yNx/hbTnLAY2MaROs4YBzwBQkYrg4S95TvfEf/bnsmvqGTGsWt5h9aq32MXBHgDxVChiHolHRKK3SHrTezu2YLUKh5IE=
Received: from HE1PR07MB4329.eurprd07.prod.outlook.com (20.176.167.14) by HE1PR07MB3372.eurprd07.prod.outlook.com (10.170.247.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1446.9; Wed, 19 Dec 2018 16:37:59 +0000
Received: from HE1PR07MB4329.eurprd07.prod.outlook.com ([fe80::fd45:e780:d637:a7ea]) by HE1PR07MB4329.eurprd07.prod.outlook.com ([fe80::fd45:e780:d637:a7ea%4]) with mapi id 15.20.1446.015; Wed, 19 Dec 2018 16:37:59 +0000
From: Daniele Ceccarelli <daniele.ceccarelli@ericsson.com>
To: Carl Moberg <calle@tail-f.com>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>
CC: "draft-ietf-ccamp-alarm-module.all@ietf.org" <draft-ietf-ccamp-alarm-module.all@ietf.org>, "ccamp@ietf.org" <ccamp@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>
Thread-Topic: Yangdoctors last call review of draft-ietf-ccamp-alarm-module-06
Thread-Index: AQHUl7NVf8G6pZ7mCk6ei9kNWqZHOaWGQvOw
Date: Wed, 19 Dec 2018 16:37:58 +0000
Message-ID: <HE1PR07MB4329A88304457A3307909DAFF0BE0@HE1PR07MB4329.eurprd07.prod.outlook.com>
References: <154523494557.2904.788634195669624933@ietfa.amsl.com>
In-Reply-To: <154523494557.2904.788634195669624933@ietfa.amsl.com>
Accept-Language: it-IT, en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=daniele.ceccarelli@ericsson.com;
x-originating-ip: [151.0.200.100]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; HE1PR07MB3372; 6:iAE2nReppHrMi5xA18bYMhraH8qyIZ/7s+uDGv6EXjFe/JeDPI+WVmZ8kxV3Ls5uJitxnjWgchI+L+0WFJnb5MRJo2Zw3ViN3Yk/+kbZSs5rXHmD4aDlKaxAqVr8nuzj8MU2zS9meDEAcom/tU4TJgTJNmxHtiXi8QYl038LYIEuYhV7VnTp2SGLE4TjN+c2kz0u1bEbLCQaqgkwUCxfq1PSacYeFH7bBFpxUP8Y36g+iC5yKksVfA+zjdP+5GypwY6s8Sa39GPiHolkmSOmkzBh+bynMGDHgJR4jg7t5U4TzC3LbfqEDTMw5WKxDIF7/tUCVJimChz1hN6Q2C1osB0/pyQDv8Nd4rQFI7SEKqIdN1kAnF3BS31LOY5cvZ6Cc4c4gkTvmhUl64bevOIri+0mMrSFyJ/Rrei17GLYZH5I7WOzRrWeX5E876GSnASnu8jP3sGFj/X58U8ou88+7A==; 5:8eLo8q4HEvHyN2zDGEzAzGF9huGBh3jQqKYzMKVM09H9zPAdr8FA3LzPxGgxLFRfhdFyIaDxrvvAbTqh98/ZHnqxLws4Fw+1UhbNRmjncZ/CJCT/5/U1lMLX6RaLsVx3GsNX++tOaGO10FhRT3HVVme+5vwWBiNZas1ryfA5tRU=; 7:2T5/18SFGpHK0Ut/NmHxHUcnbRJOVeH8/xLfvyTT6wMAaIveAyePbdVvKD4sv4pyXK99WZNpuxpSsjVLqWajeNkEja/w6jRSPrT35Jjd86kRUk7GXPi9ZyPfR400ydVYaP+4xby4RyKTmOrsPCm9/w==
x-ms-exchange-antispam-srfa-diagnostics: SOS;
x-ms-office365-filtering-correlation-id: dbfd23cf-dc63-4f1a-90d0-08d665d05620
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(49563074)(7193020); SRVR:HE1PR07MB3372;
x-ms-traffictypediagnostic: HE1PR07MB3372:
x-microsoft-antispam-prvs: <HE1PR07MB337255B589337263EF090058F0BE0@HE1PR07MB3372.eurprd07.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(999002)(102415395)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231475)(944501520)(4983020)(52105112)(10201501046)(3002001)(148016)(149066)(150057)(6041310)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:HE1PR07MB3372; BCL:0; PCL:0; RULEID:; SRVR:HE1PR07MB3372;
x-forefront-prvs: 0891BC3F3D
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(346002)(376002)(39860400002)(136003)(396003)(199004)(189003)(13464003)(55016002)(256004)(11346002)(9686003)(4326008)(6246003)(14454004)(74316002)(76176011)(26005)(6506007)(53546011)(53936002)(102836004)(44832011)(5660300001)(8936002)(99286004)(7696005)(33656002)(81156014)(25786009)(476003)(3846002)(6116002)(99936001)(106356001)(2906002)(478600001)(105586002)(446003)(305945005)(486006)(81166006)(8676002)(7736002)(186003)(68736007)(71200400001)(71190400001)(4001150100001)(97736004)(86362001)(2501003)(66066001)(6436002)(229853002)(110136005)(54906003)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR07MB3372; H:HE1PR07MB4329.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
x-microsoft-antispam-message-info: aD3XTayFcwyXo0tJy4C/CfS+e4+5TPoMaA7QrvnjO+NlxpBiBF6ewHbZwWYcmOHnjr5ci4fzwSODlkeiiG5crPL5ckwyOBWfHyvtT19FijNuOdXN/jl5/p+aiOtoh+AJKJ4m5n3vbhZUWZQj9MM3jBdNaEYju/sa0qkba/loE1pfI9qIqypT7IBnrWGOGmzldoAuh70PF83Vss6L2CU9+I4XxjJ4trwqW5PhX/RrdxFBmFO72CXMOKstUbQIeyzJeJ5ZkH1Wl/JvnoNRt5GhqY5DOfta8PRkx0lZp7aIiAW4bXUOJoWnTYhb6mONkvua
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/signed; protocol="application/x-pkcs7-signature"; micalg=SHA1; boundary="----=_NextPart_000_061D_01D497C1.945E5740"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: dbfd23cf-dc63-4f1a-90d0-08d665d05620
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2018 16:37:59.0070 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR07MB3372
X-OriginatorOrg: ericsson.com
X-Brightmail-Tracker: H4sIAAAAAAAAA03SbUhTURgH8M69d9t1OLjdNB8WKq4sUHQlGsMsqi+JZPihKGJUU29l6pTd JZlfBDHK90wDl6TphFi+l6hZqEspLcxW2pzi8i2zmWWRqCtL71nQt9/D8z8vz+HQJGsRyekE rZ7TaTVJCrGUKjvVqg+a4+Xq3TdbpCqb0yxWTZdbKdVQwRCl+thUQakKHnehg6JIo3GFiGxa raZiiNPSiHguKSGN0ykPnJNeHG++hVLrYq4UL66JMtHA0RzkRgMTCtlPesQ5SEqzTA+C8fx5 ChdLCDrrfiBcGAm4a3wrFBRTRMLaB5sEd4oJsLb+dBWTCIxVOeu70bSYCYdps3CIB3MCnn1/ IWRIpgaBbWGM2MhsYaLhnTUKZ45Bd9t7hB0CJkOnYIrxh4XlXmLDMkYNa7WrglnmELQ/f0hu 2I05DMb8JcmGEeMNRR1VwlqS8QLbdAWBB/WAiTcvxdieMDe1JsL5WGjIbnNl/GDQZHDZGywV uQh7WAxllRHYQfCttJTEjoY6h1WYCxgbgtHO1yLcCIDugduuwxKh0NZPYfuAKX+CwgvmSehq nyKLkNLw32UNwiPdRNBXMioxCFNvhr6yaQqHAmFmZMZlX2j9Uk5i74dP/XYJth+U5E64HAaO 3kVUiWgT8uQ5nk++EBISzOkS4ng+RRus5fTNaP13dT9yhreh7tlDZsTQSOEuG0iRq1mRJo1P TzajHev7TDY+GERySpui5RQeMmvoelsWr0m/yulSzuouJ3G8GW2jKYWX7Be7Wc0yFzR6LpHj Ujndvy5Bu8kz0cmGO4Hbj+cd0dX3E6Wv0jviqgcjWpwmy0TNteGd7j4eoj8ZW+2ZWQ1mU5TT WbWwyZGkHFJ0NAbfKz//opbNG1mJVfa0XbLvmqLt17O89ftuhEn6yN4MZaGCfbroe6cwcSzz a/2ZKP/XlN1iXXbc9kx3sPV+o3vvZ/22NLbMflZQ/EXNngBSx2v+AqGRjSVlAwAA
Archived-At: <https://mailarchive.ietf.org/arch/msg/ccamp/lyc2LJ-I9DrzjMfTV1vp5ewOl50>
Subject: Re: [CCAMP] Yangdoctors last call review of draft-ietf-ccamp-alarm-module-06
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Dec 2018 16:38:08 -0000

Thanks a lot Carl!

BR
Daniele

-----Original Message-----
From: Carl Moberg <calle@tail-f.com>
Sent: den 19 december 2018 16:56
To: yang-doctors@ietf.org
Cc: draft-ietf-ccamp-alarm-module.all@ietf.org; ccamp@ietf.org; ietf@ietf.org
Subject: Yangdoctors last call review of draft-ietf-ccamp-alarm-module-06

Reviewer: Carl Moberg
Review result: Ready

I have reviewed this document as part of the YANG doctors directorate's 
ongoing effort to review all IETF documents being processed by the IESG. 
These comments were written with the intent of improving the operational 
aspects of the IETF drafts. Comments that are not addressed in last call may 
be included in AD reviews during the IESG review.  Document editors and WG 
chairs should treat these comments just like any other last call comments.

This document includes two YANG modules:
- ietf-alarms-x733@2018-11-22.yang
- ietf-alarms@2018-11-22.yang

..and an example YANG module:
- example-xyz-alarms.yang

The modules are valid, well-written, concise and provide ample documentation.

I have pointed out two small spelling errors in descriptive text, but will 
leave it to the editors to decide on the potential need for submitting a new 
version.