Re: [CCAMP] YANG issue in draft-ietf-ccamp-alarm-module

Daniele Ceccarelli <daniele.ceccarelli@ericsson.com> Fri, 22 March 2019 13:31 UTC

Return-Path: <daniele.ceccarelli@ericsson.com>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D28BC129619 for <ccamp@ietfa.amsl.com>; Fri, 22 Mar 2019 06:31:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.301
X-Spam-Level:
X-Spam-Status: No, score=-4.301 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com header.b=PcrMlsyu; dkim=fail (1024-bit key) reason="fail (body has been altered)" header.d=ericsson.com header.b=Pr6qqj6X
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sQ8aHKxW41KK for <ccamp@ietfa.amsl.com>; Fri, 22 Mar 2019 06:31:33 -0700 (PDT)
Received: from sessmg22.ericsson.net (sessmg22.ericsson.net [193.180.251.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9ED54129532 for <ccamp@ietf.org>; Fri, 22 Mar 2019 06:31:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/relaxed; q=dns/txt; i=@ericsson.com; t=1553261490; x=1555853490; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=zek7x0V/YAgAePwOG2c3hN2jPsJQj8dLbExTZzcjFbA=; b=PcrMlsyuGY2lpMIht0agmLEyIxUTtqtQCJw82uyuciSkWGzleybTAwg/vfLf7EIw eGUjzVGj2Kt+ld4kYYpOqTQVTibY5xbg7RjuuqqLQb5UW+qhDDOLewJmAHbRRFjz OrP2F+aUIVD2EXi8ywvV9x63C+mxLburGQK3MWUAxX8=;
X-AuditID: c1b4fb3a-017ff70000001645-56-5c94e3b2bbe6
Received: from ESESBMB505.ericsson.se (Unknown_Domain [153.88.183.118]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id 62.C0.05701.2B3E49C5; Fri, 22 Mar 2019 14:31:30 +0100 (CET)
Received: from ESESSMR504.ericsson.se (153.88.183.126) by ESESBMB505.ericsson.se (153.88.183.188) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Fri, 22 Mar 2019 14:31:30 +0100
Received: from ESESSMB504.ericsson.se (153.88.183.165) by ESESSMR504.ericsson.se (153.88.183.126) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Fri, 22 Mar 2019 14:31:30 +0100
Received: from EUR01-VE1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB504.ericsson.se (153.88.183.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Fri, 22 Mar 2019 14:31:29 +0100
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JvXZX+0fp/xnjuFRld+381sm9fAGY3D2jerh5dADTIg=; b=Pr6qqj6XBTUc3cPwZ1zk74MWGHd7uR7WjToaNnyA6WMHxmzVLBoyFawH/r0F9sHMYG8cUU0KN5mWP40aFP/cUmB/34mc8FmIZEVLLP3iD3uGeKG+Rc2D8RKA9HX+ZOnVOhosPvWQIc7O4Ddo/S7931QDDCew4wGvSYYaU2v/hHA=
Received: from VI1PR07MB5040.eurprd07.prod.outlook.com (20.177.203.20) by VI1PR07MB4112.eurprd07.prod.outlook.com (52.134.21.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1730.13; Fri, 22 Mar 2019 13:31:28 +0000
Received: from VI1PR07MB5040.eurprd07.prod.outlook.com ([fe80::bc6b:5dd0:1556:65e0]) by VI1PR07MB5040.eurprd07.prod.outlook.com ([fe80::bc6b:5dd0:1556:65e0%4]) with mapi id 15.20.1730.017; Fri, 22 Mar 2019 13:31:28 +0000
From: Daniele Ceccarelli <daniele.ceccarelli@ericsson.com>
To: Martin Bjorklund <mbj@tail-f.com>, "ccamp@ietf.org" <ccamp@ietf.org>
Thread-Topic: [CCAMP] YANG issue in draft-ietf-ccamp-alarm-module
Thread-Index: AQHU4KzahdYV2jnyzkKXOqdFwr574KYXpSFA
Date: Fri, 22 Mar 2019 13:31:28 +0000
Message-ID: <VI1PR07MB5040A36792A27C74E9BD53ECF0430@VI1PR07MB5040.eurprd07.prod.outlook.com>
References: <20190322.134249.387057810261874257.mbj@tail-f.com>
In-Reply-To: <20190322.134249.387057810261874257.mbj@tail-f.com>
Accept-Language: it-IT, en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-originating-ip: [93.38.67.165]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 13a90f35-1ee3-4b61-cb71-08d6aecab036
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600127)(711020)(4605104)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(49563074)(7193020); SRVR:VI1PR07MB4112;
x-ms-traffictypediagnostic: VI1PR07MB4112:
x-microsoft-antispam-prvs: <VI1PR07MB411280AF1DB2808A6DA415F1F0430@VI1PR07MB4112.eurprd07.prod.outlook.com>
x-forefront-prvs: 09840A4839
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(396003)(376002)(39860400002)(366004)(136003)(189003)(199004)(13464003)(55016002)(86362001)(6246003)(6506007)(14454004)(6306002)(74316002)(68736007)(53936002)(3846002)(33656002)(97736004)(6116002)(99936001)(9686003)(99286004)(8676002)(966005)(6436002)(186003)(478600001)(486006)(229853002)(44832011)(52536014)(7696005)(110136005)(105586002)(2906002)(25786009)(316002)(81156014)(66066001)(81166006)(446003)(53546011)(102836004)(26005)(11346002)(76176011)(6346003)(5660300002)(2501003)(256004)(106356001)(305945005)(8936002)(7736002)(476003)(71190400001)(14444005)(71200400001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR07MB4112; H:VI1PR07MB5040.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
authentication-results: spf=none (sender IP is ) smtp.mailfrom=daniele.ceccarelli@ericsson.com;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: F1/z7lqQscTwl1eUGn9raYUUZps9h/xwIJgdkpppMEgiNN2iqbd20UWDUjT9YVj0OF5mVO5ukxp3rSUVb77O3ZsaVOD5DAGf9Z9NApwP+Vb7tw7YBHeLhUGFJ0voG6ZTh1liEPzYa51vhhZgdOau/DFqwWQXBe4Df6ZL0/nau+/0LtPJbueuMprQpCM9+WE2HMlo5V62YiQ+zTIo8cPAaUzHuBiFFn2Vklyjh+oRIBfcd3wvNRSeNhHDdXj/oN3cxf1d/Rqs4yFUFTigLPcRW8nF13y5BAJQD3zMCDAa7EQKvew9JWittF8hOk1iCbpiJoVMsBSYv8ZlLfmovoaljW9GW2YeSZ2IShJKCKwzNJ0TaEfDLVja++YrPSQhMgN4pGJLHPkcrB7zKnHqkXjMnV5f/dratS1zHu3M72rtcvI=
Content-Type: multipart/signed; protocol="application/x-pkcs7-signature"; micalg=SHA1; boundary="----=_NextPart_000_0826_01D4E0BB.EE7554C0"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 13a90f35-1ee3-4b61-cb71-08d6aecab036
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2019 13:31:28.1861 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR07MB4112
X-OriginatorOrg: ericsson.com
X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTcRjG+59zth2no79T82Wl2bAQIzUrkJGl+EVIqw+GlpNaerygTtlZ 5vyklSFOa+bIC4piVjaT1CytKHUo5jTxgmGmlTq8dIMwvGRW286Kvv3e28PzwEuT4i6ehE5R qhmVUpEm5Qupipj2rH2tc3p5wGbeniBz1QQVpNXOC0KI8Pr6dSK85cct6iRxRng4gUlLyWJU /kfOCZNN+ptk5vXE7A8jzrlo+nQhcqABH4SRompBIRLSYtyDoHqsn+SKFQQNg8vUv2LiVSfB FfUEmAuGbWsU1pEwvtnP4yY3CBifMlBWZTGeRaBdlxQimuZjGZiNEda2Kw6H+4YlgZVdcAis lnWSXD8UcgfyKY4D4UrVbxtTeDd8nSywsQjLoW1pyC5/FJa7pvlWdrDoDL6otTHCHqB7Voes TGJ3mDTXEFxQV5gZGeBz7AZLc794HHvBo9E+imMPGK3RIqtlwJHQMuhvjQV4DsHk21r7ji8U lZfaNVNhw1hs19wBl7rLedxBHh/W7lWTnFEG7jblI87ceXiQ32E/9gRD8QylQ3sr//Naabkn cQmCz7PfeZW20M7QX2GmKi2mSOwHV1sQt78T2r9UkRwHw6LpvYDjXaDXztj5EHzq/YZqEW1A bizDsulJgYF+jColnmUzlH5KRt2KLL/U3bYh60DdC6FGhGkkdRLNv9PLxTxFFqtJNyJvi85s c+MwklDKDCUjdRU9jS2Vi0UJCk0Oo8o4q7qQxrBGtJ2mpO6in2JnuRgnKdRMKsNkMqq/U4J2 kOSi1LCHMUHZdY7r0USbZ9jxJ45vouktM6aaqTiNubN3uClqQ9CXmM2qFZELYRWdi17LusWE 56bolciuhioX4+pSQFmSF4W3Ptbc+SgNb8w8lVMke+nDl4zc1l+sj1BHmfsHI5sHnE70rHkP xU3qpie2XTtgeu3jIzsWnBpbMnY5XkqxyYr9vqSKVfwBfUsxNVMDAAA=
Archived-At: <https://mailarchive.ietf.org/arch/msg/ccamp/m7WRM5YrXK4ZgcSn5Vc61P0wIo8>
Subject: Re: [CCAMP] YANG issue in draft-ietf-ccamp-alarm-module
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Mar 2019 13:31:35 -0000

Thanks a lot Martin for finding the issue and letting the WG know about it. 

> I.e., change it to an enumeration leaf with a default value, and add an
additional leaf to set the severity level when the enum "severity-level" is
set.

I don't see this as a major change. Please update the draft, we won't need
another round of review.

Thanks

Daniele  

-----Original Message-----
From: CCAMP <ccamp-bounces@ietf.org> On Behalf Of Martin Bjorklund
Sent: den 22 mars 2019 13:43
To: ccamp@ietf.org
Subject: [CCAMP] YANG issue in draft-ietf-ccamp-alarm-module

Hi,

When we fixed the review comments for this draft, I found an issue with the
current YANG model.  Currently we have:


         choice notify-status-changes {
           description
             "This leaf controls the notifications sent for alarm status
              updates.  There are three options:

              [...]";

           leaf notify-all-state-changes {
             type empty;
             description
               "Send notifications for all status changes.";
           }
           leaf notify-raise-and-clear {
             type empty;
             description
               "Send notifications only for raise, clear, and re-raise.
                Notifications for severity level changes or alarm text
                changes are not sent.";
           }
           leaf notify-severity-level {
             type severity;
             description
               "Only send notifications for alarm state changes crossing
                the specified level.  Always send clear notifications.";
           }
         }


First of all, the description refers to the choice as a leaf; the main text
has the same issue.

But worse is that it isn't described what happens if no leafs in this choice
are configured.  What is the default?

Since the leafs are of type empty we can't just add a default statement to
the choice.

So we suggest the following updated model to fix this issue:

      leaf notify-status-changes {
        type enumeration {
          enum all-state-changes {
            description
              "Send notifications for all status changes.";
          }
          enum raise-and-clear {
            description
              "Send notifications only for raise, clear, and
               re-raise.  Notifications for severity level changes or
               alarm text changes are not sent.";
          }
          enum severity-level {
            description
              "Only send notifications for alarm state changes
               crossing the level specified in
               'notify-severity-level'.  Always send clear
               notifications.";
          }
        }
        must '. != "severity-level" or ../notify-severity-level' {
          description
            "When notify-status-changes is 'severity-level', a value
             must be given for notify-severity-level.";
        }
        default "all-state-changes";
        description
          "This leaf controls the notifications sent for alarm status
           updates.  There are three options:

           [...]";
      }
      leaf notify-severity-level {
        when '../notify-status-changes = "severity-level"';
        type severity;
        description
          "Only send notifications for alarm state changes crossing
           the specified level.  Always send clear notifications.";
      }


I.e., change it to an enumeration leaf with a default value, and add an
additional leaf to set the severity level when the enum "severity-level" is
set.

Note that it doesn't change any major concepts; it is a model change to
better describe the semantics.

Unless we hear any objections, we'll make this change in the updated draft
that will be sent to the IESG.



/martin

_______________________________________________
CCAMP mailing list
CCAMP@ietf.org
https://www.ietf.org/mailman/listinfo/ccamp