Re: [CCAMP] WG Last Call: WSON documents - rwa-info, general-constraint-encode, rwa-wson-encode, gmpls-general-constraints-ospf-te, wson-signal-compatibility-ospf, wson-signaling

Leeyoung <leeyoung@huawei.com> Mon, 28 October 2013 20:44 UTC

Return-Path: <leeyoung@huawei.com>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CF66421E80D0 for <ccamp@ietfa.amsl.com>; Mon, 28 Oct 2013 13:44:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.599
X-Spam-Level:
X-Spam-Status: No, score=-6.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, RCVD_IN_DNSWL_MED=-4]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aMatcoNaYT72 for <ccamp@ietfa.amsl.com>; Mon, 28 Oct 2013 13:44:22 -0700 (PDT)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) by ietfa.amsl.com (Postfix) with ESMTP id 34F6211E828D for <ccamp@ietf.org>; Mon, 28 Oct 2013 13:44:16 -0700 (PDT)
Received: from 172.18.7.190 (EHLO lhreml203-edg.china.huawei.com) ([172.18.7.190]) by lhrrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id AXH69312; Mon, 28 Oct 2013 20:44:14 +0000 (GMT)
Received: from LHREML404-HUB.china.huawei.com (10.201.5.218) by lhreml203-edg.huawei.com (172.18.7.221) with Microsoft SMTP Server (TLS) id 14.3.158.1; Mon, 28 Oct 2013 20:43:53 +0000
Received: from DFWEML406-HUB.china.huawei.com (10.193.5.131) by lhreml404-hub.china.huawei.com (10.201.5.218) with Microsoft SMTP Server (TLS) id 14.3.158.1; Mon, 28 Oct 2013 20:44:10 +0000
Received: from dfweml511-mbs.china.huawei.com ([169.254.15.141]) by dfweml406-hub.china.huawei.com ([10.193.5.131]) with mapi id 14.03.0158.001; Mon, 28 Oct 2013 13:44:06 -0700
From: Leeyoung <leeyoung@huawei.com>
To: "Margaria, Cyril (Coriant - DE/Munich)" <cyril.margaria@coriant.com>, "CCAMP (ccamp@ietf.org)" <ccamp@ietf.org>
Thread-Topic: [CCAMP] WG Last Call: WSON documents - rwa-info, general-constraint-encode, rwa-wson-encode, gmpls-general-constraints-ospf-te, wson-signal-compatibility-ospf, wson-signaling
Thread-Index: Ac7PFPsDhmt/uF1bTWymUSOtwlOYqwE+7vGg
Date: Mon, 28 Oct 2013 20:44:05 +0000
Message-ID: <7AEB3D6833318045B4AE71C2C87E8E17291DCC3F@dfweml511-mbs.china.huawei.com>
References: <523C37072C291347B9730C9291CCA07D02DE3549@DB3PRD0411MB427.eurprd04.prod.outlook.com>
In-Reply-To: <523C37072C291347B9730C9291CCA07D02DE3549@DB3PRD0411MB427.eurprd04.prod.outlook.com>
Accept-Language: en-US, zh-CN
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.192.11.126]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Subject: Re: [CCAMP] WG Last Call: WSON documents - rwa-info, general-constraint-encode, rwa-wson-encode, gmpls-general-constraints-ospf-te, wson-signal-compatibility-ospf, wson-signaling
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ccamp>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Oct 2013 20:44:34 -0000

Hi Cyril

Thanks for this comprehensive review of all WSON documents. 
I have resolved all the issues you raised except the signaling draft (Hopefully, Giovanni can answer your comment for the signaling draft).

Please see inline for my comment. Thanks.

Regards,
Young

-----Original Message-----
From: ccamp-bounces@ietf.org [mailto:ccamp-bounces@ietf.org] On Behalf Of Margaria, Cyril (Coriant - DE/Munich)
Sent: Tuesday, October 22, 2013 5:54 AM
To: CCAMP (ccamp@ietf.org)
Subject: Re: [CCAMP] WG Last Call: WSON documents - rwa-info, general-constraint-encode, rwa-wson-encode, gmpls-general-constraints-ospf-te, wson-signal-compatibility-ospf, wson-signaling


http://tools.ietf.org/html/draft-ietf-ccamp-rwa-info-18

I've reviewed this document and believe it is ready for publication, with comments:
I think the document is good to go, I have two editorial comments:
 - I find the document history good to have, but maybe in an annex.
 - My stable mail address is cyril.margaria@gmail.com , affiliation is Coriant.

**YOUNG>> History will normally be removed by RFC Editors as it is close to the final version. Will correct your affiliation. 

http://tools.ietf.org/html/draft-ietf-ccamp-general-constraint-encode-11

I've reviewed this document and believe it is ready for publication, with comment:
I have the same comment as the rwa info regarding the history to be maybe moved to the annex 

**YOUNG>> Same comment for history as above.

http://tools.ietf.org/html/draft-ietf-ccamp-rwa-wson-encode-21

I've reviewed this document and believe it is ready for publication, with comments:
- editorial: The document history could be moved to the annex 
- section 3.3 : rbState (16 bit) : nits : is it signed or unsigned integer ? I would tend to understand unsigned.
- My stable mail address is cyril.margaria@gmail.com , affiliation is Coriant, not NSN

**YOUNG>> Added RB State (16 bit unsigned integer). Will correct your affiliation. 

http://tools.ietf.org/html/draft-ietf-ccamp-gmpls-general-constraints-ospf-te-05

I've reviewed this document and believe it is ready for publication

http://tools.ietf.org/html/draft-ietf-ccamp-wson-signal-compatibility-ospf-12

I've reviewed this document and believe it is ready for publication, with comments:
- editorial: The document history could be moved to the annex 
- Section 2 : the section reference to WSON-Encode are wrong (this affect section 2, section 2.1
- Section 3 : it would be useful to reference the exact section of [Gen-encode] for the Available Label Sub-TLV and  Shared Backup Label Sub-TLV. 

YOUNG>> Agreed. Corrected all. Section 2.3 and 2.4 are referenced in Section 3. 

http://tools.ietf.org/html/draft-ietf-ccamp-wson-signaling-06 
I've reviewed this document and I have the following comments:
 - section 4.3 : "If more than two objects are encountered,
   two MUST be processed and the rest SHOULD be ignored."
	This is ambiguous : the section refers to the RB information sub tlv, does this refers to the WSON_signaling object or RBInformation?
 - section 4.3 : http://trac.tools.ietf.org/wg/ccamp/trac/ticket/52, please remove this paragraph, the restriction is strong and would not allow a node to choose one RB per local policy /sharing.. etc
 - section 7 : the section assume a LSP_REQUIRED_ATTRIBUTE, but this is a targeted information as described in section 4.2, or should it be distinguished between targeted attribute (to be assigned in the ERO HOP_attribut, this depends on the space choosen by the draft-ietf-ccamp-lsp-attribute-ro) and e2e attribute (WA)?.
 

Best Regards/ Mit freundlichen Grüßen
Cyril Margaria

cyril.margaria@gmail.com
http://www.coriant.com

Coriant R&D GmbH
Geschäftsleitung / Board of Directors: Robert Richter, Rolf Nauerz 
Sitz der Gesellschaft: München / Registered office: Munich
Registergericht: München / Commercial registry: Munich, HRB 197143


_______________________________________________
CCAMP mailing list
CCAMP@ietf.org
https://www.ietf.org/mailman/listinfo/ccamp