Re: [CCAMP] [RTG-DIR] RTG-DIR QA Review: draft-ietf-ccamp-dwdm-if-mng-ctrl-fwk

"Gabriele Maria Galimberti (ggalimbe)" <ggalimbe@cisco.com> Mon, 04 September 2017 15:01 UTC

Return-Path: <ggalimbe@cisco.com>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D349C132C28; Mon, 4 Sep 2017 08:01:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.52
X-Spam-Level:
X-Spam-Status: No, score=-14.52 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7iRvhoVnG1hB; Mon, 4 Sep 2017 08:01:01 -0700 (PDT)
Received: from rcdn-iport-4.cisco.com (rcdn-iport-4.cisco.com [173.37.86.75]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B0CD91321A1; Mon, 4 Sep 2017 08:01:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=35169; q=dns/txt; s=iport; t=1504537261; x=1505746861; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=UEdNMLL1qt7Nkw2poMaBOnVHhRkKXQJjm4iyyYIWSrI=; b=C0kYkYmi8KP/YMVdzNkTlXhdcSIbiRuSbaiPSvjwfNp8n+psdmNP0qPc 9ztTmoVCWJmWgP4ShflO8IrdZ0S9zLikhjZGZo/W1lI6EIPpLTqaA1LEX UXFC/BvljQhnvEnH+4UiXjkep8E3GAxuZEhbkeWbw1YlG+Xc3i8jISp+V w=;
X-Files: image001.png : 1632
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0DFAgA5aq1Z/4kNJK1dGQEBAQEBAQEBAQEBBwEBAQEBgm9rZIEVB4NwmkGBTyKIOZABBwECH4UfAhqEAkMUAQIBAQEBAQEBayiFGAEBAQEDBR4CCAEbHhIOAgIBCBEDAQEBBgEBARgHAwICAgUQAQMGBQwUCQgCBAENBAEGCIgFggYDFRC0WoInJ4NvAYMcDYQSAQEBAQEBAQEBAQEBAQEBAQEBAQEBDg8FgyWCAoFOgWMrC4Jyglc8gXAJCQwKAoJbMIIxBZg0iAQ8AoZYAYkAhHaCE4VnineMU4grAgMLAhgBgTgBNiFBTHcVWwGGTQE6dgGKCYEPAQEB
X-IronPort-AV: E=Sophos;i="5.41,475,1498521600"; d="png'150?scan'150,208,217,150";a="291134177"
Received: from alln-core-4.cisco.com ([173.36.13.137]) by rcdn-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 04 Sep 2017 15:00:30 +0000
Received: from XCH-RTP-008.cisco.com (xch-rtp-008.cisco.com [64.101.220.148]) by alln-core-4.cisco.com (8.14.5/8.14.5) with ESMTP id v84F0Sr2032328 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 4 Sep 2017 15:00:28 GMT
Received: from xch-rtp-010.cisco.com (64.101.220.150) by XCH-RTP-008.cisco.com (64.101.220.148) with Microsoft SMTP Server (TLS) id 15.0.1263.5; Mon, 4 Sep 2017 11:00:27 -0400
Received: from xch-rtp-010.cisco.com ([64.101.220.150]) by XCH-RTP-010.cisco.com ([64.101.220.150]) with mapi id 15.00.1263.000; Mon, 4 Sep 2017 11:00:27 -0400
From: "Gabriele Maria Galimberti (ggalimbe)" <ggalimbe@cisco.com>
To: Keyur Patel <keyur@arrcus.com>, rtg-dir <rtg-dir-bounces@ietf.org>, "rtg-ads@ietf.org" <rtg-ads@ietf.org>, "draft-ietf-ccamp-dwdm-if-mng-ctrl-fwk.all@ietf.org" <draft-ietf-ccamp-dwdm-if-mng-ctrl-fwk.all@ietf.org>, Daniele Ceccarelli <daniele.ceccarelli@ericsson.com>
CC: Jonathan Hardwick <Jonathan.Hardwick@metaswitch.com>, "Yemin (Amy)" <amy.yemin@huawei.com>, "ccamp@ietf.org" <ccamp@ietf.org>, Julien Meuric <julien.meuric@orange.com>, Ruediger Kunze <RKunze@telekom.de>, Gert Grammel <ggrammel@juniper.net>, Dieter Beller <Dieter.Beller@nokia.com>
Thread-Topic: [RTG-DIR] RTG-DIR QA Review: draft-ietf-ccamp-dwdm-if-mng-ctrl-fwk
Thread-Index: AQHTD+GB2gf7k6mHdEybYLIVBrrqwg==
Date: Mon, 04 Sep 2017 15:00:27 +0000
Message-ID: <8CA8FA36-7CB8-4170-AF94-FC222F5852D9@cisco.com>
References: <1A44565B-2B86-456E-869B-E3E5F09471CF@arrcus.com> <AM2PR07MB0994CE1E92756AF786354F22F0850@AM2PR07MB0994.eurprd07.prod.outlook.com>
In-Reply-To: <AM2PR07MB0994CE1E92756AF786354F22F0850@AM2PR07MB0994.eurprd07.prod.outlook.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/f.1d.0.161209
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.228.192.29]
Content-Type: multipart/related; boundary="_004_8CA8FA367CB84170AF94FC222F5852D9ciscocom_"; type="multipart/alternative"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/ccamp/p7auITo_5TJHVL0DCOTbga_CwUs>
Subject: Re: [CCAMP] [RTG-DIR] RTG-DIR QA Review: draft-ietf-ccamp-dwdm-if-mng-ctrl-fwk
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Sep 2017 15:01:06 -0000

Hi Keyur,

Thanks for the comments and the support.

We mostly accepted the suggested modifications and a -07 doc.  version will be posted soon.
Please see the responses in line (R.)

Best Regards,

The Authors

[ttp://www.cisco.com/swa/i/logo.gif]


Gabriele Galimberti
Principal Engineer
Cisco Photonics Srl


via S.Maria Molgora, 48 C
20871 - Vimercate (MB)
Italy
www.cisco.com/global/IT/<http://www.cisco.com/global/IT/>

ggalimbe@cisco.com<mailto:ggalimbe@cisco.com>
Phone :+39 039 2091462
Mobile :+39 335 7481947
Fax :+39 039 2092049













From: Daniele Ceccarelli <daniele.ceccarelli@ericsson.com>
Date: Wednesday, 23 August 2017 at 14:18
To: Keyur Patel <keyur@arrcus.com>, rtg-dir <rtg-dir-bounces@ietf.org>, "rtg-ads@ietf.org" <rtg-ads@ietf.org>, "draft-ietf-ccamp-dwdm-if-mng-ctrl-fwk.all@ietf.org" <draft-ietf-ccamp-dwdm-if-mng-ctrl-fwk.all@ietf.org>
Cc: Jonathan Hardwick <Jonathan.Hardwick@metaswitch.com>, "Yemin (Amy)" <amy.yemin@huawei.com>, "ccamp@ietf.org" <ccamp@ietf.org>
Subject: RE: [RTG-DIR] RTG-DIR QA Review: draft-ietf-ccamp-dwdm-if-mng-ctrl-fwk
Resent-From: <alias-bounces@ietf.org>
Resent-To: Ruediger Kunze <RKunze@telekom.de>, Gert Grammel <ggrammel@juniper.net>, Dieter Beller <dieter.beller@nokia.com>, Gabriele Galimberti <ggalimbe@cisco.com>, <julien.meuric@orange.com>, OSCAR GONZALEZ DE DIOS <oscar.gonzalezdedios@telefonica.com>, Fatai Zhang <zhangfatai@huawei.com>, <daniele.ceccarelli@ericsson.com>, <aretana@cisco.com>, Deborah Brungard <db3546@att.com>, <akatlas@gmail.com>
Resent-Date: Wednesday, 23 August 2017 at 14:18

Hi Keyur,

thanks a lot for your review. We will work together with the authors to have your comments addressed as well as the ones raised during the last meeting.

Thank you
Daniele

From: Keyur Patel [mailto:keyur@arrcus.com]
Sent: martedì 8 agosto 2017 02:59
To: rtg-dir <rtg-dir-bounces@ietf.org>; rtg-ads@ietf.org; draft-ietf-ccamp-dwdm-if-mng-ctrl-fwk.all@ietf.org
Cc: Daniele Ceccarelli <daniele.ceccarelli@ericsson.com>; Jonathan Hardwick <Jonathan.Hardwick@metaswitch.com>; Yemin (Amy) <amy.yemin@huawei.com>; ccamp@ietf.org
Subject: [RTG-DIR] RTG-DIR QA Review: draft-ietf-ccamp-dwdm-if-mng-ctrl-fwk

Hi,

I have been selected as the Routing Directorate QA reviewer for this draft.

Document: draft-item-ccamp-dwdm-if-mng-ctrl-fwk
Reviewer: Keyur Patel
Review Date: August 7, 2017
Intended Status: Informational Track

Here are my comments.

Overall, the document is well organized and clear about the problem statement and requirements for the framework for Management and Control of DWDM optical interface. This document could simplify early draft sections text and fix few typos + grammatical errors.

Attached are my comments:

1 - Section 1, Consider replacing: "Carriers deploy their networks today based on transport und packet" with "Carriers deploy their networks today based on transport and packet".
R. Accepted.

2 - Section 1, Last Paragraph, consider replacing: "Optical routing and wavelength assignment based on WSON is out of scope although can benefit of the way the optical parameters are exchanged between the Client and the DWDM Network." with: "Although Optical routing and wavelength assignment based on WSON is out of scope, they can benefit from the optical parameters that are exchanged between the Client and the DWDM Network."
R. accepted

3 - Section 2, first Paragraph, consider replacing: "The DWDM interfaces migration…" with "The DWDM interface migration..."
R. Accepted

4 - Section 2, fifth Paragraph: "Administrative domain [G.805]: For the purposes of this Recommendation"
   Perhaps the authors meant "this document" as oppose to "this Recommendation"?
R. accepted, modified text

5 - Section 3.1.2 last Paragraph: "The following documents[DWDM-interface-MIB], [YANG], [LMP] define such a protocol- FIX-THE-REFERENCE specific information using SNMP SMI, Yang models and LMP TLV to support the direct exchange of information between the client and the network management and control plane."
R. modified text

Does this also apply to Section 3.1.1 or it is specific to Section 3.1.2? If so, it should be moved out of Section 3.1.2.
R. YES, Added

6 - Section 4.1.2, third Paragraph and 5.1: LMP uses reliable UDP.  For any Indirect and Direct connections, how does the optical network node recover from partial network configurations upon LMP based adjacency failures? Does that need to be a requirement for LMP extensions?
R.  LMP has a sanity check to verify the connectivity between the client and the network and does not rely on lower layers resiliency.

7 - Section 5.2.1: The alarms that can be generated for use cases mentioned in 5.2.1 can be chatty particularly when sending over LMP (or protocol of choice). Is there a requirement to pace/damp the rate of Alarms (that would be carried within LMP)?
R. Yes, added RFC4204 reference to clarify the alarm information exchanged via LMP