Re: [CCAMP] One comment on draft-zhang-ccamp-flexible-grid-ospf-ext

"Gabriele Maria Galimberti (ggalimbe)" <ggalimbe@cisco.com> Wed, 30 April 2014 07:42 UTC

Return-Path: <ggalimbe@cisco.com>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CFF521A015F for <ccamp@ietfa.amsl.com>; Wed, 30 Apr 2014 00:42:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -15.151
X-Spam-Level:
X-Spam-Status: No, score=-15.151 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RP_MATCHES_RCVD=-0.651, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mJzKwqFwQSl0 for <ccamp@ietfa.amsl.com>; Wed, 30 Apr 2014 00:42:08 -0700 (PDT)
Received: from rcdn-iport-6.cisco.com (rcdn-iport-6.cisco.com [173.37.86.77]) by ietfa.amsl.com (Postfix) with ESMTP id 9ECA71A011D for <ccamp@ietf.org>; Wed, 30 Apr 2014 00:42:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=16099; q=dns/txt; s=iport; t=1398843727; x=1400053327; h=from:to:subject:date:message-id:in-reply-to:mime-version; bh=oBgaiicpsYPYEtn4zh1vTlxmSXdgEdrSKpHVLFJO6Ac=; b=KLlc2ICm48DVAqNwDwG8xYbAoZ0lxrWrCADKvrNB4NFU1QhqX5lB4sGS LrW0o9x5JrxIk/m9MelzbYHxtE8LfmisgdL7yQe3Yd49oHQqWOG6aH+zx nStvXApzZVdpnUn1hpnkbAM3wmGrLPOnaodCxm5Yk6v6hSRuvhFX6VunB E=;
X-Files: 273031C1-0F11-4D42-9226-D16B7CB14162[35].png : 1632
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AicFAGeoYFOtJA2F/2dsb2JhbABZgkJET1fEPIEkFnSCJQECBAVEPgQBCBEDAQIGAQEBHwkFEAEDBgUMFAkIAgQBEQEGCIgfAxENwycNhlsXBIw2gTURASQRChcBhDkEhUmNBoRjgXGNEYVZgzGBcjk
X-IronPort-AV: E=Sophos; i="4.97,956,1389744000"; d="png'150?scan'150,208,217,150"; a="321409857"
Received: from alln-core-11.cisco.com ([173.36.13.133]) by rcdn-iport-6.cisco.com with ESMTP; 30 Apr 2014 07:42:07 +0000
Received: from xhc-rcd-x13.cisco.com (xhc-rcd-x13.cisco.com [173.37.183.87]) by alln-core-11.cisco.com (8.14.5/8.14.5) with ESMTP id s3U7g61r014720 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 30 Apr 2014 07:42:06 GMT
Received: from xmb-rcd-x09.cisco.com ([169.254.9.100]) by xhc-rcd-x13.cisco.com ([173.37.183.87]) with mapi id 14.03.0123.003; Wed, 30 Apr 2014 02:42:06 -0500
From: "Gabriele Maria Galimberti (ggalimbe)" <ggalimbe@cisco.com>
To: "wang.lei131@zte.com.cn" <wang.lei131@zte.com.cn>, "ccamp@ietf.org" <ccamp@ietf.org>, "zhang.xian@huawei.com" <zhang.xian@huawei.com>
Thread-Topic: [CCAMP] One comment on draft-zhang-ccamp-flexible-grid-ospf-ext
Thread-Index: AQHPZEOl2EVI9xt2ZU+8jf9CMo+u2JsqPC8A
Date: Wed, 30 Apr 2014 07:42:06 +0000
Message-ID: <CF8674F4.5E1E3%ggalimbe@cisco.com>
In-Reply-To: <OF0A598851.0C5441D6-ON48257CCA.00242580-48257CCA.00279CC7@zte.com.cn>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/14.3.2.130206
x-originating-ip: [144.254.166.61]
Content-Type: multipart/related; boundary="_004_CF8674F45E1E3ggalimbeciscocom_"; type="multipart/alternative"
MIME-Version: 1.0
Archived-At: http://mailarchive.ietf.org/arch/msg/ccamp/tZIZfMiA_IJJBuhl6hxTk-NcCpk
Subject: Re: [CCAMP] One comment on draft-zhang-ccamp-flexible-grid-ospf-ext
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Apr 2014 07:42:11 -0000

I agree with LeWang,

I'd also add that the MaxWidth field must be more than 8 bits (e.g. 16 bits).
This is to align this parameter to the recent ITU liaison reply on m value range.

Best Regards,

Gabriele
[http://www.cisco.com/swa/i/logo.gif]


Gabriele Galimberti
Technical Leader
Cisco Photonics Srl

Via Philips, 12
20900 - Monza (MI)
Italy
www.cisco.com/global/IT/<http://www.cisco.com/global/IT/>

ggalimbe@cisco.com<mailto:ggalimbe@cisco.com>
Phone :+39 039 2091462
Mobile :+39 335 7481947
Fax :+39 039 2092049














From: "wang.lei131@zte.com.cn<mailto:wang.lei131@zte.com.cn>" <wang.lei131@zte.com.cn<mailto:wang.lei131@zte.com.cn>>
Date: Wednesday, April 30, 2014 9:12 AM
To: "ccamp@ietf.org<mailto:ccamp@ietf.org>" <ccamp@ietf.org<mailto:ccamp@ietf.org>>, Xian Zhang <zhang.xian@huawei.com<mailto:zhang.xian@huawei.com>>
Subject: [CCAMP] One comment on draft-zhang-ccamp-flexible-grid-ospf-ext


Hi, Xian and CCAMPers

I have one comment on draft-zhang-ccamp-flexible-grid-ospf-ext:

In section 4.3, page 7, the encoding of "Port Label Restriction sub-TLV" is listed as follows.

     0                   1                   2                   3
     0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
    +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
    | MatrixID      | RstType = TBA |            Reserved           |
    +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
    |     C.F.G     |    S.W.G      |   Min Width   |   Max Width   |
    +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+

In my opinion, it is not necessary to put the field "C.F.G" into this TLV, because that: C.F.G could be deduced from S.W.G (C.F.G = S.W.G / 2).  Would anyone give one example where C.F.G != S.W.G / 2 ?

--------------------------------------------
LeiWang

ZTE
Bearer Network Product Pre_research Department,
Wireline R&D Insititute
Cell phone:+86 13811440067
Email: wang.lei131@zte.com.cn<mailto:wang.lei131@zte.com.cn>
      hechen0001@gmail.com<mailto:hechen0001@gmail.com>
      leiw@tsinghua.edu.cn<mailto:leiw@tsinghua.edu.cn>
----------------------------------------------