Re: [CCAMP] Erik Kline's No Objection on draft-ietf-ccamp-layer0-types-08: (with COMMENT)

Zhenghaomian <zhenghaomian@huawei.com> Wed, 16 December 2020 07:16 UTC

Return-Path: <zhenghaomian@huawei.com>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B77233A106E; Tue, 15 Dec 2020 23:16:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R9vmlc3IIW3X; Tue, 15 Dec 2020 23:16:23 -0800 (PST)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BC14B3A105F; Tue, 15 Dec 2020 23:16:22 -0800 (PST)
Received: from fraeml738-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4CwmZ10mKnz67QYF; Wed, 16 Dec 2020 15:13:29 +0800 (CST)
Received: from fraeml738-chm.china.huawei.com (10.206.15.219) by fraeml738-chm.china.huawei.com (10.206.15.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 16 Dec 2020 08:16:20 +0100
Received: from DGGEML422-HUB.china.huawei.com (10.1.199.39) by fraeml738-chm.china.huawei.com (10.206.15.219) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.1.2106.2 via Frontend Transport; Wed, 16 Dec 2020 08:16:20 +0100
Received: from DGGEML511-MBX.china.huawei.com ([169.254.1.73]) by dggeml422-hub.china.huawei.com ([10.1.199.39]) with mapi id 14.03.0487.000; Wed, 16 Dec 2020 15:16:10 +0800
From: Zhenghaomian <zhenghaomian@huawei.com>
To: Erik Kline <ek.ietf@gmail.com>, The IESG <iesg@ietf.org>
CC: "draft-ietf-ccamp-layer0-types@ietf.org" <draft-ietf-ccamp-layer0-types@ietf.org>, "ccamp-chairs@ietf.org" <ccamp-chairs@ietf.org>, "ccamp@ietf.org" <ccamp@ietf.org>, Daniele Ceccarelli <daniele.ceccarelli@ericsson.com>
Thread-Topic: Erik Kline's No Objection on draft-ietf-ccamp-layer0-types-08: (with COMMENT)
Thread-Index: AdbTeyA2SQN4cwh2SPC5coYlwWe3sA==
Date: Wed, 16 Dec 2020 07:16:10 +0000
Message-ID: <E0C26CAA2504C84093A49B2CAC3261A43FA3DF5F@dggeml511-mbx.china.huawei.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.24.176.98]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/ccamp/v2sAhKSLIyIwKfeQdQO4TuU1j04>
Subject: Re: [CCAMP] Erik Kline's No Objection on draft-ietf-ccamp-layer0-types-08: (with COMMENT)
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Dec 2020 07:16:25 -0000

Hi Erik, 

Thank you for the comments, see inline and refer to the https://github.com/ietf-ccamp-wg/draft-ietf-ccamp-layer0-types/pull/15 for our proposed changes. 

Best wishes,
Haomian (on behalf of all authors)

-----邮件原件-----
发件人: Erik Kline via Datatracker [mailto:noreply@ietf.org] 
发送时间: 2020年11月28日 10:03
收件人: The IESG <iesg@ietf.org>
抄送: draft-ietf-ccamp-layer0-types@ietf.org; ccamp-chairs@ietf.org; ccamp@ietf.org; Daniele Ceccarelli <daniele.ceccarelli@ericsson.com>; daniele.ceccarelli@ericsson.com
主题: Erik Kline's No Objection on draft-ietf-ccamp-layer0-types-08: (with COMMENT)

Erik Kline has entered the following ballot position for
draft-ietf-ccamp-layer0-types-08: No Objection

When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-ccamp-layer0-types/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

[[ nits ]]

[ section 3 ]

* "min-slot-width-factor" and "max-slot-width-factor" could each have their
  description be simplified to refer only their own definition (as opposed
  to the shared duplicated text).

  Also, I'm not sure how to read "...of the slot width , granularity,".
  Should that just be "...of the slot width granularity,"?

[authors] This issue is also mentioned in Rob's review in https://mailarchive.ietf.org/arch/msg/ccamp/EaueCtWSbdlW_-14SB-cc_oOYaQ/. We tweaked the text and the update can be found in https://github.com/ietf-ccamp-wg/draft-ietf-ccamp-layer0-types/pull/15. 

* "this constraints is reported" could use a grammar fix. I'm guessing
  "this constraint is reported"?

[authors] Updated in https://github.com/ietf-ccamp-wg/draft-ietf-ccamp-layer0-types/pull/15 as well.