[CCAMP] Gen-Art LC review draft-ietf-ccamp-gmpls-ospf-g709v3-09

Robert Sparks <rjsparks@nostrum.com> Fri, 11 October 2013 15:16 UTC

Return-Path: <rjsparks@nostrum.com>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (localhost []) by ietfa.amsl.com (Postfix) with ESMTP id C287A11E81C8; Fri, 11 Oct 2013 08:16:15 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.6
X-Spam-Status: No, score=-102.6 tagged_above=-999 required=5 tests=[AWL=-0.000, BAYES_00=-2.599, HTML_MESSAGE=0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([]) by localhost (ietfa.amsl.com []) (amavisd-new, port 10024) with ESMTP id z-nk57K4S8u6; Fri, 11 Oct 2013 08:16:14 -0700 (PDT)
Received: from shaman.nostrum.com (nostrum-pt.tunnel.tserv2.fmt.ipv6.he.net [IPv6:2001:470:1f03:267::2]) by ietfa.amsl.com (Postfix) with ESMTP id 7A8E011E81FE; Fri, 11 Oct 2013 08:16:12 -0700 (PDT)
Received: from unnumerable.local (pool-173-57-89-224.dllstx.fios.verizon.net []) (authenticated bits=0) by shaman.nostrum.com (8.14.3/8.14.3) with ESMTP id r9BFGAlw014938 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=OK); Fri, 11 Oct 2013 10:16:11 -0500 (CDT) (envelope-from rjsparks@nostrum.com)
Message-ID: <52581639.4050602@nostrum.com>
Date: Fri, 11 Oct 2013 10:16:09 -0500
From: Robert Sparks <rjsparks@nostrum.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
MIME-Version: 1.0
To: General Area Review Team <gen-art@ietf.org>, ccamp@ietf.org, draft-ietf-ccamp-gmpls-ospf-g709v3@tools.ietf.org
Content-Type: multipart/alternative; boundary="------------030706070101080604030104"
Received-SPF: pass (shaman.nostrum.com: is authenticated by a trusted mechanism)
Subject: [CCAMP] Gen-Art LC review draft-ietf-ccamp-gmpls-ospf-g709v3-09
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ccamp>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Oct 2013 15:16:15 -0000

I am the assigned Gen-ART reviewer for this draft. For background on
Gen-ART, please see the FAQ at


Please resolve these comments along with any other Last Call comments
you may receive.

Document: draft-ietf-ccamp-gmpls-ospf-g709v3-09
Reviewer: Robert Sparks
Review Date: 11-Oct-2013
IETF LC End Date: 16-Oct-2013
IESG Telechat date: Not yet scheduled for a telechat

Summary: This draft is basically ready for publication, but has nits 
that should be fixed before publication.

This document is dense (as in it puts a lot of information in a small 
number of characters), but it reads clearly.
I did not carefully review the contents of the example fields for 
editorial mistakes - please be sure someone in the group has done that.

The largest issue I see is on the border of being more than a nit. I'm 
calling it a nit because it should be very easy to fix:
The sentence "Same type of modification needs to applied to the 
https://www.iana.org/assignments/ianagmplstc-mib/ianagmplstc-mib" is not 
sufficient instruction to IANA to cause that registry to be modified. 
Please provide more precise
instructions as to how this mib should change.

I note also that the value 40 from RFC6060 didn't make it into the mib.

The rest of these are more nitty nits:

In section 4, I think you've repeated a MUST, and risk introducing 
It's awkward to point to this with paragraph numbers because of the 
interspersed tables, so I'll quote the relevant block:

    When supporting the extensions defined in this document, the
    Switching Capability and Encoding values MUST be used as follows:

    - Switching Capability = OTN-TDM
    - Encoding Type = G.709 ODUk (Digital Path) as defined in [RFC4328]

    Both for fixed and flexible ODUs the same switching type and encoding
    values MUST be used.

If I read that correctly , those are the same MUST and you're saying 
it's a MUST no matter whether you're talking about fixed or flexible ODUs.
If that's correct I suggest replacing this with:

    When supporting the extensions defined in this document, for both
    fixed and flexible ODUs, the Switching Capability and Encoding values
    MUST be used as follows:

    - Switching Capability = OTN-TDM
    - Encoding Type = G.709 ODUk (Digital Path) as defined in [RFC4328]

(or leave out the fixed and flexible clarification altogether - I would 
not have been confused without it).


In section 8.2, where you say "IANA will create and maintain a new 
registry", I suggest you say "new sub-registry".