Re: [CCAMP] I-D Action: draft-ietf-ccamp-wson-yang-18.txt

tom petch <ietfc@btconnect.com> Fri, 07 December 2018 12:48 UTC

Return-Path: <ietfc@btconnect.com>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DF37412D4F1 for <ccamp@ietfa.amsl.com>; Fri, 7 Dec 2018 04:48:46 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 1.738
X-Spam-Level: *
X-Spam-Status: No, score=1.738 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-1.459, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RATWARE_MS_HASH=2.148, RATWARE_OUTLOOK_NONAME=2.95, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id N4fJqdn1nqSq for <ccamp@ietfa.amsl.com>; Fri, 7 Dec 2018 04:48:44 -0800 (PST)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140112.outbound.protection.outlook.com [40.107.14.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D20E112D84D for <ccamp@ietf.org>; Fri, 7 Dec 2018 04:48:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector1-btconnect-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/8lrYHvCcaUr/5PhrWjzqbQjFFHzC8FKO19EmWJXMLI=; b=hWPhiiuRkx9d5B257GeqsHWNVh1gdXAWtIFFD3bB6nQ87d/67+H68Bl7KkFAuZAfzdfffWdBVlzZIrmN1/LjENJozQWgbA1usO1Wu2Mb2awRysGT7GXyPXj+JcRtlGRJWm4zuTIlafrd9w7Gipu07t1+Ka6fuxgxKUJsMiCoQbk=
Received: from VI1PR07MB4717.eurprd07.prod.outlook.com (20.177.54.82) by VI1PR07MB5981.eurprd07.prod.outlook.com (20.178.123.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1425.8; Fri, 7 Dec 2018 12:48:41 +0000
Received: from VI1PR07MB4717.eurprd07.prod.outlook.com ([fe80::1575:d33b:33dd:c7c4]) by VI1PR07MB4717.eurprd07.prod.outlook.com ([fe80::1575:d33b:33dd:c7c4%5]) with mapi id 15.20.1425.010; Fri, 7 Dec 2018 12:48:41 +0000
From: tom petch <ietfc@btconnect.com>
To: Leeyoung <leeyoung@huawei.com>, "ccamp@ietf.org" <ccamp@ietf.org>
Thread-Topic: [CCAMP] I-D Action: draft-ietf-ccamp-wson-yang-18.txt
Thread-Index: AQHUjisu9c/u8tq46UWmazaDkLGE0g==
Date: Fri, 7 Dec 2018 12:48:41 +0000
Message-ID: <002301d48e2a$d9dd0be0$4001a8c0@gateway.2wire.net>
References: <154403028111.31922.11742637644752499043@ietfa.amsl.com> <7AEB3D6833318045B4AE71C2C87E8E173D0A03A9@SJCEML521-MBB.china.huawei.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-clientproxiedby: LO2P265CA0451.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::31) To VI1PR07MB4717.eurprd07.prod.outlook.com (2603:10a6:803:69::18)
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [86.139.215.184]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; VI1PR07MB5981; 6:mGSAb77WbwGOxMyOgufPTKlaOfCMP/c1ROaYge8SAYBFk02vD5Bx43JY9NjBeEGltJ9ubQHOR7k5yFE95ywQN3I8yZTMkE6Y3QbF5lX5aI2b+7MeaIJfWMaFMBoT0mYQhZBcuMDGnsYnWsrNvD1xIslfkYqn2FPkZ7HO/OiOsVbPY9TAP8KfZCTHKiL+e/ISIV8MuWRq31qJoYk9xR+exM1apz/Iz+l4bXPDYfJWzkAfDnP37HUitkJy0ahBwBFkODmvfycYMDvMEc4l7U9U9XjW7fNPODEleubO3CJP6x+hL2bUMeRA5BAv++HIESKAglmnj819B/LiM97tF1ehASQwFOOznaJZ0oLQ9BluH0P48QMX2nBAUa2kFqWtKyCA7JQzBnhNWjE1O37npR8jvypRlifPe+pmLMKc0yGlksxgCVhsM2mGTvlOTKHhHD7jL+CdaHJFTrbMWqSvtmVEGw==; 5:ZvX3S3fAfDILqxRdjiAyJ4Jk9DOYXgSkZHeYJTOezYRQF/t8RGZ+LjngJOW50cyA27Urhp6ODhwnUjNXWpxvmenp+GPbjwn15ZDh3/JHZLWkN0Zy8zI61Rg8x7GTPj+og2H7XVJVzS5zCiX8gSqMMmGIhRIuTILe1k1jxN6Ucnw=; 7:UHK2AyRA5utfLmfqFEmAr3W6lV71beUj3KINBWPClgCtY80FmmdGtn+x+oIOqqS76ay9+xbpBS5+0TCAoT/6IM0qu6uaqV4xFG5hhdxFhP2sxMOOqTCq+wm1KtMC8RmP9EgmSpuC0PDKszvx2xpMrQ==
x-ms-office365-filtering-correlation-id: 3a6ce639-9fa2-4e73-ff32-08d65c4250b4
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7193020); SRVR:VI1PR07MB5981;
x-ms-traffictypediagnostic: VI1PR07MB5981:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=ietfc@btconnect.com;
x-microsoft-antispam-prvs: <VI1PR07MB598191811C092F095C8C3F3CA0AA0@VI1PR07MB5981.eurprd07.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(3230011)(999002)(6040522)(2401047)(5005006)(8121501046)(3231466)(944501520)(52105112)(3002001)(10201501046)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123560045)(201708071742011)(7699051)(76991095); SRVR:VI1PR07MB5981; BCL:0; PCL:0; RULEID:; SRVR:VI1PR07MB5981;
x-forefront-prvs: 0879599414
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(396003)(39860400002)(346002)(136003)(366004)(189003)(199004)(13464003)(2501003)(14454004)(6116002)(6486002)(3846002)(44736005)(76176011)(52116002)(229853002)(2906002)(186003)(84392002)(110136005)(102836004)(33896004)(53546011)(6436002)(386003)(6506007)(6246003)(68736007)(26005)(53936002)(966005)(86152003)(6512007)(9686003)(478600001)(316002)(14496001)(6306002)(97736004)(25786009)(256004)(5660300001)(446003)(476003)(71200400001)(71190400001)(486006)(86362001)(99286004)(66574011)(66066001)(7736002)(81166006)(81156014)(8676002)(1556002)(8936002)(305945005)(106356001)(105586002); DIR:OUT; SFP:1102; SCL:1; SRVR:VI1PR07MB5981; H:VI1PR07MB4717.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:0;
received-spf: None (protection.outlook.com: btconnect.com does not designate permitted sender hosts)
x-microsoft-antispam-message-info: /Q6fcVsUAO0A5J8iDF+JwqMcNAlthUsTqr6QAbsL2Jb9WtcnE1/Mgs11KfjAVLxBLBpjlGmvgLTk1BEPiFPiV3FcwjmufiO40H7D2UtLqPkLbp4Cwt/9259oO9OhcJPAqQ0vDNl7ndUfYHuOKQqwbhgGGwBFGdDaUw+0F/JO0XRaDTO3ATRCdxHWIWfTQDmGfnnVVNAZ5zMyM/fPMnDYpHUYdngy38H34fqwRxLp/pXd1U/bHi+4Yv6tc1FgVf73Zi0PGgX2wHOfQjjiehV6QKgoxughlnCus5sqr9dMq2v5KXg0Gk1Fc1VUiJGwvw9fEa/Ob1uD6vxUygHTwjtnh4MaFJpv14Jmgu3Lf3V1cR8=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <AE73C19E36FE7147BEEB2D545197939E@eurprd07.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a6ce639-9fa2-4e73-ff32-08d65c4250b4
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2018 12:48:41.3621 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR07MB5981
Archived-At: <https://mailarchive.ietf.org/arch/msg/ccamp/wVyqLy99wnc1EDB3XBqDld8DDJI>
Subject: Re: [CCAMP] I-D Action: draft-ietf-ccamp-wson-yang-18.txt
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Dec 2018 12:48:47 -0000

----- Original Message -----
From: "Leeyoung" <leeyoung@huawei.com>;
To: <ccamp@ietf.org>;
Sent: Wednesday, December 05, 2018 5:23 PM
>
> This revision, we hope, incorporated all comments from Tom and others.
The co-authors believe that it is ready for WG LC.

Almost but I fear that there is a step backwards as well.

You still have two
Wavelenghth
which should probably be
Wavelength

More problematically, you have introduced

  description
    " ...
     The YANG model described in this document is a WSON
     technology-specific YANG model augmenting the generic TE
     topology module [TE-TOPO] based on the information model
     developed in [RFC7446] and the two encoding documents
     [RFC7581] and [RFC7579] that developed protocol independent
     encodings based on [RFC7446].

Those [RFC..] look like XML/HTML style references which will not do.  A
YANG module must be plain text so
  RFC6163
is fine in a YANG module but
  [RFC6163]
is not, which is why, in my last comment, I suggested putting a
reference to RFC6163 in section 1.4 lest you get an unused reference for
the I-D; which you have done, so that is fine, but all those [RFC...] in
the YANG module must go.  AFAICS it is only the description clause that
has them.

For TE-TOPO, you need to use the same text as you have correctly done on
the YANG import statement i.e.

 "RFC YYYY: YANG Data Model for Traffic Engineering (TE) Topologies";

/* Note: The RFC Editor will replace YYYY with the number assigned to
the RFC once draft-ietf-teas-yang-te-topo becomes an RFC.*/

Whether this is fixed before or after Last Call is one for the WG
Chairs.

I probably said before that the nature of the module, which you are
forced to use because of the way that tet: is structured, makes the
module very hard to read and that I have not done; I hope to but may
never find the time.

Tom Petch

> Thanks & best regards,
> Young
>
> -----Original Message-----
> From: CCAMP [mailto:ccamp-bounces@ietf.org] On Behalf Of
internet-drafts@ietf.org
> Sent: Wednesday, December 5, 2018 11:18 AM
> To: i-d-announce@ietf.org
> Cc: ccamp@ietf.org
> Subject: [CCAMP] I-D Action: draft-ietf-ccamp-wson-yang-18.txt
>
>
> A New Internet-Draft is available from the on-line Internet-Drafts
directories.
> This draft is a work item of the Common Control and Measurement Plane
WG of the IETF.
>
>         Title           : A YANG Data Model for WSON (Wavelength
Switched Optical Networks)
>         Authors         : Young Lee
>                           Dhruv Dhody
>                           Aihua Guo
>                           Victor Lopez
>                           Daniel King
> Filename        : draft-ietf-ccamp-wson-yang-18.txt
> Pages           : 77
> Date            : 2018-12-05
>
> Abstract:
>    This document provides a YANG data model for the routing and
>    wavelength assignment (RWA) TE topology in wavelength switched
>    optical networks (WSONs). The YANG data model defined in this
>    document conforms to the Network Management Datastore Architecture
>    defined in RFC 8342.
>
>
> The IETF datatracker status page for this draft is:
> https://datatracker.ietf.org/doc/draft-ietf-ccamp-wson-yang/
>
> There are also htmlized versions available at:
> https://tools.ietf.org/html/draft-ietf-ccamp-wson-yang-18
> https://datatracker.ietf.org/doc/html/draft-ietf-ccamp-wson-yang-18
>
> A diff from the previous version is available at:
> https://www.ietf.org/rfcdiff?url2=draft-ietf-ccamp-wson-yang-18
>
>
> Please note that it may take a couple of minutes from the time of
submission until the htmlized version and diff are available at
tools.ietf.org.
>
> Internet-Drafts are also available by anonymous FTP at:
> ftp://ftp.ietf.org/internet-drafts/
>
> _______________________________________________
> CCAMP mailing list
> CCAMP@ietf.org
> https://www.ietf.org/mailman/listinfo/ccamp
>
> _______________________________________________
> CCAMP mailing list
> CCAMP@ietf.org
> https://www.ietf.org/mailman/listinfo/ccamp